Date: Mon, 2 Sep 2024 20:35:15 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Partitioned tables and [un]loggedness
Message-ID: <ZtZn0-JVQuBUbpWw@nathan>
References: <20240424202640.GB861150@nathanxps13>
 <CAKFQuwY3RTTrp7x4OmEruMmOghdorhq4=eC0ZfG0NM+HnBWFsw@mail.gmail.com>
 <ZimXRKOSHMjQjAy3@paquier.xyz>
 <CAKFQuwZwMOkw-7112u1-gXEhRWuXiZe9otp801Z3dPVvarKdsA@mail.gmail.com>
 <Zimb7xfc79Har77d@paquier.xyz>
 <ZjMte53zQpZNfTWv@paquier.xyz>
 <Zs4-xnNDMEdiKQXo@nathan>
 <ZtAY3ZkRVAIp3sxG@paquier.xyz>
 <ZtCKiJZaoYBHBv05@nathan>
 <ZtZW4gEJOPmeP-nT@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZtZW4gEJOPmeP-nT@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZtZn0-JVQuBUbpWw%40nathan>
Precedence: bulk

On Tue, Sep 03, 2024 at 09:22:58AM +0900, Michael Paquier wrote:
> On Thu, Aug 29, 2024 at 09:49:44AM -0500, Nathan Bossart wrote:
>> IMHO continuing to allow partitioned tables to be marked UNLOGGED just
>> preserves the illusion that it does something.  An ERROR could help dispel
>> that misconception.
> 
> Okay.  This is going to be disruptive if we do nothing about pg_dump,
> unfortunately.  How about tweaking dumpTableSchema() so as we'd never
> issue UNLOGGED for a partitioned table?  We could filter that out as
> there is tbinfo->relkind.

That's roughly what I had in mind.

-- 
nathan