Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slzyU-002URC-5f for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 00:03:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1slzyS-00HDNV-Mu for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 00:03:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slzyS-00HDMh-Cp for pgsql-hackers@lists.postgresql.org; Thu, 05 Sep 2024 00:03:44 +0000 Received: from fout3-smtp.messagingengine.com ([103.168.172.146]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slzyQ-000Bon-0w for pgsql-hackers@lists.postgresql.org; Thu, 05 Sep 2024 00:03:43 +0000 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id D30791380421; Wed, 4 Sep 2024 20:03:40 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 04 Sep 2024 20:03:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1725494620; x=1725581020; bh=dW8+OV692/ 8WjIdtszlGvhXsWeNaqqr6IPp6tJckj1c=; b=HIFbXYj1a6i1Kc5Po8CzJ/Jm+J DIHy+Kpaq1YEVGMVzWEyJoSc7sKDgs+ShCQUGN1ZTTlNAKPBGBgMoSciVZ1ku3om T20EkCy8i7C0YmzUe3d4luwBOqXN4b5yDT1lTZXhymk7DXKTPyL9gZIu24GbnU/8 pD2b3LEygWM6KhoYjtjzB8eP1eG1FkussA7u0r/1ipnrecZ/5OInQCgO8Hn/9Jjl tsFft1hD2lYt2viiRJPaPPI+kw3e4kGGaYpORnZlAwNrbm1LykJr3F5NppIAdD4K JqfuZtl+IbXH0fU+SljXPDzUTFILYySHr8+yy/OXe6/KbHdP73td11d9xbQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725494620; x=1725581020; bh=dW8+OV692/8WjIdtszlGvhXsWeNa qqr6IPp6tJckj1c=; b=k6ap2kA4x07xFslEjyqG2cu9Z1kKGtTUfCeb/8XoQNCZ mSwK3dEQqZU6bbSciu1vholfSl+yG5STbtLFl2cIY3mcs7oGgkjAt7z0h1RL6m6P 2tHO0UeQQxALtMVd+0ZcsfErWDGg8HLE1A+G6TDZggnxhtYtpaSL1j2q6ZL9dHa1 urMBtskQQxyWiPLHWhSc8fWThDih8sG3/aqTTz9NpHhdvoXReF8b8+Sr+3ROTnlm Pl1W899aCuSD6cR05VB4G+Yv65qfrhI6e1YZ75muBSmr9on29g2R/mERs4Dq16jg BrgkwLFEAexUrTStVXHf5+2aS3e1Nee13r+nR+pEZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehkedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdlfeehmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepgeff jeevgfevuddvjedtvddtieejheduueelvddufedtgfefjedvkeevkeeivddvnecuffhomh grihhnpehpohhsthhgrhgvshhqlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquhhivghrrdighiiipd hnsggprhgtphhtthhopeekpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegughhr ohiflhgvhihmlhesghhmrghilhdrtghomhdprhgtphhtthhopegurghnihgvlheshigvsh hqlhdrshgvpdhrtghpthhtohepvgigtghluhhsihhonhesghhmrghilhdrtghomhdprhgt phhtthhopehtghhlsehsshhsrdhpghhhrdhprgdruhhspdhrtghpthhtoheprhhosggvrh htmhhhrggrshesghhmrghilhdrtghomhdprhgtphhtthhopegshigrvhhuiiekudesghhm rghilhdrtghomhdprhgtphhtthhopehhlhhinhhnrghkrgesihhkihdrfhhipdhrtghpth htohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdho rhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Sep 2024 20:03:37 -0400 (EDT) Date: Thu, 5 Sep 2024 09:03:26 +0900 From: Michael Paquier To: David Rowley Cc: Daniel Gustafsson , Alexander Lakhin , Tom Lane , Robert Haas , Nazir Bilal Yavuz , Heikki Linnakangas , PostgreSQL Developers Subject: Re: Typos in the code and README Message-ID: References: <15512E98-BDB0-44E3-AAB6-217F322AB5F0@yesql.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FhseSUv/8ZdkoOBT" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --FhseSUv/8ZdkoOBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 05, 2024 at 03:34:31AM +1200, David Rowley wrote: > Anyway, I doubt hard > guidelines are warranted here, but maybe some hints about best > practices in https://wiki.postgresql.org/wiki/Committing_checklist ? Yep, that may be useful. I just tend to be cautious because it can be very easy to mess up things depending on the code path you're manipulating, speaking with some.. Experience on the matter. And an RC1 is kind of something to be cautious with. -- Michael --FhseSUv/8ZdkoOBT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbY9U4ACgkQnvQgOdby QH1VZw//VCDDqCz5b07PXcVyF8Brpqo6NzmG5GwowYTnHmrr79JJtcOqFrf3o+kf cVVcrqe6bGsrJzZdKGGs6As0HFKvfCfXmz5dAUv4+EqUjbi6DTducSKdzYwEPBlD vvq2gmnWoiNOZ4xort+o3d19HhP8g19j2y2MmvYZa3ec6yeD4niGcKrO5JhA385W 96I0ZiUhCShRf4uUjze/QrxXxWYAAaADePxJ8qCTieaoorkdwgm8v3+3hVWM3nW1 mfkSIE9oZrdpWoDmIGK8/bvHYQ9GJXGD8Z5D9RTNG686+g+GgC8Rs5lhiVE6tOIi Hmc5nvHbu87au7jhW8cf8AL+Pw+IqWdCPu0hXM5qQumePxAjlPaXEEbTkhFBJnPl OY699qQleWN4l35RduTYx2gd6w57DenlM+nAF9dRrWrW3Jx9/OXiJlbArzxTzy1P yi5y1pDdrilOgw6j8WJ3Hwv661IEg3IFBN74nIBRziyED2hnjy4lKqmqmhYt5FTX ijJOrG2SGyROdUJ4QKKTSflZJ+aWhg1VbjdhNAzk5tgYyZEIlZgyYTQhF17EHlDg iQLRhMsBMHkgtVTlTg3GFaVKQpY+7H78uJsTKVw/sjfDtbCNHJqOlDrH0fVau0Xu cVIweuCWTT1GOuJR0EfG66ss7/jfEyavG3TbiG+GrtOvrisAQoM= =I3LR -----END PGP SIGNATURE----- --FhseSUv/8ZdkoOBT--