Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 5 Sep 2024 10:59:13 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Maxim Orlov <orlovmg@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to
 missing injection_points
Message-ID: <ZtkQcTqG5FdqruKs@paquier.xyz>
References: <202408232225.y7hnnrinboo2@alvherre.pgsql>
 <2304030.1724453102@sss.pgh.pa.us>
 <ZtUMiuau2_InCfLZ@paquier.xyz>
 <ZtesYQ-WupeAK7xK@paquier.xyz>
 <CACG=eza1Z_FG-ZgNRieK6gHoxghBymezqcHJkdOWdxALbLWSVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="t40BgHxz1ODeQBrl"
Content-Disposition: inline
In-Reply-To: <CACG=eza1Z_FG-ZgNRieK6gHoxghBymezqcHJkdOWdxALbLWSVA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZtkQcTqG5FdqruKs%40paquier.xyz>
Precedence: bulk


--t40BgHxz1ODeQBrl
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 04, 2024 at 07:05:32PM +0300, Maxim Orlov wrote:
> Works for me with configure build. Meson build, obviously, still need ext=
ra
> "meson compile install-test-files" step
> as expected. From your patch, I see that you used safe_psql call to check
> for availability of the injection_points
> extension.

> Are there some hidden, non-obvious reasons for it? It's much
> simpler to check output of the
> pg_config as =C1lvaro suggested above, does it? And we don't need active =
node
> for this. Or I miss something?

Even if the code is compiled with injection points enabled, it's still
going to be necessary to check if the module exists in the
installation or not.  And it may or may not be around.

One thing that we could do, rather than relying on the environment
variable for the compile-time check, would be to scan pg_config.h for
"USE_INJECTION_POINTS 1".  If it is set, we could skip the use of these
environment variables.  That's really kind of the same thing for
with_ssl or similar depending on the dependencies that exist.  So
that's switching one thing to the other.  I am not sure that's worth
switching at this stage.  It does not change the need of a runtime
check to make sure that the module is installed, though.

Another thing that we could do, rather than query
pg_available_extension, is implementing an equivalent on the perl
side, scanning an installation tree for a module .so or equivalent,
but I've never been much a fan of the extra maintenance burden these
duplications introduce, copying what the backend is able to handle
already in a more transparent way for the TAP routines.

> And one other thing I must mention. I don't know why, but my pg_config fr=
om
> meson build show empty configure
> despite the fact, I make pass the same options in both cases.
>=20
> autotools:
> $ ./pg_config --configure
> '--enable-debug' '--enable-tap-tests' '--enable-depend' ....
>=20
> meson:
> $ ./pg_config --configure

Yes, ./configure does not apply to meson, so I'm not sure what we
should do here, except perhaps inventing a new option switch that
reports the options that have been used with the meson command, or
something like that.
--
Michael

--t40BgHxz1ODeQBrl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbZEHAACgkQnvQgOdby
QH14/Q/9FjD93n0FoIXc3h+kVtfeXVF4aiWOSbMzxAgZ/RTLDkn/BynCRTwxQk3R
juwtl1Ma18D39E4qm8jUEP1pMgpzA7RDVgIQflwIa5iyQ1ySbpN9mTS9/XBtQOTj
T8MCxADwKmPLpz/ljpTUtoZ23zDmAdYbRdu9IDx2hgMGOFvep9zymGcjQWbZQuZn
w+BWWA5VAslTEOWZA+qkoWrW9iuDTDxLjkizr4P3E+AHIOTIlR6usbDbz8wwVQB3
qJ/wZuxkA/o9E0cGFllqvzN3kRryi8yvD182M4Ia6JJZdkxXJ0KtaZ9IXfmQdTAd
Kn4KoFu90ItFfhoUUH7QYOceiazDd9kswhJ94v0fS67/fRqlWkHiHDk3Hj4tDsLd
C1n+INaD8qnVS5oQm+u6JNGFahzDQ7Uhpe5fjAjeu+HFhUtIx0zPQ8OMx9dGz3l3
8eooMVxDVBXIoAK/8GyWhV35HtEtKYDo/0v9rLPv7UwbUu6xlHRZRjResuyYN4fM
o7csLivQ9QafHZZ3ZVEEZ9nLDpmljYxV2rQcmbs2YnnT82N205lc7/b1njQ+8Akp
4kb36d+Vx/NTEY75Gxw/gUqxisuM2AHsZZOl9X2VaNWbN+vut9wAQ1Vq/VSFN0YV
xHqGZZuA/DOqlA5rjKOCQUt7uF4bBExbM4MonyAF0txtPvIemXw=
=P1FJ
-----END PGP SIGNATURE-----

--t40BgHxz1ODeQBrl--