Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 20 Sep 2024 14:23:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: "Jonathan S. Katz" <jkatz@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alexander Lakhin <exclusion@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should rolpassword be toastable?
Message-ID: <Zu0G7s-k8iECVG7i@paquier.xyz>
References: <1284094.1695479962@sss.pgh.pa.us>
 <67793ae1-3adc-a6e0-0bb3-c23a28c0627a@gmail.com>
 <a9524f94-316c-349a-6e4d-79b878706f82@gmail.com>
 <Zuwzp09o9uiG0f0F@nathan>
 <1986859.1726756275@sss.pgh.pa.us>
 <ZuxjAIOJ4GSa34KC@nathan>
 <ZuydAj4nrt4cpGU5@nathan>
 <2047353.1726784074@sss.pgh.pa.us>
 <0a9b7f96-aa2f-41eb-8e69-62f7990ebf74@postgresql.org>
 <Zuzh6Nq750L9BZn5@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CcpU2iR/nyzAsL1L"
Content-Disposition: inline
In-Reply-To: <Zuzh6Nq750L9BZn5@nathan>
Archived-At: <https://www.postgresql.org/message-id/Zu0G7s-k8iECVG7i%40paquier.xyz>
Precedence: bulk


--CcpU2iR/nyzAsL1L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 19, 2024 at 09:46:00PM -0500, Nathan Bossart wrote:
> On Thu, Sep 19, 2024 at 07:37:55PM -0400, Jonathan S. Katz wrote:
>>> Shouldn't we enforce the limit in every case in encrypt_password,
>>> not just this one?  (I do agree that encrypt_password is an okay
>>> place to enforce it.)
>=20
> Yeah, that seems like a good idea.  I've attached a more fleshed-out patch
> set that applies the limit in all cases.

Not sure.  Is this really something we absolutely need?  Sure, this
generates a better error when inserting a record too long to
pg_authid, but removing the toast relation is enough to avoid the
problems one would see when authenticating.  Not sure if this argument
is enough to count as an objection, just sharing some doubts :)

Removing the toast relation for pg_authid sounds good to me.

>  -- These are the toast table and index of pg_authid.
> -REINDEX TABLE CONCURRENTLY pg_toast.pg_toast_1260; -- no catalog toast t=
able
> +REINDEX TABLE CONCURRENTLY pg_toast.pg_toast_1262; -- no catalog toast t=
able
>  ERROR:  cannot reindex system catalogs concurrently
> -REINDEX INDEX CONCURRENTLY pg_toast.pg_toast_1260_index; -- no catalog t=
oast index
> +REINDEX INDEX CONCURRENTLY pg_toast.pg_toast_1262_index; -- no catalog t=
oast index

This comment should be refreshed as of s/pg_authid/pg_database/.
--
Michael

--CcpU2iR/nyzAsL1L
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbtBu4ACgkQnvQgOdby
QH05DA/+KBGs+pUnTy7TSpC3QYnqQq45JpFClgHD6H1Cr2zQrVNXSSfF48N5YZQz
l9HfFN/r5kvax0/Y4zrjG/wt69I60jibV888kqdopRlVGQ+gYHZOL3Bp5Qcs2yot
lHhcJ5gXVhj7ulzCOYd6GjT1Nas/NAfvIt0NfURU3AsY3vTiteNxIpWdPgcYg4sD
r5FVF47mFSv5fRbjhz2a5q+EZvwR+yWkFGHKN2lQmiAtlnx7uY6t0CCH3WZ1osLk
Vt9sQbMgrORR1W9szEuxjzzrU4mZ/p2aIMMEVuHN0PxU1LOLfp/DeLpUO05wHjqm
GCsDkZmg+RWGPCEzxKIRiIYGOXfnzBpPP3PPWO1UDrTp4LCYnSC7vTvjN3tvRQge
2Cm8c2gnUbHcHqnxG1dzolcs0H8CnKgFfBrT+65yte04tHUm9xnPhdZ4gZkx6vIf
Q6+VoOgTatMQf4Ss/2kHgrFpP/uxCVuD4TEVlnQ+yBrdQ/jqFy3NBOUgbre1nsFw
3I2YsEWOn/x5ZR9cGM4pfXjXay3jY96Zy7tXnKWgRM9EagKltd4/Gj3MPSPmZTw6
NOrfzdSMpwnFGcS+5x75JGJpP2lfiG4LjwZgc3ecL2197IeSieDYhu04TYNooKn7
acoKhNBO5XJiihtcjMdKyLvaZ5n2P75nCzNuRk5xjXn9Y0I0Y1w=
=7Msm
-----END PGP SIGNATURE-----

--CcpU2iR/nyzAsL1L--