Date: Fri, 20 Sep 2024 09:27:47 -0400
From: Bruce Momjian <bruce@momjian.us>
To: jian he <jian.universality@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: attndims, typndims still not enforced, but make the value within
 a sane threshold
Message-ID: <Zu14U-whwiOu86bc@momjian.us>
References: <CACJufxH0RxsxUQnAT2AVG08JFpA3C60L91_cEMM8JQd8P=12ow@mail.gmail.com>
 <1807434.1726668657@sss.pgh.pa.us>
 <CACJufxEqJyD0o6t9f1NLp2cgaUeyRzNv+PiDuKnrP1xekHFYyQ@mail.gmail.com>
 <CACJufxEF9_o_tZeNg+rDV5MfQW6eYTdM9MUcy0Z5-VMWvf-tOw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACJufxEF9_o_tZeNg+rDV5MfQW6eYTdM9MUcy0Z5-VMWvf-tOw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zu14U-whwiOu86bc%40momjian.us>
Precedence: bulk

On Fri, Sep 20, 2024 at 10:11:00AM +0800, jian he wrote:
> On Wed, Sep 18, 2024 at 10:35 PM jian he <jian.universality@gmail.com> wrote:
> >
> > > The last time this was discussed, I think the conclusion was
> > > we should remove attndims and typndims entirely on the grounds
> > > that they're useless.  I certainly don't see a point in adding
> > > more logic that could give the misleading impression that they
> > > mean something.
> > >
> 
> 
> attached patch removes attndims and typndims entirely.
> some tests skipped in my local my machine, not skipped are all OK.

I have been hoping for a patch links this because I feel the existence
of these system columns is deceptive since we don't honor them properly.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"