Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1spEja-0001em-C2
	for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Sep 2024 22:25:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1spEjZ-00Dv6m-QO
	for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Sep 2024 22:25:45 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1spEjZ-00Dv6e-Fn
	for pgsql-hackers@lists.postgresql.org; Fri, 13 Sep 2024 22:25:45 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1spEjV-0013UT-Ld
	for pgsql-hackers@postgresql.org; Fri, 13 Sep 2024 22:25:44 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2024011501; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-ID:Content-Description;
	bh=hdj+k/yKXt6GC6j3/7AkpgMlsCV2QR7ayY6wXzSUY2U=; b=hcbTFi9q2W8tICfa1hNvroLVWL
	SOmvyfgnx8mFn7m7PZbz1iXNZNDPybMZGfP80L+/xmBz24HM+A8ITXvTxNmoF7SVbqemrNxmJEKP4
	TOW2PlYjwI3Wg2vwl3g+0QleNEwtrFbyDRR0wV97GGHPnqyeIoB8+QqGiH8CUjiOxBgYuminz+bg+
	rPIB6xj7Bicm7y2u5SSTc3YJCXJjJYMaf9kOfmCtDB6k200RrrfokrkcSRMUboNy4vCt8mGeESj25
	iZdHhe5RwTv2GAd1Oiodgy+KaGRa9l+iT3eImZMXLMTrivulHCoU6kou/072bkprPgSDVyhtFCdhM
	nDxtYq7A==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1spEjV-000kDY-1P;
	Fri, 13 Sep 2024 18:25:41 -0400
Date: Fri, 13 Sep 2024 18:25:41 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-ID: <ZuS75R-3vT0nw8Qv@momjian.us>
References: <ZjxLJpnH4VMkOMmi@momjian.us>
 <202409111750.xtcbl7ppdoyn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="wxjDPBwRfUcZPEwp"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202409111750.xtcbl7ppdoyn@alvherre.pgsql>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/ZuS75R-3vT0nw8Qv%40momjian.us>
Precedence: bulk


--wxjDPBwRfUcZPEwp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Wed, Sep 11, 2024 at 07:50:40PM +0200, Álvaro Herrera wrote:
> Hello,
> 
> I noticed that these two items in the current notes are separate:
> 
> <!--
> Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
> 2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
> Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
> 2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
> -->
> 
>      <listitem>
>       <para>
>       Allow specification of partitioned <link linkend="tableam">table
>       access methods</link> (Justin Pryzby, Soumyadeep Chakraborty,
>       Michael Paquier)
>       </para>
>      </listitem>
> 
> <!--
> Author: Michael Paquier <michael@paquier.xyz>
> 2024-03-08 [d61a6cad6] Add support for DEFAULT in ALTER TABLE .. SET ACCESS MET
> -->
> 
>      <listitem>
>       <para>
>       Add <literal>DEFAULT</literal> setting for <literal>ALTER TABLE
>       .. SET ACCESS METHOD</literal> (Michael Paquier)
>       </para>
>      </listitem>
> 
> They are very very closely related, so I suggest they should be
> together as a single item.  Also, the first one is somewhat strangely
> worded IMO (we don't have "partitioned table access methods" -- rather,
> we have table access methods for partitioned tables).  Maybe something
> like

Yes, agree, the wording needs improvement, patch attached.

> * Improve ALTER TABLE ... SET ACCESS METHOD
> 
>   This command can now also be applied to partitioned tables, so that it
>   can <link to "https://www.postgresql.org/docs/17/sql-altertable.html#SQL-ALTERTABLE-DESC-SET-ACCESS-METHOD">
>   influence partitions created later</link>. (Justin, Soumyadeep, Michaël)
> 
>   In addition, it now accepts the value DEFAULT to reset a previously
>   set value. (Michaël)

I moved the two items next to each other, but I am concerned combining
the partition feature with the DEFAULT features is just making it too
complicated to understand.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

--wxjDPBwRfUcZPEwp
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="REL_17_STABLE.diff"

diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index 36e19bb8329..6d4ffa8ea1e 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -1659,23 +1659,6 @@ Author: Peter Eisentraut <peter@eisentraut.org>
       </para>
      </listitem>
 
-<!--
-Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
-2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
-Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
-2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
--->
-
-     <listitem>
-      <para>
-      Allow specification of partitioned <link linkend="tableam">table
-      access methods</link> (Justin Pryzby, Soumyadeep Chakraborty,
-      Michael Paquier)
-      <ulink url="&commit_baseurl;374c7a229">&sect;</ulink>
-      <ulink url="&commit_baseurl;e2395cdbe">&sect;</ulink>
-      </para>
-     </listitem>
-
 <!--
 Author: Peter Eisentraut <peter@eisentraut.org>
 2024-01-13 [4f622503d] Make attstattarget nullable
@@ -1714,6 +1697,23 @@ Author: Peter Eisentraut <peter@eisentraut.org>
       </para>
      </listitem>
 
+<!--
+Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
+2024-03-25 [374c7a229] Allow specifying an access method for partitioned tables
+Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
+2024-03-28 [e2395cdbe] ALTER TABLE: rework determination of access method ID
+-->
+
+     <listitem>
+      <para>
+      Allow specification of <link linkend="tableam">table access
+      methods</link> on partitioned tables (Justin Pryzby, Soumyadeep
+      Chakraborty, Michael Paquier)
+      <ulink url="&commit_baseurl;374c7a229">&sect;</ulink>
+      <ulink url="&commit_baseurl;e2395cdbe">&sect;</ulink>
+      </para>
+     </listitem>
+
 <!--
 Author: Michael Paquier <michael@paquier.xyz>
 2024-03-08 [d61a6cad6] Add support for DEFAULT in ALTER TABLE .. SET ACCESS MET

--wxjDPBwRfUcZPEwp--