Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 18 Sep 2024 15:07:15 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: define pg_structiszero(addr, s, r)
Message-ID: <ZupuE74kkcC_LhGy@paquier.xyz>
References: <ZupUDDyf1hHI4ibn@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="uSRNnUkuajDTysm5"
Content-Disposition: inline
In-Reply-To: <ZupUDDyf1hHI4ibn@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/ZupuE74kkcC_LhGy%40paquier.xyz>
Precedence: bulk


--uSRNnUkuajDTysm5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 18, 2024 at 04:16:12AM +0000, Bertrand Drouvot wrote:
> The macro is created in pgstat_internal.h as it looks like that "only" th=
e=20
> statistics related code would benefit of it currently (could be moved to =
other
> header file later on if needed).

I'm OK to add a helper macro in pgstat_internal.h as this is a pattern
used only for some stats kinds (the other one I'm aware of is the
allzero check for pages around bufmgr.c), cleaning up all these static
declarations to make the memcpy() calls cheaper.  That can also be
useful for anybody doing a custom pgstats kind, fixed or
variable-numbered.

#define pg_structiszero(addr, s, r)                                 \

Locating that at the top of pgstat_internal.h seems a bit out of order
to me.  Perhaps it would be better to move it closer to the inline
functions?

Also, is this the best name to use here?  Right, this is something
that may be quite generic.  However, if we limit its scope in the
stats, perhaps this should be named pgstat_entry_all_zeros() or
something like that?
--
Michael

--uSRNnUkuajDTysm5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbqbhMACgkQnvQgOdby
QH1Q6w//dwaj1oylAchaWCUMJPQFat/GEU2WdzcLOBJIoArbOByLlTsAcfOLSmv3
qSzLNoLwBjiZy+/fHSYQYqcWmCWiekJf1odhlVm2BCgGMXnNJIDkv7r/6fpd5f2z
SscFSgbYsrh/wk8dt7XwTOS+TrPceTlCVzWO8n7EAYRt2WVmAY6XEGkFej3UgguU
C6cp86kEqItYcJDWuM/pcvQzeONjXhG88LbAV8jzq+CHMh/skMpF/vKreYYBXIEh
cKO32mxGuFMWMzt9pYQj2wzZ4E7AnR8Qyjg3nP+Jfuq1UEF9TuyG7PlSKQ6O5IyM
8fPBhVgraLzzTGgCOEpAhENFiRVHGdBigXSHrkro/aTv54Z5d07tuDbPpWv5zNkC
GVeCtu+066j6Wr+o8Id2FHWiG8EZsnqZYAbltn7nVVo7t3J0PJYZXt9CBEySmt/D
90EpwBl3x0OvUNMyEdj/L0oLv0xm2qePK+5/L03rsw27CSE06T8zOp+NrbPalVeb
zlGUefcpNN4A+OyT8Kul3dwMUCHenU52tttmHGeeV0HDLhaqL2UyYOMrgC19rm6u
9CDscHxeGJg0rVyuJ97EJDwYEXNrEr3L6HkGjAMzsr+uSnqU+CARYMvCd1cyis89
29Sf51cCBaipCuvEkqIBFrltNndxBoJfBCYGSTP2dYYBmLEPpFs=
=ADv4
-----END PGP SIGNATURE-----

--uSRNnUkuajDTysm5--