Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sr3lD-00FDau-3m for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Sep 2024 23:06:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sr3lA-00HGeN-OS for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Sep 2024 23:06:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sr3l9-00HGeE-4W for pgsql-hackers@lists.postgresql.org; Wed, 18 Sep 2024 23:06:56 +0000 Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sr3ky-001tlf-On for pgsql-hackers@lists.postgresql.org; Wed, 18 Sep 2024 23:06:51 +0000 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 6FF5E1140162; Wed, 18 Sep 2024 19:06:41 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Wed, 18 Sep 2024 19:06:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1726700801; x=1726787201; bh=mEi0qrGhFt QMkcAVJQXWVpneKEruzLBH2R3takkGSfU=; b=BEpVxHlgSPX/qpJhvQhT3kypS0 wRbTaBtoQLIpryRX/ohMAjTmEZ5OQFDyxH/QCBpCaBVZO+KxCXXVCe2yuyhVZ8Z/ eV2oM3sO2iXRoOBKhIBZB+/R+Bn0ycMiNEhtVKDaicgyPvjq10NB9pYFMucRGKDp cCYLvxnlfKvQWskRbsdxIvzzNi0FW9cTXLmVQP/ZfjzN9qxvvuy9xgNQYunESapx yHHCQOR/6Af7JPQpt/Eq3qgOO7vzU+nIlaf3hDJV44LTNh5bcRr39g+FfYvGNlF+ u8jKO9pRstvF5K79fWoiAXwAx959fOmM0Z6wiiwwDNZK9imolQREhDvu3QgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1726700801; x=1726787201; bh=mEi0qrGhFtQMkcAVJQXWVpneKEru zLBH2R3takkGSfU=; b=TuB2G1vuAZ/6BrnsSPFAgjl5qVwbCA29mra10Mt883Ve L44iD7EPZaZSEv6MA6JLSgh7lWOSFiE3oTlBdYHsq+qGwDZwH+ex93l9RaC3XGTU CtDOXqCN3P4D8echeUcPhi9OrTflVzkUJkwh7shGI2c0LCqmxhJ8ADaymMetDsRe 8f19NpmGhJltD+7Ar/5rL/5e0580aV42m8aZFhO8/lxvQp3G3U0D0CeZplSnbPFz RgRc73Wnjs6A2CUa6kjbbx9yfyyb9ieG6BkQxaZG4HwkEuV9kvBxXnM13CvyIYY+ oxchk7QkaXkmGNJAqmcPnum9VXAuFZ4Z86pN7wcJ9w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeltddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepnhgrthhhrghnuggsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhr tghpthhtohepuggrvhhiugdrghdrjhhohhhnshhtohhnsehgmhgrihhlrdgtohhmpdhrtg hpthhtohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhl rdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Sep 2024 19:06:39 -0400 (EDT) Date: Thu, 19 Sep 2024 08:06:19 +0900 From: Michael Paquier To: Nathan Bossart Cc: "David G. Johnston" , Postgres hackers Subject: Re: Partitioned tables and [un]loggedness Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="q8KbMccdX/mpiY99" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --q8KbMccdX/mpiY99 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2024 at 10:58:34AM -0500, Nathan Bossart wrote: > On Wed, Sep 18, 2024 at 10:17:47AM -0500, Nathan Bossart wrote: >> Could we also use ATT_PARTITIONED_TABLE to remove the partitioned table >> check in ATExecAddIndexConstraint()? >=20 > Eh, never mind. That ends up being gross because you have to redo the > relation type check in a few places. I did not notice this one. I have to admit that the error message consistency is welcome, not the extra checks required at transformation. -- Michael --q8KbMccdX/mpiY99 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmbrXOsACgkQnvQgOdby QH1hGQ/9HVBrJI3EpUm15wJ8TCrHuaIWk0RXz7R+risQvSnQyvNPtPQIJKwzMB70 z+IJqQ+Z4RSwDWYXyuLVaBV+jp/3SJQiLA1Ss2pt4Zw2eVCLVK471V7lv6rcAKU4 hjRk1kNI1XKKGqIES9h3Ibn+xMPHkJOyVN9dC1+UL0IMK5AnbwcOfigg6My6E1ZJ ZsJx+2ToZCsp3hfRivy9S06SKmVmEZi3WVDv4cRO9i6y6V6kFDClQcW7SVU8gNyY VBf+EYF0CsXPJvBZluiPNcnhxtHFGX36eVq1cXOMOIkjRAcTi+e+GZmnjVMfmNAq 21tVUbYqhRsSHdRcxLAupsSVCCH/TqENuO7ZSbF2/SnGgWc2+Odk1Oy/X48y+XNl b6MYeoWCuN+rdq1B+dZLT0xFnM8bKY7BiBVSFTtKMgMvsN2tO9UfqwnAlLVmmZGS z/9AJsAbmiYMDqbiOVFMRWxOtglPl9IkMhyTfkPLlTn4KF6qHf0GVCtDcrxtnAnI I0vQuUHmRYlyMcwFzFanszCkYoMdiOfihaZ5d6wmN/w9Kwm+4lt6vp20QGpuVYxg bSSuuXvQT/+bTR3pv2cWf7QqBIKgPkm2wLqeyVv63cTL1XfV0RljJb2FzwKg930w NwfpJyoKRrzCWbmqnPiZ8iUTrIDZmpb0rvqlAPoFpyTOkzgmvW0= =iOnk -----END PGP SIGNATURE----- --q8KbMccdX/mpiY99--