Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1swTMR-003zf3-BX for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Oct 2024 21:27:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1swTMQ-004PDc-NJ for pgsql-hackers@arkaria.postgresql.org; Thu, 03 Oct 2024 21:27:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1swTMQ-004P8O-Dc for pgsql-hackers@lists.postgresql.org; Thu, 03 Oct 2024 21:27:46 +0000 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1swTMN-002LgM-PZ; Thu, 03 Oct 2024 21:27:45 +0000 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-6dbc5db8a31so12037717b3.1; Thu, 03 Oct 2024 14:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727990863; x=1728595663; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J0kXFL7PkChJhoX4LRlb2Uh9oh7T6uXbldOVaAOxgFc=; b=Vg8SS14BzV1BkElOEVMUe1+kTezN+4dnogob13FxBUaBuTOmqusHTY360muFrR44wq jAUqWvLEXM8PpJr7pisHu0hIqn2yehliPXRbMfCnLcw4tN1IPXVKetWZJ+k25etWZxRv SibU8PKWsxMGsvvZLFRe77roBdaQ4ffdT5SX4XGUbWqJ/SnRLiyfGyMa/8uTQhuSoGCD 0t3IjjUYTEfUH0tOQA8ZUEtk7Ob4N7SUmu+AJARknIbUuDUdVXb0kNdia8/F1eUea3a/ GIohl8063xmxBdbSDpO+XG2j/y8fTDV7Epm+l6BqL1VNdhsExiGKscLszQToY8xZyAEi 2J/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727990863; x=1728595663; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J0kXFL7PkChJhoX4LRlb2Uh9oh7T6uXbldOVaAOxgFc=; b=d5Acv5Dzosi8HzUNpZzLBZJqpAR7kS927TpyHjTRhxMSvx3N0WWn7VcfkszyEsc+Yy o079ttkn8drwb+iR/TW8RE+MJRS4F3QyrrSZrhav7r9b/8TF8s6BbP74oT4NImFM6DyK plX0iOA4PH4TpYdi1kXTm19XQoG/8O9RTqwFoXlyI9/0z4REIjJUft2ZbUDehPU1xeZW Q6+RTpcNzgbSy8q2z98j5sr1Ov5WgKtItw7sxjEN7sEaEgdW8yUUtrNDZHjxSHGV+/96 QqnI1I32ir+fs83gpSIIfL1uBd3DRSvSg6/1S13AUaj39q/uDpWX7wEobVEP8HV3y9Zg fkNg== X-Forwarded-Encrypted: i=1; AJvYcCX3jOvv08f+UGG1aT+dxccgBn//mxtG12tcNChTf+GHlPW0YL3g33/hoQ0ehEMFu7LYqLv9XkxFpZzrqZkl@postgresql.org X-Gm-Message-State: AOJu0YxKhFkuhIUiw+/ZjfX62pYUbZ/fnWRQ94TvfCEE+C3r/g5rTxRg VTIec1Orn0cNnm32NZY6543dfP+7omihXfZI6BI8v99pVMk2j1Tn X-Google-Smtp-Source: AGHT+IFVb5HZalnfaeD7Ve7oi/b/HYyP08+nUbruW/nGg9I2so68wiYhyLlibUPPDwLcMqflPM7KeQ== X-Received: by 2002:a05:690c:338a:b0:664:74cd:5548 with SMTP id 00721157ae682-6e2b532a5bamr38205907b3.1.1727990862954; Thu, 03 Oct 2024 14:27:42 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e2bcf9645fsm3685947b3.87.2024.10.03.14.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 14:27:42 -0700 (PDT) Date: Thu, 3 Oct 2024 16:27:40 -0500 From: Nathan Bossart To: Tom Lane Cc: "Jonathan S. Katz" , Michael Paquier , Alexander Lakhin , pgsql-hackers Subject: Re: Should rolpassword be toastable? Message-ID: References: <2047353.1726784074@sss.pgh.pa.us> <0a9b7f96-aa2f-41eb-8e69-62f7990ebf74@postgresql.org> <0d8f3541-13f4-4194-8dca-bae881cf1a9a@postgresql.org> <2445149.1726849661@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Sep 21, 2024 at 03:25:54PM -0500, Nathan Bossart wrote: > Thanks for reviewing. I went ahead and committed 0002 since it seems like > there's consensus on that one. I've attached a rebased version of 0001 > with s/characters/bytes. For the reasons discussed upthread [0], I can't bring myself to add an arbitrary limit to the password hash length. I am going to leave 0001 uncommitted for now. [0] https://postgr.es/m/Zu2eT2H8OT3OXauc%40nathan -- nathan