Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stVMB-00Gwoh-9v for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Sep 2024 16:59:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1stVMA-00BDMF-AV for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Sep 2024 16:59:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1stVMA-00BDM6-0e for pgsql-hackers@lists.postgresql.org; Wed, 25 Sep 2024 16:59:14 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1stVM2-0013Bf-NC for pgsql-hackers@postgresql.org; Wed, 25 Sep 2024 16:59:13 +0000 Received: by mail-il1-x12b.google.com with SMTP id e9e14a558f8ab-3a1a3090f39so142455ab.3 for ; Wed, 25 Sep 2024 09:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727283546; x=1727888346; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pveGO4crbnsiaMJWbpbjO2znJkcGSEvUYK/6AyvEUus=; b=FSxIUljr13Go78876+GgR5pjhKZDvaHkLYbnIMCZT+BGXyNhMvV4PesNx0T/EsiAUU /DP/DZQsPHVtR2zd7kEsCA52p7EjMYSPMsJrZyvYrpbzjPkb+3TOM1pv2Zl+EZWlQC2e cA2CSgibCQ/BnoUZcSifyi1cgrBeteHu2ZY9ClUcqtKlQKmTs2DSI03giE5BHCPK3c/8 hDrizsdOE5M8BYkt4FZRcN9vRaaiOEb57G9+kFdQeFjgyk8fRRhWKxQNcFeGE0Qz3uyX Cc1od88YDWVIk+yFbeu+RTQr3hYkM4BinwkGaW/Hb8GTKxXUcGqOD/TP26ipW7XH84zE Q23g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727283546; x=1727888346; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pveGO4crbnsiaMJWbpbjO2znJkcGSEvUYK/6AyvEUus=; b=AJxeVuWxp5V5UbhT9skEowZoAb4ZKiECKMf9Bbgmpaa5VKkd/V0AsfsoGMjM9BW92y GUS422w+U6L5Mrquf0TmqmeEb+ezlARAgJBCMl1FuX/dDd69eqJGgv86sovoQcGfjX9v EW9IfX0pItVeAinAOlZijp61HxRfPVvxiCf1zDHrrgHX+QgsHGntaBGvG1bJyqkG1Hr6 hrwk9eFOCpHHlLbTahNHC12flDkvUPvGr9HUJY9zv5C6r5mO4XbiqjY9/WTAVg97DY9l trkIrVzY0VKNSiSmwfRPJpbECJpwZcuzlVL2jlVie47IEe5aMryTvTZz+6jU+IrI9wud +obA== X-Gm-Message-State: AOJu0YwLhVIeUVHNaoaOog7jOjJiKbHveMcNpn7sxKMRqSFO2omN6rvm xhfYtlBLuZXrEjtworoKQda6C6IetgixAC/zkfMF6jbdJEhLbDz9 X-Google-Smtp-Source: AGHT+IFYh7/ax8L5aQE7zA4Dme54YEulGOFjFq+ZP9EOyv8y+WnCxz1vVmsdT9r+LTutX6m2iYqirA== X-Received: by 2002:a05:6e02:1c84:b0:39f:60d7:813b with SMTP id e9e14a558f8ab-3a26d7b1b3cmr40748765ab.22.1727283546176; Wed, 25 Sep 2024 09:59:06 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d40f2f4749sm1163707173.124.2024.09.25.09.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 09:59:05 -0700 (PDT) Date: Wed, 25 Sep 2024 11:59:04 -0500 From: Nathan Bossart To: "Daniel Westermann (DWE)" Cc: "pgsql-hackers@postgresql.org" Subject: Re: src/backend/optimizer/util/plancat.c -> Is this correct English Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Sep 25, 2024 at 04:52:47PM +0000, Daniel Westermann (DWE) wrote: > just came across this: > > src/backend/optimizer/util/plancat.c -> Is this correct English? > -> We need not lock the relation since it was already locked ... > > I am not a native speaker, but this sounds strange. I think it's fine. It could also be phrased like this: We do not need to lock the relation since... -- nathan