Date: Thu, 26 Sep 2024 15:53:33 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Message-ID: <ZvXJzVHGvDFd2xmK@nathan>
References: <1812111.1726671296@sss.pgh.pa.us>
 <ZusvlZBrPKm913LA@nathan>
 <a97d7401-e7c9-f771-6a00-037379f0a8bb@gmail.com>
 <ZuxvNDVfqpahqZNb@nathan>
 <adb7421f-eaf4-878a-6742-576fc6bf0d8f@gmail.com>
 <Zu2oJtMI2avvjmtl@nathan>
 <e012fb69-ca34-7e0e-3a33-b16d9737e526@gmail.com>
 <ZvGOPdGAronxOfmf@nathan>
 <ZvI-WXcaFXuj1Dvp@paquier.xyz>
 <ZvMSUPOqUU-VNADN@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZvMSUPOqUU-VNADN@nathan>
Archived-At: <https://www.postgresql.org/message-id/ZvXJzVHGvDFd2xmK%40nathan>
Precedence: bulk

On Tue, Sep 24, 2024 at 02:26:08PM -0500, Nathan Bossart wrote:
> On Tue, Sep 24, 2024 at 01:21:45PM +0900, Michael Paquier wrote:
>> On Mon, Sep 23, 2024 at 10:50:21AM -0500, Nathan Bossart wrote:
>>> I carefully inspected all the code paths this patch touches, and I think
>>> I've got all the details right, but I would be grateful if someone else
>>> could take a look.
>> 
>> No objections from here with putting the snapshots pops and pushes
>> outside the inner routines of reindex/drop concurrently, meaning that
>> ReindexRelationConcurrently(), DefineIndex() and index_drop() are fine
>> to do these operations.
> 
> Great.  I plan to push 0001 shortly.

Committed this one.

-- 
nathan