Date: Mon, 14 Oct 2024 16:28:34 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Improve node type forward reference
Message-ID: <Zw2NAr_ABwpD2t-9@nathan>
References: <637eeea8-5663-460b-a114-39572c0f6c6e@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <637eeea8-5663-460b-a114-39572c0f6c6e@eisentraut.org>
Archived-At: <https://www.postgresql.org/message-id/Zw2NAr_ABwpD2t-9%40nathan>
Precedence: bulk

On Mon, Oct 14, 2024 at 09:47:59AM +0200, Peter Eisentraut wrote:
> But we can do this better by using an incomplete struct, like
> 
>         struct Query *viewQuery ...;
> 
> That way, everything has the correct type and fewer casts are required. This
> technique is already used elsewhere in node type definitions.

I noticed that the examples in parsenodes.h are for structs defined within
the same file.  If the struct is defined in a separate file, I guess you
might need to include another header file wherever it is used, but that
doesn't seem too bad.

> The second patch just removes some more unnecessary casts around
> copyObject() that I found while working on this.

LGTM

-- 
nathan