From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Should rolpassword be toastable?
Date: Fri, 4 Oct 2024 09:47:56 -0500
Message-ID: <ZwAAHHC67Dk9u2X0@nathan> (raw)
In-Reply-To: <510907.1728009184@sss.pgh.pa.us>
References: <Zu2eT2H8OT3OXauc@nathan>
<2445149.1726849661@sss.pgh.pa.us>
<Zu8r0oO0Vi0FxdpB@nathan>
<Zv8MTMy87pRlRqD_@nathan>
<465160.1727991546@sss.pgh.pa.us>
<Zv8X3YVzuPfh1Fht@nathan>
<473657.1727994294@sss.pgh.pa.us>
<CAOYmi+mVJDy+ja1Un3PSZHq2G4PYq1A-ROfR-rSoOtN-PVK4XA@mail.gmail.com>
<aefad126-df60-483b-b1c5-ef3c305f5923@postgresql.org>
<510907.1728009184@sss.pgh.pa.us>
On Thu, Oct 03, 2024 at 10:33:04PM -0400, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
>> I think Tom's initial suggestion (BLCKSZ/2) is better than 256, given we
>> really don't know what' out there in the wild, and this could end up
>> being a breaking change. Every other type in pg_authid is pretty small.
>
> I'm having second thoughts about that though, based on the argument
> that we don't really want a platform-dependent limit here.
> Admittedly, nobody changes BLCKSZ on production systems, but it's
> still theoretically an issue. I don't have a problem with selecting
> a larger limit such as 512 or 1024 though.
Since BLCKSZ can be as low as 1024, I think 512 would be a good choice.
> However, if you wanted to allow multiple passwords I'm not
> sure about a good way.
The most recent proposal I'm aware of [0] did seem to target that use-case.
One option might be to move rolpassword to a different catalog. In any
case, I don't think it matters much for the patch at hand.
[0] https://postgr.es/m/CAGB%2BVh5SQQorNDEKP%2B0G%3DsmxHRhbhs%2BVkmQWD5Vh98fmn8X4dg%40mail.gmail.com
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, jkatz@postgresql.org, jacob.champion@enterprisedb.com, michael@paquier.xyz, exclusion@gmail.com
Subject: Re: Should rolpassword be toastable?
In-Reply-To: <ZwAAHHC67Dk9u2X0@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox