Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 7 Oct 2024 10:07:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: btogiwarayuushi <btogiwarayuushi@oss.nttdata.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Function for listing pg_wal/summaries directory
Message-ID: <ZwM0Pt3VGAiK2bDC@paquier.xyz>
References: <a0a3af15a9b9daa107739eb45aa9a9bc@oss.nttdata.com>
 <ZwADcxhQkE9J9ZW0@nathan>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="o+rG2NKVFjXlYFCO"
Content-Disposition: inline
In-Reply-To: <ZwADcxhQkE9J9ZW0@nathan>
Archived-At: <https://www.postgresql.org/message-id/ZwM0Pt3VGAiK2bDC%40paquier.xyz>
Precedence: bulk


--o+rG2NKVFjXlYFCO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Oct 04, 2024 at 10:02:11AM -0500, Nathan Bossart wrote:
> Could you explain why you feel the existing support functions are
> insufficient?

Because it is not possible to outsource the scan of pg_wal/summaries/
to a different role, no?

On HEAD, one would require a full access to the data folder, as
pg_ls_waldir() does not recurse.  Perhaps, rather than introducing a
new function, we should just extend pg_ls_dir_files() so as it can
optionally recurse, then use this option in the existing
pg_ls_waldir() to show stats for pg_wal/ and pg_wal/summary/?  You'd
optinally need to print the relative path of the file in the output of
the function, meaning that any summary file in should be shown as
summaries/blah.summary.  Just an idea for the bucket of ideas.

This would be unconsistent with the existing
pg_ls_archive_statusdir(), though, so using a new function may be just
better and simpler.
--
Michael

--o+rG2NKVFjXlYFCO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcDND4ACgkQnvQgOdby
QH1wKQ//aZsN3aB4BnkeH5sw3HOXIM7M4jwITaRWNXw4HULn2holFTRCQ90WoopH
En9EiVSK0nm9KAlJTMdpCGTyJHSfzum4mQ4tSU/Sbox6jb3I8OH91TSnT4KBhIwO
5qvBK17Cf5uhmhjMkh/X9o3S20uGflM6W6uZCmlwNhFQhlgR6Bxx7CE3uze2IwPd
Dr2iwOWbJJQu45o3DrzGrkQ282cKRBaoBIuOk+zOHC59FuwXyO174IiX1N08/84/
Z9+PjiWH8HIMFWt0O4xEMdBRO7EX5fLPZ8svILesqLqBAiZyx9XXoAiYQ2ADQ/Es
MB083HORWMD9nOukixzvxZGco/3S8B4yXDf1kBoV0XbqhL38db1zl9U5GhRA8enT
5eIqcbRHLEQ8Ham+Ks6C9OADb4gC4SD2QjR5k8CI6PPYbcLmGcxZeLDaahs0Hp7k
N+516pdMcv1XoGYN/cgA3UnNGAOT2q2ZyxZPwOVDxB01WttqBOy8sdBOAIylf3LP
WySttw82BwqwrcqlC659cY7uAFiTqRwLzDNz2eFhEDfq88wPlJmzx1hdY2NlTIXr
xfbvXeYIoJzoZ8YY875wpGOEWsudFYRcrQR7YFKqUNfqSYvoy8LbOcMRa1zJndRO
bikD26EOrF9fQFdSazxqiXG5GdUsVzQL051pUChiL+Yf3TGwIKw=
=B6/u
-----END PGP SIGNATURE-----

--o+rG2NKVFjXlYFCO--