Date: Mon, 7 Oct 2024 15:37:35 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>,
	Thomas Krennwallner <tk@postsubmeta.net>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_upgrade check for invalid databases
Message-ID: <ZwQ4fxGSyZoMYW_1@momjian.us>
References: <f9315bf0-e03e-4490-9f0d-5b6f7a6d9908@postsubmeta.net>
 <Zvqx2Xs4RUdByT8S@nathan>
 <1455756.1727708139@sss.pgh.pa.us>
 <CE534F60-5CDD-489B-BBD1-0A20F1B783BF@yesql.se>
 <1638096.1727734841@sss.pgh.pa.us>
 <B8B14FB1-69D1-498B-B220-22B265CDB77F@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B8B14FB1-69D1-498B-B220-22B265CDB77F@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/ZwQ4fxGSyZoMYW_1%40momjian.us>
Precedence: bulk

On Tue, Oct  1, 2024 at 09:28:54AM +0200, Daniel Gustafsson wrote:
> > On 1 Oct 2024, at 00:20, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > 
> > Daniel Gustafsson <daniel@yesql.se> writes:
> >>> On 30 Sep 2024, at 16:55, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>> TBH I'm not finding anything very much wrong with the current
> >>> behavior... this has to be a rare situation, do we need to add
> >>> debatable behavior to make it easier?
> > 
> >> One argument would be to make the checks consistent, pg_upgrade generally tries
> >> to report all the offending entries to help the user when fixing the source
> >> database.  Not sure if it's a strong enough argument for carrying code which
> >> really shouldn't see much use though.
> > 
> > OK, but the consistency argument would be to just report and fail.
> > I don't think there's a precedent in other pg_upgrade checks for
> > trying to fix problems automatically.
> 
> Correct, sorry for being unclear.  The consistency argument would be to expand
> pg_upgrade to report all invalid databases rather than just the first found;
> attempting to fix problems would be a new behavior.

Yes, historically pg_upgrade will fail if it finds anything unusual,
mostly because what it does normally is already scary enough.  If users
what pg_upgrade to do cleanups, it would be enabled by a separate flag,
or even a new command-line app.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"