Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sxyWw-00DZjW-6e
	for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Oct 2024 00:56:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sxyVv-000JJf-Oh
	for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Oct 2024 00:55:47 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1sxyVv-000JIo-Ew
	for pgsql-hackers@lists.postgresql.org; Tue, 08 Oct 2024 00:55:47 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1sxyVs-0036rr-TD; Tue, 08 Oct 2024 00:55:46 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2024011501; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
	Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
	Content-Description; bh=0pX5UzreSgy1IW9aaduG5HsZEBhxE2+xwiUoUF/lxIk=; b=AcawE
	umrWJ3Lcrlac0UN9h9nUkqVS5CLcnNUKDnRhq4I7A6ruQRsVxSWY2oqssobOYNWGBcoFmq+V3si4E
	sD9xt628BMR6riwi+C0Ae58Ke5O4uc3j2u1pGnE82EC5Ll611xflnYn1H+WMIxw5sEzhYURF1JRNL
	LYT4veL11YIPrVwuWzQA2c8QSmYZmTL+ZYLxhlSi+SuP+CcEGGK0nWzkXF89bjzN9izdOI4mX8eQF
	hSfTTic8OQYHV9/D1dorEaJZ00JgQ9ExiLVi+9Cd5CLBIKsjbK6NNUhVPmKeJyCAYDw/13hQtixkz
	SsaZ8m2Se8Da67zQ0F/Ln7AHZ23HA==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1sxyVq-007tCs-1F;
	Mon, 07 Oct 2024 20:55:42 -0400
Date: Mon, 7 Oct 2024 20:55:42 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Jonathan S. Katz" <jkatz@postgresql.org>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-ID: <ZwSDDm0bXAnHhk2F@momjian.us>
References: <ZjxLJpnH4VMkOMmi@momjian.us>
 <0749f42a-17e1-42c9-a8d4-542fcb9fafeb@postgresql.org>
 <7fd6ce37f6d14678b5024767aef7f8c5a414ba0c.camel@cybertec.at>
 <d1748552-31f5-4f80-937b-767b5f7d8324@postgresql.org>
 <Zu3UWHKwuzm-pVJo@momjian.us>
 <2536416.1726862711@sss.pgh.pa.us>
 <Zu3Y9ObRxWu8cUwm@momjian.us>
 <CAA4eK1+bChgccySmcm0LbvkmBDJ3ufsLneF4iNa_aZ7t2P6=8w@mail.gmail.com>
 <ZvirViPO4TJBmVxG@momjian.us>
 <CAA4eK1JjqNnPJLi58QdzGJ6=NQqctX+odXZvyO6oYPikU0WyDg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="AN7OaSoMfjHKDSth"
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1JjqNnPJLi58QdzGJ6=NQqctX+odXZvyO6oYPikU0WyDg@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ZwSDDm0bXAnHhk2F%40momjian.us>
Precedence: bulk


--AN7OaSoMfjHKDSth
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Sep 29, 2024 at 06:33:29PM +0530, Amit Kapila wrote:
> > > It is better to write the above statement as:
> > > "pg_upgrade</application></link> now preserves replication slots on
> > > publishers and full subscription's state on subscribers". This is
> > > because replication slots are preserved on publishers. The subscribers
> > > preserve the subscription state.
> >
> > So, as I understand it, this preservation only happens when the _old_
> > Postgres version is 17+.
> >
> 
> Yes.
> 
> >  Do we want to try and explain that in the
> > Postgres 17 release notes?
> >
> 
> It would be good if we can capture that information without bloating
> the release document. However, this information is already present in
> pg_upgrade docs, so users have a way to know the same even if we can't
> mention it in the release notes.

I have developed the attached patch to mention it is "logical" slots,
and to mention its future use.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

--AN7OaSoMfjHKDSth
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="REL_17_STABLE_pg_upgrade.diff"

diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index eb65d1d725d..1e620d810d4 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -63,7 +63,10 @@
         <para>
          <link
           linkend="pgupgrade"><application>pg_upgrade</application></link> now
-          preserves replication slots on both publishers and subscribers
+          preserves logical replication slots on publishers and full
+          subscription state on subscribers.  This will allow upgrades
+          to future major versions to continue logical replication without
+          requiring copy to resynchronize.
         </para>
        </listitem>
       </itemizedlist>

--AN7OaSoMfjHKDSth--