public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Robert Haas <[email protected]>
Cc: bucoo <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: optimize hashjoin
Date: Wed, 16 Oct 2024 13:30:49 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoY-Ksqax_BRyTpKTT9Qy-_wQ7W7gveSOLJLQkAn=RJ46w@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+TgmoY-Ksqax_BRyTpKTT9Qy-_wQ7W7gveSOLJLQkAn=RJ46w@mail.gmail.com>

On Fri, Aug 23, 2024 at 08:17:26AM -0400, Robert Haas wrote:
> On Fri, Aug 23, 2024 at 7:02 AM bucoo <[email protected]> wrote:
> > Howerver, the non-parallel hashjoin indeed showed about a 10% performance improvement.
> >    ->  Hash Join  (cost=508496.00..2302429.31 rows=47989008 width=0) (actual time=1075.213..9503.727 rows=47989007 loops=1)
> >    ->  Hash Join  (cost=508496.00..2302429.31 rows=47989008 width=0) (actual time=1087.588..8726.441 rows=47989007 loops=1)
> 
> It's not a good idea to test performance with EXPLAIN ANALYZE,
> generally speaking. And you usually need to test a few times and
> average or something, rather than just a single test. But also, this
> doesn't show the hash join being 10% faster. It shows the hash join
> being essentially the same speed (1075ms unpatched, 1087ms patched),
> and the aggregate node on top of it being faster.
> 
> Now, it does seem possible to me that changing one node could cause a
> performance improvement for the node above it, but I don't quite see
> why that would happen in this case.

Where are we on this patch?

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: optimize hashjoin
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox