Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1syjVN-001oju-7C
	for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Oct 2024 03:06:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1syjVL-009pAJ-8D
	for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Oct 2024 03:06:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1syjVK-009pA8-UF
	for pgsql-hackers@lists.postgresql.org; Thu, 10 Oct 2024 03:06:19 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <bruce@momjian.us>)
	id 1syjVD-000G3D-TE; Thu, 10 Oct 2024 03:06:18 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=momjian.us;
	s=2024011501; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:
	MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-ID:Content-Description;
	bh=peNSgAsSNPJ4t9cQcHu285KWy9dN/kpOdvT52iEVwDQ=; b=TAnQSjxSgMBNRN69P8lazmpF36
	64ncq8T592bqT5dnGZaH0aeJ4bKc/wtnB3GdWTA8btXnJtzbELrdAz4CSiANL1gll9198kO+ZGtF1
	a12OqsHjqZW7boInSPjTZX2MW/of03nq45tkBR+75JqfNG2r43iG/dle1h9jLbiX0xkvSfJeIvFnS
	6TjEs5EH8qHP9k02/seTQrE7AyjFsndXB9ymKTEdu8dG4jVxwo6r2cv7BgWS6OVr49FYp0WP0qkFJ
	e3hCssoANV3QrLktQX+TukeGVsai3gEDwrSdQhBT8Lhw2qs+d3hmN+18aZulKr8+rCsQHMv/NCHX7
	yKDw9Tlw==;
Received: from bruce by momjian.us with local (Exim 4.96)
	(envelope-from <bruce@momjian.us>)
	id 1syjVB-00Eolr-28;
	Wed, 09 Oct 2024 23:06:09 -0400
Date: Wed, 9 Oct 2024 23:06:09 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "Jonathan S. Katz" <jkatz@postgresql.org>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-ID: <ZwdEoR2P5C6CJGoA@momjian.us>
References: <7fd6ce37f6d14678b5024767aef7f8c5a414ba0c.camel@cybertec.at>
 <d1748552-31f5-4f80-937b-767b5f7d8324@postgresql.org>
 <Zu3UWHKwuzm-pVJo@momjian.us>
 <2536416.1726862711@sss.pgh.pa.us>
 <Zu3Y9ObRxWu8cUwm@momjian.us>
 <CAA4eK1+bChgccySmcm0LbvkmBDJ3ufsLneF4iNa_aZ7t2P6=8w@mail.gmail.com>
 <ZvirViPO4TJBmVxG@momjian.us>
 <CAA4eK1JjqNnPJLi58QdzGJ6=NQqctX+odXZvyO6oYPikU0WyDg@mail.gmail.com>
 <ZwSDDm0bXAnHhk2F@momjian.us>
 <CAA4eK1JQ5jHLj+5yfWWnTfSUiB-=X0LWH8HB51yO4gG86AjVfQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAA4eK1JQ5jHLj+5yfWWnTfSUiB-=X0LWH8HB51yO4gG86AjVfQ@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ZwdEoR2P5C6CJGoA%40momjian.us>
Precedence: bulk

On Tue, Oct  8, 2024 at 11:57:19AM +0530, Amit Kapila wrote:
> On Tue, Oct 8, 2024 at 6:25 AM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Sun, Sep 29, 2024 at 06:33:29PM +0530, Amit Kapila wrote:
> > > > > It is better to write the above statement as:
> > > > > "pg_upgrade</application></link> now preserves replication slots on
> > > > > publishers and full subscription's state on subscribers". This is
> > > > > because replication slots are preserved on publishers. The subscribers
> > > > > preserve the subscription state.
> > > >
> > > > So, as I understand it, this preservation only happens when the _old_
> > > > Postgres version is 17+.
> > > >
> > >
> > > Yes.
> > >
> > > >  Do we want to try and explain that in the
> > > > Postgres 17 release notes?
> > > >
> > >
> > > It would be good if we can capture that information without bloating
> > > the release document. However, this information is already present in
> > > pg_upgrade docs, so users have a way to know the same even if we can't
> > > mention it in the release notes.
> >
> > I have developed the attached patch to mention it is "logical" slots,
> > and to mention its future use.
> >
> 
> LGTM. Thanks!

Great, patch applied.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"