Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 23 Oct 2024 15:22:44 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Refactor to use common function 'get_publications_str'.
Message-ID: <ZxiWNJsp5xAd5UrD@paquier.xyz>
References: <CAHut+PtJMk4bKXqtpvqVy9ckknCgK9P6=FeG8zHF=6+Em_Snpw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TAdTv9wUL80Ze3o7"
Content-Disposition: inline
In-Reply-To: <CAHut+PtJMk4bKXqtpvqVy9ckknCgK9P6=FeG8zHF=6+Em_Snpw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZxiWNJsp5xAd5UrD%40paquier.xyz>
Precedence: bulk


--TAdTv9wUL80Ze3o7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 23, 2024 at 03:44:03PM +1100, Peter Smith wrote:
> During a code review, it was noticed that there are several places
> within logical replication where a comma-separated list of publication
> names is built explicitly. There is already a utility function (called
> 'get_publications_str') for doing this, but it was not being used in
> every place it could have been.

Agreed that this is a good idea, saving from some duplication in the
tablesync code where the same thing is done, with the quoting on top
of that.

-   pfree(cmd.data);
+   pfree(pub_names->data);

The pfree for cmd.data should still be here, no?  And you would need a
pfree(pub_names) as well, meaning that this could just use
destroyStringInfo().
--
Michael

--TAdTv9wUL80Ze3o7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcYljQACgkQnvQgOdby
QH1hkQ//XucWh6ynmJzx4n48FMSvltyc/mnMZgURCEFOhscjMgW4bqKjrh6jKmPx
/A8MzjtQsl+kB4G2Fp0DPxMGtO5D6pNoMdJw+/nmp3EExn7uis+8hr/Jpuc4jLtS
gfn5S5OrDUuUTi1nmm4hIGIooufA3eqGhXRkMMbFBxcaMdKrlnMBNd9BEV2hojKz
19mQ9TSGsNGI/LnFJFvdMounVGG2aAeT7IEn/Pi+GnwSk/d3f2NWtyrLHJV7AWKC
zsac90kWZAbgemIinFSVShcYjTyR/3S1XLBw+M+t9H71RGyJFyB99A5gkqgIeebS
36WEfW5n3176im4fzdn2T+awDTKGfVCM6AdIxbv6XP7+9KtiDWXPu6iEc3y1x1VB
nbx1ddw2GlZsgJL+ONbNkQi6m8R5zz/BKUMOswjAUwxtGUroPOq7vKVM+oaF55NP
uUV34KtH8Yy/FK04I9QXA4Pc7So1TakUhEqDXGTR1UrV/Znf2gCLUvhzoI8PCj/u
dSzJEI5MMWjzIB8ox4ta6F0GyVQHGVlRTuL7vhexUcZWlpctj9AaiQcnjeLNMZdE
09CEW4S3OLWc27BtmmHbI6wHfpTyeUiDByuqCezdZYCxKghFMIhRPSMEv0snEio4
sbgv3lkfXulyGEZAYO9Mwqiug+3uYTumO4skap48x8jDWYKIuOY=
=fJcW
-----END PGP SIGNATURE-----

--TAdTv9wUL80Ze3o7--