Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t3pIT-00EsNm-Me for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Oct 2024 04:18:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t3pIQ-00Geqj-KB for pgsql-hackers@arkaria.postgresql.org; Thu, 24 Oct 2024 04:18:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t3pIP-00Geqb-5p for pgsql-hackers@lists.postgresql.org; Thu, 24 Oct 2024 04:18:02 +0000 Received: from fout-b7-smtp.messagingengine.com ([202.12.124.150]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t3pIM-002feO-2P for pgsql-hackers@lists.postgresql.org; Thu, 24 Oct 2024 04:18:00 +0000 Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id 5352D1140104; Thu, 24 Oct 2024 00:17:55 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 24 Oct 2024 00:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1729743475; x=1729829875; bh=T491vcLjOy PigoAgoHt/SZOdimT8W0FMnG/S4fO5Gh8=; b=DfumAhui+m/h+gWbaOW4r1i+yl KR8Kxumk64RRyQMgmX+jHgnd8IAOPVg4AjVZiHuLlJiSpaP2iDkMOfoMerLtnqOz V4X/xCjVRmpE8gJjpAeMKsqi1gGl6kObotzRdIDvaAIfP3Zjf6KopDYaLN6SH4oL oOCIQjGH7/L49zCtG7gDCtQ1PIuRfYLjKcaoRaPskSBcCfhcfsc+J7TON/9giDbW 6RBLt6QiYNF+eUmKFSRMdJ9bP5s4qYMPGw/Os6nLOP9uTSGEpIB3sbokThmrR6VE hnGpdleDrXOxWBgvtDcXr7V0y6Lec5GbdGguY6wAcGSbgqGddhCBspjuphBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1729743475; x=1729829875; bh=T491vcLjOyPigoAgoHt/SZOdimT8 W0FMnG/S4fO5Gh8=; b=Od0vWaI5sbS4sUqY9JDk0blM2JVHz0+qQHv5sd9qeUVp cl+Wi9Vj2d4GhxZsbNczltH9NuqhqHS366ghxFfHBcA8bZKIR+bbLd3hYvuB+QXv ipu0qoPQ7d7LVyv80OUkKBBZBvyxF4YB6sB34qnrvKy1APb8uHwCxpZT6bcU4I/m NRSO1mnoy6OD+6gejH5+uiUJcaYWp5DKY4E77coFRFhBixCfFw0MvvsQTzLSbElG hyjDX2zDtHRTr0y1t5OnHWh3KLnuZgtTJoYzB3iP5pexZ2a2yqjiUb0qRlFPv7JQ 7OwBpCqNNBMej67zvzKwJZGDYlbfzswbmyHlttMCQQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeikedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvvefukfhf gggtuggjsehgtderredttddvnecuhfhrohhmpefoihgthhgrvghlucfrrghquhhivghruc eomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqnecuggftrfgrthhtvghrnhepteel ieefudffhffhtdetleeggeegfffhkeeuveetiefgudduvedutefggeeivdejnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhitghhrggvlhes phgrqhhuihgvrhdrgiihiidpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepshgrfigruggrrdhmshhhkhesghhmrghilhdrtghomhdprhgtphht thhopehsmhhithhhphgsvddvhedtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgsh hqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Oct 2024 00:17:53 -0400 (EDT) Date: Thu, 24 Oct 2024 13:17:39 +0900 From: Michael Paquier To: Masahiko Sawada Cc: Peter Smith , PostgreSQL Hackers Subject: Re: Refactor to use common function 'get_publications_str'. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3ut371eFrjEFgZtx" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3ut371eFrjEFgZtx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 23, 2024 at 03:40:19PM -0700, Masahiko Sawada wrote: > > Now, I've changed the function comment to: > > /* > > * Add a comma-separated list of publication names to the 'dest' string. > > */ >=20 > Thank you for updating the patch. The patch looks good to me. + /* Build the pub_names comma-separated string. */ + GetPublicationsStr(MySubscription->publications, pub_names, true); In fetch_remote_table_info(), it is true that we may finish by building the same list two times, but your patch also changes the logic so as the string is built for nothing when dealing with a server version of 14 or older. That's a waste in these cases. -- Michael --3ut371eFrjEFgZtx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcZymMACgkQnvQgOdby QH3PeA//V6QkCMJqxEOgLbtAWpBi49bxPQvU5Suj46+Gw9XpmJ3kKVNRNEcWfWr3 R7rztdEUcHLucXLGNMYARAmVkJn0IAgdjrmfPKr9cBju5YpEArZsYuKCYaxlM+in W1pfzPu743427OeCgKGZTidRefonCln8whLMic8L0oWz0mLYGzaA5phHL10YLy11 7i/fWukvwQv5AMC02n4gRwF7TyHuMOEohu7vLkhoqzBoG0tUCptCADYFFIeeQNGh w4+yy6+xWpeVjviCv2Xvg8GNnAoCrr6XDiaL+oDBroQcgguY6095TLGw4F/nMdBA zsQv0VHDioR+T/W22xLEepBIIzAg8zdEWxQ1Zihj8vmz+8b0h8lJfg3SxGR1FkWK B5fP7W6vLz5aR38y37MfIbxIcTjLc492h2D+qHw4zFR4BlXC8F0tphTJUUbZo/1e 6QXzFnAoCawDj+wpTm1VnCJ1u+F2gm97QKCyORO2c8NVuyFhBFg0aAHI+5gB2ZUD GDe2+7dZOqB1Fkb7kYMVVU3sGzYYyVKKUBdz8z5EfVICC+8gVPjanVctabEDF6EQ FVBaIG2ENU53NT9m0a+xg1QQRMJ4/LEMeyy2smRQUFSihTdO2keebLFdhC6CpJyJ 2cjeQig0CJk048JVuhV6K3wU4tX61v/ESdOwZlci0IAIkGoHqAA= =iQ5g -----END PGP SIGNATURE----- --3ut371eFrjEFgZtx--