Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 24 Oct 2024 14:51:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Missing installation of Kerberos.pm and AdjustUpgrade.pm
Message-ID: <ZxngSWiXVSpJerGW@paquier.xyz>
References: <ZozqzznkDhfCG7Ng@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="tsRpkmuGhh6GMHaG"
Content-Disposition: inline
In-Reply-To: <ZozqzznkDhfCG7Ng@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/ZxngSWiXVSpJerGW%40paquier.xyz>
Precedence: bulk


--tsRpkmuGhh6GMHaG
Content-Type: multipart/mixed; boundary="i9pkm9bfTqoU8lBa"
Content-Disposition: inline


--i9pkm9bfTqoU8lBa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 09, 2024 at 04:46:23PM +0900, Michael Paquier wrote:
> I cannot say much in favor of Kerberos.pm, but AdjustUpgrade.pm could
> be really useful IMO when running the main regression test suite in an
> out-of-core module for upgrade scenarios.  Not to mention that it
> includes a set of filtering regexes that are rather generic.

While catching up with some other thing, I've been reminded that this
has not been addressed.  Any objections if I were to apply the
attached to add install and uninstall rules for Kerberos.pm and
AdjustUpgrade.pm?

If people would prefer a backpatch, please let me know.
--
Michael

--i9pkm9bfTqoU8lBa
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
	filename="0001-Add-rules-for-Kerberos.pm-and-AdjustUpgrade.pm.patch"
Content-Transfer-Encoding: quoted-printable

=46rom a2465b3dcb3eb22fa5f6d55a6823accd85e8683a Mon Sep 17 00:00:00 2001
=46rom: Michael Paquier <michael@paquier.xyz>
Date: Thu, 24 Oct 2024 14:41:39 +0900
Subject: [PATCH] Add rules for Kerberos.pm and AdjustUpgrade.pm

---
 src/test/perl/Makefile    | 4 ++++
 src/test/perl/meson.build | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/test/perl/Makefile b/src/test/perl/Makefile
index 82ea63b08e..c02f18454e 100644
--- a/src/test/perl/Makefile
+++ b/src/test/perl/Makefile
@@ -22,16 +22,20 @@ install: all installdirs
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Utils.pm '$(DESTDIR)$(pgxsdir)/=
$(subdir)/PostgreSQL/Test/Utils.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/SimpleTee.pm '$(DESTDIR)$(pgxsd=
ir)/$(subdir)/PostgreSQL/Test/SimpleTee.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/RecursiveCopy.pm '$(DESTDIR)$(p=
gxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'
+	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Kerberos.pm '$(DESTDIR)$(pgxsdi=
r)/$(subdir)/PostgreSQL/Test/Kerberos.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/Cluster.pm '$(DESTDIR)$(pgxsdir=
)/$(subdir)/PostgreSQL/Test/Cluster.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(=
pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'
+	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/AdjustUpgrade.pm '$(DESTDIR)$(p=
gxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'
 	$(INSTALL_DATA) $(srcdir)/PostgreSQL/Version.pm '$(DESTDIR)$(pgxsdir)/$(s=
ubdir)/PostgreSQL/Version.pm'
=20
 uninstall:
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Utils.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/SimpleTee.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/RecursiveCopy.pm'
+	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Kerberos.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/Cluster.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/BackgroundPsql.pm'
+	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'
 	rm -f '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Version.pm'
=20
 endif
diff --git a/src/test/perl/meson.build b/src/test/perl/meson.build
index 4f0d928a6f..fc9cf971ea 100644
--- a/src/test/perl/meson.build
+++ b/src/test/perl/meson.build
@@ -10,6 +10,8 @@ install_data(
   'PostgreSQL/Test/Utils.pm',
   'PostgreSQL/Test/SimpleTee.pm',
   'PostgreSQL/Test/RecursiveCopy.pm',
+  'PostgreSQL/Test/Kerberos.pm',
   'PostgreSQL/Test/Cluster.pm',
   'PostgreSQL/Test/BackgroundPsql.pm',
+  'PostgreSQL/Test/AdjustUpgrade.pm',
   install_dir: dir_pgxs / 'src/test/perl/PostgreSQL/Test')
--=20
2.45.2


--i9pkm9bfTqoU8lBa--

--tsRpkmuGhh6GMHaG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcZ4EkACgkQnvQgOdby
QH04pQ/7BAp0YJNHznP7PyEAghRu7T8+HPVEFcjCe/Y0i17l7kE22a+cU/xhJ8IK
bXxLXj5r7uFe1Gu9Lz7PkSAU00AmROwBgtWqwJtJnACCM8o2EdZMHwEDYbC9Zzpz
qQh7Q0VIZefKO0MkYbO8SS8WgJ3PbcL0xcKlFsKY0vJBgqNIr/RnMraPzEPp2B0Y
ZxmbSBb9hMr9wNzR4GfmN63EO/PNcPl7hoS3mLga7VtE2r/EkPw6IMj/E53jaYce
RBJHb569pCDx4ngHkCfvZ+HxEWrQvxQrBJ2iU/YHTh4cvlAz6EHpgQU5Mijkulag
I7v2QSaYkftlJqJjYtGkcL2paFcMYOeIYxpf9ghexJkO86grb/zAllaacVn04dyl
P4WdYSpCtF/osXtYCS93kEThtMKfl88zTHKtxZdQqT886K2JqsmC7S5xtDanOveY
SjHOn3YTT6mSuESZThwCWDt9qN4nwPqD8GgrCTHz/rMnQKJUSxZuh15tZD8KMs8v
BSwlZrjxVjR/67/tdiXaHGM9aFwyZqVVyuRjkZvTPNcZxJB3eRfIArTeluKRJiCv
QeKxUN3bn7EDVmGgP3v6D9KiQeCOEArbn/uRj74I6I+qldckV2bzj5n7HtxeiWPY
16AhcEzdZoZxOFnSOdjGXeqTi2+F9vrN2/w3FO3PLcVhtO3RRfE=
=Uz8Z
-----END PGP SIGNATURE-----

--tsRpkmuGhh6GMHaG--