Date: Fri, 8 Nov 2024 14:00:36 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Wolfgang Walther <walther@technowledgy.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix port/pg_iovec.h building extensions on x86_64-darwin
Message-ID: <Zy5t5FAmNKsJGf44@nathan>
References: <16989737-1aa8-48fd-8dfe-b7ada06509ab@technowledgy.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16989737-1aa8-48fd-8dfe-b7ada06509ab@technowledgy.de>
Archived-At: <https://www.postgresql.org/message-id/Zy5t5FAmNKsJGf44%40nathan>
Precedence: bulk

On Fri, Nov 08, 2024 at 08:08:06PM +0100, Wolfgang Walther wrote:
> @@ -68,7 +68,7 @@ pg_preadv(int fd, const struct iovec *iov, int iovcnt, off_t offset)
>  		}
>  		sum += part;
>  		offset += part;
> -		if (part < iov[i].iov_len)
> +		if ((size_t) part < iov[i].iov_len)
>  			return sum;
>  	}
>  	return sum;
> @@ -107,7 +107,7 @@ pg_pwritev(int fd, const struct iovec *iov, int iovcnt, off_t offset)
>  		}
>  		sum += part;
>  		offset += part;
> -		if (part < iov[i].iov_len)
> +		if ((size_t) part < iov[i].iov_len)
>  			return sum;
>  	}
>  	return sum;

This looks correct to me.  At this point in the code, we know that part >=
0, so casting it to an unsigned long ought to be okay.

-- 
nathan