Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6FxJ-00Bj9G-Mn for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Oct 2024 21:10:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t6FxI-00CYFJ-1m for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Oct 2024 21:10:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6FxH-00CYE7-OZ for pgsql-hackers@lists.postgresql.org; Wed, 30 Oct 2024 21:10:16 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1t6FxF-003gE7-ET for pgsql-hackers@lists.postgresql.org; Wed, 30 Oct 2024 21:10:14 +0000 Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-3a3a5cd2a3bso1006845ab.3 for ; Wed, 30 Oct 2024 14:10:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730322613; x=1730927413; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o8KcrvxD87pwPtkHMrgwab+uLIGfG+ZmaxfxA1LN/eo=; b=iGGo1fcjSVoisw+bc+WvXTdsUdIDGiXXzI8haYM7Nh9eoGg6VUoblsMUTRUczLiAav N8MDFF7qTEAInNBCh/f4HnL3/KtVTGtJ/VBnlZwnM+1n1HbXSfOZDNSXUUOa1lPFV1je Dk4khIA8SNgFWIrtRzNiMZqAwjxjE+xkU5AgC6mGF1h3MMXL2OY913luFwfP2gmN2RGu 9wp/uG8tz57d92DctpqYc5m3Z6XDI8VAK4ZwOQBTnKoE1Xs9FWc6TUgNys76TGxsRc1Y OlVVPvib09gRa/S2C2pcCsROLY4Y4XRe5GrsF6UitKJE1SirlUPLNfVvznd+J3fambbI SZaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730322613; x=1730927413; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o8KcrvxD87pwPtkHMrgwab+uLIGfG+ZmaxfxA1LN/eo=; b=fVA1nZXEy0xBK2NfvvHao+5mO7uFfK4WmGwqL+kLDGnZWPsKpuXFS765VT4BSUoXbf ilSYEP/DvHmlLj9LFHBowQWY/Gs6MErRmkn2ALv0X+H826Uc7mvpuQCYGp/FaIP7N7HB xYQzb8VMhItzyXB39/kmrnOSRQmQoCm7VlRUVnQ21gfXRzrTavjytCXRPeSXy5MxrLq2 wg9TRlsORD6zphcQt1XIRCJCcldmgz4nHZ5QKMD/YYUzI8+nZeAt4+yoIHuxto7+YaOo BxTlxY9Q8RWU4KC6be601uN7oFQRlAFztL1aQf3jWXvNu4FlFG49Pc1LZt46l3Ie8aO3 WuQw== X-Gm-Message-State: AOJu0Yy73yfkzMhTj7WCwFrJkK3M0GEg6saWQfOtGegZeYUFIlq4m7W9 Boy8eEAXhuJpShExxZTMdBxKKzaEIstpswFmb2gqe4uzuQ2gTh5E X-Google-Smtp-Source: AGHT+IFJDLFwYNNf9hD+jozee0HgL/lYT6Ia+9sT7SVhEoK/9GFXkcD2+BuxkQvbiYMx3YSddEa4ow== X-Received: by 2002:a05:6e02:2183:b0:3a3:4391:24e9 with SMTP id e9e14a558f8ab-3a4ed2dfafdmr181217165ab.20.1730322612577; Wed, 30 Oct 2024 14:10:12 -0700 (PDT) Received: from nathan (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a4e6e56cfdsm30260355ab.66.2024.10.30.14.10.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 14:10:11 -0700 (PDT) Date: Wed, 30 Oct 2024 16:10:10 -0500 From: Nathan Bossart To: Raghuveer Devulapalli Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Popcount optimization using AVX512 Message-ID: References: <173022983862.1162.9439822012408182864.pgcf@coridan.postgresql.org> <173032159044.1162.17669652767784249811.pgcf@coridan.postgresql.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173032159044.1162.17669652767784249811.pgcf@coridan.postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Oct 30, 2024 at 08:53:10PM +0000, Raghuveer Devulapalli wrote: > BTW, I just realized function attributes for xsave and avx512 don't work > on MSVC (see > https://developercommunity.visualstudio.com/t/support-function-target-attribute-and-mutiversioning/10130630). > Not sure if you care about it. Its an easy fix (see > https://gcc.godbolt.org/z/Pebdj3vMx). Oh, good catch. IIUC we only need to check for #ifndef _MSC_VER in the configure programs for meson. pg_attribute_target will be empty on MSVC, and I believe we only support meson builds there. -- nathan