Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 31 Oct 2024 09:59:35 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: define pg_structiszero(addr, s, r)
Message-ID: <ZyLWd2jR8FO7j5UL@paquier.xyz>
References: <ZupUDDyf1hHI4ibn@ip-10-97-1-34.eu-west-3.compute.internal>
 <3023d29e-0fe7-4bec-9028-7f3c0102e437@eisentraut.org>
 <ZusioyiXTyKpOP/2@ip-10-97-1-34.eu-west-3.compute.internal>
 <f73f4287-aadd-4914-8052-76167fb4934c@iki.fi>
 <ZyCUsIu/xKFz0djS@ip-10-97-1-34.eu-west-3.compute.internal>
 <c9ade148-ff76-45c5-9760-1a45fbd42b00@eisentraut.org>
 <ZyDp946kZZ7OhaL5@ip-10-97-1-34.eu-west-3.compute.internal>
 <36371fab-f90c-427c-9c14-210e93e9cd12@eisentraut.org>
 <ZyH7HZfDh7DYNvKv@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAHut+Pu9Un427eoPuEetNhk2PZe1-sgSxEuG_2OuTwtxC3cBOw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="auMJ8MGb8xmoDF+U"
Content-Disposition: inline
In-Reply-To: <CAHut+Pu9Un427eoPuEetNhk2PZe1-sgSxEuG_2OuTwtxC3cBOw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZyLWd2jR8FO7j5UL%40paquier.xyz>
Precedence: bulk


--auMJ8MGb8xmoDF+U
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 31, 2024 at 07:55:45AM +1100, Peter Smith wrote:
> +/*
> + * Test if a memory region starting at p and of size len is full of zero=
es.
> + */
> +static inline bool
> +pg_mem_is_all_zeros(const void *ptr, size_t len)
>=20
> The function comment should say 'ptr' instead of 'p', right?

Yes.

+static inline bool
+pg_mem_is_all_zeros(const void *ptr, size_t len)

While we're talking about wordsmithing things, I would not choose
"mem" for this routine, just stick to "memory".  There is not much in
the code that does memory-specific things like what you are proposing
here.  Still, this would be more consistent with the macros for memory=20
barriers at least.  Hence, "pg_memory_is_all_zeros()" makes more
sense?

The location of memutils.h is sensible.

+   if (pg_mem_is_all_zeros(pagebytes , (BLCKSZ / sizeof(size_t))))

Extra space not required after pagebytes.
--
Michael

--auMJ8MGb8xmoDF+U
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmci1ncACgkQnvQgOdby
QH0WCg//errYUDAslcUOOIshCqrZgCBpgac07mSXW6UoT7cUOntxdjuo08zSavy7
v4TK0Ppb6ouS+3bPaH0gWvNiGEW3mEDZ/VSumgUa03PUR0D/tueUuPzWH2WDS6zU
zDEERtq2+DXTGPfJER+TPMzEFg4kr8X7iIwXOVZossU5eQvTFfjSSDUZ2/kB9T4Q
c9HhKbctEyb4cHH+0NXWdzwlCEkK0xC4gi7r7gA5G+AnN09kjs7HfxBJD3TTF4zj
cxClqAaSrw9YdAiPVr/pdLso2NQGo/vQ0L2pmRl8jDifvhfCF/KG041WAGGB5wK0
VNhowAY7VZt+U2THOinb9hNpdnxLbQu04N+Dl6gdGwgp4uxjJE/0mT/e4VqWSf98
di3Jc9ErHSf+Ob2DxZbYb41qpL5LSx0qeW3rK3TdfBUJQTSKiOVXW03vQFc+SOfS
+WQ2YYUs8tE1O8keEx5JzqxDSqMzYOJwGolIJex0a/MIwN3lp+vCYorv/9ghNdc0
PjN48hmdCUOA6C1fhimPeKCHK6sVrWMb5v/R5lHJ27kqqsJ1opDsicWazVtbhti9
5PdtJZBf1RzfCdA3h08Ww+B1fTdz5WcUxNUEht5T4GxFbUrjxwZrHFfw609nt4Na
j7Bs7G4pINNnqETNJdugP5NAht/fJSyElhTIapNman22QuqXJcI=
=+IkL
-----END PGP SIGNATURE-----

--auMJ8MGb8xmoDF+U--