Date: Thu, 31 Oct 2024 21:10:01 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove useless casts to (void *)
Message-ID: <ZyQqaQGNtbxI6SrT@momjian.us>
References: <461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org>
 <166213.1730211603@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166213.1730211603@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/ZyQqaQGNtbxI6SrT%40momjian.us>
Precedence: bulk

On Tue, Oct 29, 2024 at 10:20:03AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
> > There are a bunch of (void *) casts in the code that don't make sense to 
> > me.  I think some of these were once necessary because char * was used 
> > in place of void * for some function arguments.  And some of these were 
> > probably just copied around without further thought.  I went through and 
> > cleaned up most of these.  I didn't find any redeeming value in these. 
> > They are just liable to hide actual problems such as incompatible types. 
> >   But maybe there are other opinions.
> 
> I don't recall details, but I'm fairly sure some of these prevented
> compiler warnings on some (old?) compilers.  Hard to be sure if said
> compilers are all gone.
> 
> Looking at the sheer size of the patch, I'm kind of -0.1, just
> because I'm afraid it's going to create back-patching gotchas.
> I don't really find that it's improving readability, though
> clearly that's a matter of opinion.

I kind of liked the patch in terms of simplifying things.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"