Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6mPh-00FTjB-TC for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Nov 2024 07:49:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t6mPf-00B0P0-Ca for pgsql-hackers@arkaria.postgresql.org; Fri, 01 Nov 2024 07:49:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6mPf-00B0Or-2t for pgsql-hackers@lists.postgresql.org; Fri, 01 Nov 2024 07:49:43 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t6mPc-003vR9-Fe for pgsql-hackers@lists.postgresql.org; Fri, 01 Nov 2024 07:49:42 +0000 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 16D9A1140151; Fri, 1 Nov 2024 03:49:39 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 01 Nov 2024 03:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1730447379; x=1730533779; bh=L28scoGNeY KPISJKFC8YO58WhIzE99JK79ALAOj8Z6w=; b=Is8GOACkFIbjs2s0D7ZXVTKS26 rLtdp3CMYC3n1KKtacZP6C540yhUb/y5u7PYaO6i4XohziaIj1bjDtM34fESOKZx 0hDG1lRMSRM1YcjN3k+Ptde5AjLxxt7TqBn5mxDFiYo4uUnv/JV/wRACyx5pcBk4 zYpjtUIEWt5eBbJRxrUC/Ik9Cqnmf+j4lpitvi9IYmaQ9wVnWeSPPM5cv90JTx02 hScSuxw7OdWJ9dPfc2MwI1low8QWtVe2friqBBmETaRVy+nJx7JhvcWKwfOWJ7nx 17f2P0PO83dXbObr3CpGGvEavnfmqKHoB1qaVX0/kKrDkM/rgSETZgqv+MkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730447379; x=1730533779; bh=L28scoGNeYKPISJKFC8YO58WhIzE99JK79A LAOj8Z6w=; b=He3CpKpkM9gS6Jwf2GqzCQK0GtQGY+ux16XFDb4Oj8eVOSd72pW rIb9vfe4VEmkmgpBN9V8sjU9ziZoSK0/2xZ9F5AUsUSCedCvXYV0kjCE+W5KOgxl RKQXjk58TiduxN0XQOaRaTgH8jRZduJfsLgzW1dzhsZXyxfDTJG+9YwLqLrlHzWg ASlO7U+6eIKvMsDvHci5YpL3rVFoVHjrc8xqSv3Krj6dMjdUJjMyLz8fRPrtvVEm j0IHnAzb+hDeZ5ZN2nW69vd31UKBkQXzw4r7m+7PVF1LlSk71S4EEnB+J18S9/Ft M0JgC8dByZLScwgrAVVioD8Yt5lG/lLavgQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdekkedguddtlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenfghrlhcuvffnffculdejtddmnecujfgurhepfffhvfevuffk fhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrh cuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqeenucggtffrrghtthgvrhhnpeet leeifedufffhhfdtteelgeeggeffhfekueevteeigfduudevudetgfegiedvjeenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghl sehprghquhhivghrrdighiiipdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegsvghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdr tghomhdprhgtphhtthhopegughhrohiflhgvhihmlhesghhmrghilhdrtghomhdprhgtph htthhopehsmhhithhhphgsvddvhedtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphgv thgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhrtghpthhtohephhhlihhnnhgrkhgrse hikhhirdhfihdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhp ohhsthhgrhgvshhqlhdrohhrgh X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Nov 2024 03:49:37 -0400 (EDT) Date: Fri, 1 Nov 2024 16:49:21 +0900 From: Michael Paquier To: Bertrand Drouvot Cc: David Rowley , Peter Smith , Peter Eisentraut , Heikki Linnakangas , pgsql-hackers@lists.postgresql.org Subject: Re: define pg_structiszero(addr, s, r) Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3tsll7lRkp+WZIAD" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --3tsll7lRkp+WZIAD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 01, 2024 at 07:44:22AM +0000, Bertrand Drouvot wrote: > Thanks! Cool, will fix that in a bit. > Worth to add a comment as to why pg_memory_is_all_zeros() should not > be used here? I would not add one in bufpage.c, documenting that where pg_memory_is_all_zeros() is defined may be more adapted. -- Michael --3tsll7lRkp+WZIAD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmckiAEACgkQnvQgOdby QH1c4A/8Co5m4RILVBwo0WxN0QSkl+1L6lLstI5I0BBUQ4Sq+HU5xFG6acKqXPx9 HZGMjQajwjxV0Yj/zeu8IyCeepIH0Dusg2v0H/cB0vSM4SPvGsOq3o2lUrZC5osw Ovot27WRT0YHhOeIm50KgD6f2viKT6kR74G6+29ZYAB3UKKVWgTyi5qRGE7tb+r+ VV+hnRa6yJUHXDcOscrEfU4BW7KQzfKU1wmq6fkIJCADiiJP7z1+1JCeYoDxo7o0 85ojLiCrXbj/1F6/MwAhD2e7+tJ166rg8FLP8i2Z+we3yS6C3k707rndQpXekB1f e4kO4RRjuOHbBKVxPG1uYGZK1SGBlxDA3qGbT0IzSEmqBbQBwg1LiJh2F1OwiNqV /caXNGa9Tc9hSXb76pmq31/Mr77swidJhPRi3g4kA5dyoeu2DIjoU6jdi9Hkaeyn SXrmmdPgcUjehXCO0HzDRO3slvU+ZNDKA8rrxhM7ONhsCZFG0ZQQKBy/pdfrpbOA +AqGUw31lFbOPbTBQKdNpvH/G3QAgfPlCKXx9Zn5u+VLNHgJxy0a0BEG3m1Gdk8D QVbHiiYI88hMuz68mMEH+OF/1QnqxvhBj3FbltbyOdBp9SvSY/nh7dRvZtRi4Z/e 36snr6LGxG/tIYtjTFXM3O9QQHpbRRURSKf55U80Zb6ovR2HhS8= =zj7a -----END PGP SIGNATURE----- --3tsll7lRkp+WZIAD--