Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 4 Nov 2024 18:49:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Clear padding in PgStat_HashKey keys
Message-ID: <ZyiYkPNcC02RJr8d@paquier.xyz>
References: <Zyb7RW1y9dVfO0UH@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zyh2zD1fUJJggsCo@paquier.xyz>
 <ZyiLNDeO9zm2LUW6@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+zZiukOeZLi/h++j"
Content-Disposition: inline
In-Reply-To: <ZyiLNDeO9zm2LUW6@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/ZyiYkPNcC02RJr8d%40paquier.xyz>
Precedence: bulk


--+zZiukOeZLi/h++j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 04, 2024 at 08:52:04AM +0000, Bertrand Drouvot wrote:
> Yeah, but not only the relfilenode ones. All kinds were affected as random data
> was in the padding bytes for all of them.

A quick test where I add some padding junk in PgStat_HashKey proves
that you are right.  I'm wondering if we should backpatch that,
actually, down to where it has been introduced.  We are unlikely going
to change this structure, but if we do for the sake of a bug fix,
which is always a possibility as ABI does not matter much for this
internal structure, that's potentially trouble waiting ahead.
Thoughts?
--
Michael

--+zZiukOeZLi/h++j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcomJAACgkQnvQgOdby
QH0EZw/+J8kwf3Cc/GB2pGJtjaPI6x3r15oI0z/rj5Q543kk1x9nCwChqIPrrIeT
B1FDu2/Q/esaRuOPBXqQ4STowbAYKleEhPJUU8rfbsLktgmbKC1TemJcGLpLgDNN
hq/yI4dEVrKHxQqlnmadT45121W9mmr53qM+790I9XrQOroYFhjn+f3ZgAkbDvP4
F9UZPlQo9HBCI5G4wnZv/zYWtrkh1SCMn9E1RrRkTLb1Zydgzi1pkW+gSuhocrdI
uokbciFDrW0ZNyemrWIzZYBaphzSB3sH78pMVYVdvLQo8baMrfjtkvshAujtNw8C
ap0LDjRTZNuy/eAK2RMy41SyvjyopKE8ifW4IYYv1fllJlvR7+BiU8yff4zy2s3c
pUdEOSwrL/9q7bZX5eQfJJdQBdnT7rSc8HqGE1eJV+1TKZZFeOMYqTdoeXogWFCH
l4l8BKRy6H5bnFj02BTMeYGWBwDj3wUBe9osiHj+fxudz617ygLfOZ/mAn8JFB8K
MhYHTyuIKkR2WRhvcfLd8dxEzlrfxI6p8kdRQOsmn6Ds1vh1UNpCNtcAPNJCPIIj
x9BH7l/Jkh+8bEZBdSvvnXegGWjYmu9I3uOuuhkWnFq54C/dcS/9rilrlk5d6TuA
kpAW8qrLGq/mSoakwIT1SXpFTwU7r+IiIsMZeshmm7FzCHNAHfg=
=wHTh
-----END PGP SIGNATURE-----

--+zZiukOeZLi/h++j--