Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t87fQ-002E6E-RQ for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2024 00:43:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1t87fO-006vfb-0K for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Nov 2024 00:43:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t87fM-006vfQ-Gt for pgsql-hackers@lists.postgresql.org; Tue, 05 Nov 2024 00:43:30 +0000 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1t87fI-000EKw-SU for pgsql-hackers@lists.postgresql.org; Tue, 05 Nov 2024 00:43:28 +0000 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 9974513805E5; Mon, 4 Nov 2024 19:43:23 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 04 Nov 2024 19:43:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1730767403; x=1730853803; bh=Gad8ya8WyP 7xR+T0zffa2mmWXZLltEOZgWg+uPLCcwk=; b=RFZ4zVc/F8XW+dEH7ZlHtHDDk8 +bZgNsxVfUwLPhoVERUKO0H6E4I9lDPrcKFtxIkQUVzpxPiAskqihuc3rS95KnZJ YiWeMi+oouCfKYhwJGW656GNZ8hgjwkFD0L4wT8c2DyG6FfE0YDGspWpROPel8Xq iCZMB57WUcZY4o3WZinH6RSeEFf3tzmkjDYE5BX5RDcLe6QoiLWzLRQQsE+lJeUp uwzOGOE+zEcjWilupDfHu6UsjLGg/rvR9ykY1OR2EjyCdQhtmMigJhsmA7pIDYK9 jM6qykZpxQ+SpBNsp/H0z9xJQkOeK3K2BkvPuSnantqHH8wveMG1Zl6jrYeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1730767403; x=1730853803; bh=Gad8ya8WyP7xR+T0zffa2mmWXZLltEOZgWg +uPLCcwk=; b=jDeAjGX+P6Guy3+ORJc7vz+kmD9WoJnGSU93M50TaRts8w04urn V9tg/BxLqakg0pER0jhWznpR/3Uo8kb0pwRDzP3s2iGIlB9WGi42EQKK87Fa0aw3 7Dt4HOw6Tn6yYAi6HWdaj+CSiml3tM1O8B9fttdfMsKvV6zbDpRKbpBEOqXlFCT1 Ty1CZQDVLbfzjIppCfYIFGxPC0v/gpMMbAqy9knrLeEhBCo4Vh/gdYuy0qWaqupj dMV583Qh2JlIf3Q5bJsnZI3hxL25i2KJfnJsS0KEnElhILFjgKrMEniglNURYZ0F EdYTz6V/wFr/iqTgOlcQgN8OSoMTUGLwNkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeljedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucgfrhhlucfvnfffucdlje dtmdenucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefo ihgthhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihii eqnecuggftrfgrthhtvghrnhepteelieefudffhffhtdetleeggeegfffhkeeuveetiefg udduvedutefggeeivdejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiidpnhgspghrtghpthht ohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsggvrhhtrhgrnhguughroh huvhhothdrphhgsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghk vghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Nov 2024 19:43:22 -0500 (EST) Date: Tue, 5 Nov 2024 09:43:11 +0900 From: Michael Paquier To: Bertrand Drouvot Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Clear padding in PgStat_HashKey keys Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dbmMRiX01F4Lh3l0" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --dbmMRiX01F4Lh3l0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 04, 2024 at 10:07:37AM +0000, Bertrand Drouvot wrote: > On Mon, Nov 04, 2024 at 06:49:04PM +0900, Michael Paquier wrote: >> but if we do for the sake of a bug fix, >> which is always a possibility as ABI does not matter much for this >> internal structure, that's potentially trouble waiting ahead. >=20 > That's right. After sleeping on it, it would be annoying to come back to this issue for a separate backpatchable change, and what's proposed is simple. So applied down to 15. -- Michael --dbmMRiX01F4Lh3l0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcpah8ACgkQnvQgOdby QH3Hig/+LWGXTsmobDoRqG3v6uDMRGYKzri0+ryD6uMyMzNRK0/dbprsyEUnrvub hhnLK6WFEEkACCSdC+fe1ouzdhQSAD8KKc0u/1il7fO1NAarHRmyzgwVDG0tqYzB ZR1PNdA9OI0y/lpLVpWK3LSDMaiHTeNPQhWBomduOXTCBdZqxFo6EANcq5ROVokz m+LSVByEYfTscD6pR2TJ1nWFTBZq6xZ2EHaph017bp2dcSLfl0gWfGjI1atzWTuF fdxq2/CZzJ1zpZSXE2rFTAGpu8RetrRSeAsV7jstAwvXlaDqfe/upSdxKZjYFSqB qOM3E58FnfOHXrFdr6AOV+aGJv/8ieMwF+fsSabPMCZd/6XawvaZxglBmNe4V8KH K4HXP3f2BkhvSIxvn4qaFcoJhIAE9ZmfwAhI/MDAAAheCheFGwQZlAzqlHyyY0Ue BGsmgzKbbpCvF4cEufaDNYELecO+XtpRpB3uGqaXFm2Aj325Zn/Dt1CT6mAXyzvY uQjnuJoQEwG/T+t1em1oMARUM5Nn3S9hXJ3aGkzAcf/Wq0veScDf9CgXDM37L0P1 BAOTYsQXO/O87l35nON2ut/pcNa/C6BFxydZRiKkDGdqhoRMGIp/jswtCtOK2YX2 yUSwSjl02R6crgq7wuFqzQheXmlsjWDusG/mg2XBUfbxVH0242g= =rwAX -----END PGP SIGNATURE----- --dbmMRiX01F4Lh3l0--