Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 7 Nov 2024 12:15:33 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Euler Taveira <euler.taveira@enterprisedb.com>
Subject: Re: [PATCH] pg_stat_activity: make slow/hanging authentication more
 visible
Message-ID: <Zyww1XGpE1hQa0s1@paquier.xyz>
References: <ZtUCcpf9y7gnHifu@paquier.xyz>
 <CAOYmi+n4RhhoaduZ-ndZGR_=kkzUjnaZtzi8g2GFsqt==Hhopg@mail.gmail.com>
 <Zt_ZVcW4NmPM9NRB@paquier.xyz>
 <20240910172712.e8.nmisch@google.com>
 <CA+Tgmoade_mRdZQHMub31Y9YKg5FpZzwvzYP35R8AVszoRGWcg@mail.gmail.com>
 <20240910205850.5d.nmisch@google.com>
 <CA+Tgmoa9t-ei=mNjyjdcXxQOY=r0PO-+ncHpryjLaFgV9Y0tyg@mail.gmail.com>
 <20240913145621.43.nmisch@google.com>
 <CAOYmi+kLzSWrDHZbJg8bWZ94oP_K98mkoEvetgupOBVoy5H_ag@mail.gmail.com>
 <ZysDL6JAGR7UyCA9@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4TYB8qMkAVsTyvB/"
Content-Disposition: inline
In-Reply-To: <ZysDL6JAGR7UyCA9@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Zyww1XGpE1hQa0s1%40paquier.xyz>
Precedence: bulk


--4TYB8qMkAVsTyvB/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 06, 2024 at 02:48:31PM +0900, Michael Paquier wrote:
> I'm OK with 0002 to add the wait parameter to BackgroundPsql and be
> able to take some actions until a manual wait_connect().  I'll go do
> this one.  Also perhaps 0001 while on it but I am a bit puzzled by the
> removal of the three ok() calls in 037_invalid_database.pl.

0002 has been done as ba08edb06545 after adding a bit more
documentation that was missing.  0001 as well with 70291a3c66ec.  The
original expectation of 037_invalid_database.pl with the banner data
expected in the output was interesting..

Note that 0003 is lacking an EXTRA_INSTALL in the Makefile of
src/test/authentication/, or the test would fail if doing for example
a `make check` in this path.

The following nit is also required in the script for installcheck, to
skip the test if the module is not installed:
if (!$node->check_extension('injection_points'))
{
    plan skip_all => 'Extension injection_points not installed';
}

See src/test/modules/test_misc/t/005_timeouts.pl as one example.  (I
know, these are tricky to know about..)

007_injection_points.pl is a name too generic as it could apply in a
lot more places, without being linked to injection points.  How about
something like 007_pre_auth.pl?
--
Michael

--4TYB8qMkAVsTyvB/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmcsMNUACgkQnvQgOdby
QH0z5g//XiyEuqs2OEbEU5UElv+Yus+ts86sgfoLex8YiOad2L0jEG2MnattNOJD
snOQVKFkE+JF8EfHK/uryVtRtMkIr0fQnFF7AOrDfOpJM+MVB72dsONumhccrEoF
D+IYhu82iaUbfiD75CBxR8/wcPgHsaQPI2f8N0wLdyMR2yJ+4yj7qOpTS0F3K/ME
Ko5WCwPYC/DmtNOJI0dgsW2ubr9NJH7YZvBW2TyEp5ybL7D4zJ0BEKNi/lVc2sQp
X+kgU3Bpvgq9633x07pqaS8zVcVcBcFHM3ks5lN5dgQQyP4cAvjA/JzHVtUNN2Lo
1zH0ekb2VR2z0KCqUV79TEN+lb7VcRKffaRluZfpS35LXj0U1kkMuz2nLLt9R4C0
onEpHf4NvnZPTaSy0g0lrl5/PeGiBLeHQGxhif40kkoAL4ShBheOIiVoRaG0qhA1
o7aRlgGIJ234rHf9evG7GY/qOWyLzYrcRoW4TZ1NWqrZYcovI9QiSXcveSKcrMLr
GsZg3eWiU2XqQqZmTjxd07fLRH/IT2fNVBnAbNbjiD0296JSFk3vyjqN0ERzpJCu
OLRGG9bIAweEsHJirDwjIelL6W1+dGe56j3AZfwxPeqiqCIy+Fvvkh7JueTsr0hM
f59Pv/ca6lHV5lM4KRDUwispkdJLkmuPGqpuLKnE3c/U7T7Ists=
=z8R6
-----END PGP SIGNATURE-----

--4TYB8qMkAVsTyvB/--