Date: Thu, 7 Nov 2024 10:20:55 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: "Devulapalli, Raghuveer" <raghuveer.devulapalli@intel.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Popcount optimization using AVX512
Message-ID: <Zyzo59fME1JsF3qH@nathan>
References: 
 <BL1PR11MB5304097DF7EA81D04C33F3D1DCA6A@BL1PR11MB5304.namprd11.prod.outlook.com>
 <173022983862.1162.9439822012408182864.pgcf@coridan.postgresql.org>
 <173032159044.1162.17669652767784249811.pgcf@coridan.postgresql.org>
 <ZyKgsihSKB0kAI3U@nathan>
 <ZyPYtMqDnP_lZSO0@nathan>
 <PH8PR11MB8286BFA90CC9BE11AE8ADEEDFB552@PH8PR11MB8286.namprd11.prod.outlook.com>
 <ZyjxVFCEtnmb1kN4@nathan>
 <ZywlZzPcPnlqKvt5@nathan>
 <ux3qakiuks3g32tpgmcna4jplqztkflhmmw2cdj4v3uut5qodq@5vgf6a2gwrpl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ux3qakiuks3g32tpgmcna4jplqztkflhmmw2cdj4v3uut5qodq@5vgf6a2gwrpl>
Archived-At: <https://www.postgresql.org/message-id/Zyzo59fME1JsF3qH%40nathan>
Precedence: bulk

On Thu, Nov 07, 2024 at 11:12:37AM -0500, Andres Freund wrote:
> One thing that'd I'd like to see this being used is to elide the indirection
> when the current target platform *already* supports the necessary
> intrinsics. Adding a bunch of indirection for short & common operations is
> decidedly not great.   It doesn't have to be part of the same commit, but it
> seems like it's worth doing as part of the same series, as I think it'll lead
> to rather different looking configure checks.

The main hurdle, at least for AVX-512, is that we still need to check (at
runtime) whether the OS supports XGETBV and whether the ZMM registers are
fully enabled.  We might be able to skip those checks in limited cases
(e.g., you are building on the target machine and can perhaps just check it
once at build time), but that probably won't help packagers.

>> +/*
>> + * pg_attribute_target allows specifying different target options that the
>> + * function should be compiled with (e.g., for using special CPU instructions).
>> + */
>> +#if __has_attribute (target)
>> +#define pg_attribute_target(...) __attribute__((target(__VA_ARGS__)))
>> +#else
>> +#define pg_attribute_target(...)
>> +#endif
> 
> Think it'd be good to mention that there still needs to be configure check to
> verify that specific target attribute is understood by the compiler.

Will do.

-- 
nathan