Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 20 Nov 2024 15:32:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID
Message-ID: <Zz2Ca2CEzH4GQpN8@paquier.xyz>
References: <CAH2-Wz=+LDFxn9NZyEsCo8ifcyKt6+n-VLyygySEHgMz+oynqw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="t03LyrPFwLjqqdcy"
Content-Disposition: inline
In-Reply-To: <CAH2-Wz=+LDFxn9NZyEsCo8ifcyKt6+n-VLyygySEHgMz+oynqw@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/Zz2Ca2CEzH4GQpN8%40paquier.xyz>
Precedence: bulk


--t03LyrPFwLjqqdcy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 15, 2024 at 11:33:37AM -0500, Peter Geoghegan wrote:
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency grounds.
>=20
> I propose this for the master branch only.

Perhaps this patch should also explain why this is better this way?
This path does not manipulate btpo_level, for one.
--
Michael

--t03LyrPFwLjqqdcy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmc9gmsACgkQnvQgOdby
QH1hlRAApytUWuqRSZoQFMP1MZWuwpnUQme7dqID6Hhc9fOfIEOf6VzJjHeCykkK
AIc0PqoRLx3e8QDS7HNfKvOVTVU6PtFB9wzhYMIUxYkc2S6B8N9yS7WMXwlwpISs
55B2So8NUKLOWiSvq0ZBJdGPenjID6vZAGYqKfg0EarEVKXjBlm2F5DpDQ3KWVb/
hVRQkSUG8MGQH/3gqnPqVIkHYkMw53GdroHK5Cjql0lDyDUxdGPsiFS33BEp9rU9
MBFFoQ0LAwPHpG3e1nKagd2nG4bgzHcL1UCJf2CWuSTF2ym16tBzXicEXvWRikh3
1ON/24sL960A2b1tvBj80FLmaVxnW2f8EUSCHldXiLtoW3lvQQg6pvK4CIBa39ME
qxODB8/vDndjdwjIAbXismf+EzNXgbMMhcdQnD+j/JmOSE4eferXpEKd/oTv0IR/
A6cpUd9VvvItD+B5HPzupSfP+04mMkffLoByuI0aNPQsN04h9hepubAJ78W0/pOD
7DY9VniQR1IzYxGpx0umfpzxI60x2NJLD1bJjW8buXs7iEpBJKfMYqZSRpoor0z1
BGB/ThG3VKyOL00W8neIcpa97n4cHRmebU2ih4t30l8+/TvU3Rzvo8QulHL9dErs
8f8hZX1QmX3ibveFYc5RUnbdn/Sma2Wn6qtvtLW1+OxciX23grI=
=PfkV
-----END PGP SIGNATURE-----

--t03LyrPFwLjqqdcy--