Date: Wed, 20 Nov 2024 14:10:23 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Zz3tzy0LJtHXjdmc@ip-10-97-1-34.eu-west-3.compute.internal>
References: <ZwVdt8/0tTu5pv8K@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZyMRJIbUpNPoCXUe@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZyibjiLgoLx+kS4n@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZypXy3fH/EyALaTR@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zyqsm6ilLLADAGw2@paquier.xyz>
 <Zyt0Rh6Uwvf+mlA1@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZywO84-2K8fxEIx8@paquier.xyz>
 <ZyzrrFNvXC2YvcNE@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zy4bmvgHqGjcK1pI@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZzWZV9LdyZ9aFSWs@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZzWZV9LdyZ9aFSWs@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/Zz3tzy0LJtHXjdmc%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Thu, Nov 14, 2024 at 03:31:51PM +0900, Michael Paquier wrote:
> +	/*
> +	 * Do serialize or not this kind of stats.
> +	 */
> +	bool		to_serialize:1;
> 
> Not sure that "serialize" is the best term that applies here.  For
> pgstats entries, serialization refers to the matter of writing their
> entries with a "serialized" name because they have an undefined number
> when stored locally after a reload.  I'd suggest to split this concept
> into its own patch, rename the flag as "write_to_file" 

Yeah, also this could useful for custom statistics. So I created a dedicated
thread and a patch proposal (see [1]).

[1]: https://www.postgresql.org/message-id/Zz3skBqzBncSFIuY%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com