Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 21 Nov 2024 07:18:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Zz5gMM9w59guO9S_@paquier.xyz>
References: <Zyt0Rh6Uwvf+mlA1@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZywO84-2K8fxEIx8@paquier.xyz>
 <ZyzrrFNvXC2YvcNE@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zy4bmvgHqGjcK1pI@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZzWZV9LdyZ9aFSWs@paquier.xyz>
 <ZzX7Y5i56UrOtlRC@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZzvuScIJW9kwnuyE@paquier.xyz>
 <Zzy8x7fGkWEKB7SF@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz0m1k03k5LA_c8S@paquier.xyz>
 <Zz3wIuQUJysX5O3d@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gI9c4CbFMUlBTvOi"
Content-Disposition: inline
In-Reply-To: <Zz3wIuQUJysX5O3d@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Zz5gMM9w59guO9S_%40paquier.xyz>
Precedence: bulk


--gI9c4CbFMUlBTvOi
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 20, 2024 at 02:20:18PM +0000, Bertrand Drouvot wrote:
> Right. I did not had in mind to go that far here (for the per backend sta=
ts
> needs). My idea was "just" to move the new pgstat_create_backend_stat() (=
which
> is related to per backend stats only) call at the right place in StartupX=
LOG()
> for the startup process only. As that's the startup process that will res=
et
> or restore the stats I think that makes sense.
>=20
> It looks like that what you have in mind is much more generic, what about:
>=20
> - Focus on this thread first and then move the call as proposed above
> - Think about a more generic idea later on (on the per-backend I/O stats =
is
> in).

Moving pgstat_create_backend_stat() may be OK in the long-term, at
least that would document why we need to care about the startup
process.

Still, moving only the call feels incomplete, so how about adding a
boolean field in PgStat_ShmemControl that defaults to false when the
shmem area is initialized in StatsShmemInit(), then switched to true
once we know that the stats have been restored or reset by the startup
process.  Something like that should work to control the dshash
inserts, I guess?
--
Michael

--gI9c4CbFMUlBTvOi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmc+YDAACgkQnvQgOdby
QH3RORAAqDG/jo/KXaKzmpMmipTSX5Ig9sm5b7Sv5qsygYZbWpTPvOt/soXR5X8s
4fKtv00aIIzpVzBDziuwgqr7wI5nzspsFWcA/ut5fxs+YbSfFql4nBNwuzvOtqvr
7hxVyT0HyYqnhkrDWNIbVapr8NifmvdgkWNNYVCGh00a1F+hf1qAFhhlh97CsVE+
kgnl8TP5S2PljNwmK9ug65TV9shnI6+xkrBb5i/2a87A2gf9hGdQqjcHss1kcKlo
2ubzGsXat2L70Ith8ZAewv3wJiSRu8yFmjPRz9ZJiOK622/t4B3tPi5uiTVyNiUv
4U35ACksSiSXKbd5lS0LBlD9nKsJGULwU8Gfn9NPqXdeAyTXlEnJuoIjkP7IJ8TI
4LI0AMEdxMoqUfgRjnfLQ0OL6lk7WE7mdkPE4wnNmjYYZ6e1X5ZlRSSZEKGKccwB
veGihjQ75DGm21zuMBY15ymsK0Gd0HoSTCBAsMQhdVtULZoBH3ZHflDDORCK4pb0
zHoZRPxBRuXcndLHYSAbRDEzKBCSNcRVo74yLW89kaDzlNGFvPq+15qHV3k+NP1t
Yg7HCWJQ+2DT4NrG1JYRvNxlRvt5iNlIg+WxjFHH9BDdrs7/8mcYnusK6SP/mkN0
vs8GFp3a8txs7pSWwKsw2vInQD+MtNtxS1wF8yha1zHv5T82D4Q=
=Bz8Z
-----END PGP SIGNATURE-----

--gI9c4CbFMUlBTvOi--