Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 12 Nov 2024 17:30:30 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Converting contrib SQL functions to new style
Message-ID: <ZzMSJkiNZhimjXWx@paquier.xyz>
References: <3395418.1618352794@sss.pgh.pa.us>
 <3133933.1730855116@sss.pgh.pa.us>
 <ZysEEDZqsnP7GTKA@paquier.xyz>
 <5829980.DvuYhMxLoT@aivenlaptop>
 <ZywSnWzXskAxSDew@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dSKsZCaXRIwF59wO"
Content-Disposition: inline
In-Reply-To: <ZywSnWzXskAxSDew@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ZzMSJkiNZhimjXWx%40paquier.xyz>
Precedence: bulk


--dSKsZCaXRIwF59wO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 07, 2024 at 10:06:37AM +0900, Michael Paquier wrote:
> Good point.  Checking all these contrib updates one-by-one is an ant's
> work, but I'll see if I can get at least some of them done on HEAD.

I've begun looking at that a bit, and there are a couple of things
that we could do better with xml2 in 0005 at least in the context of
this patch: xpath_nodeset() and xpath_list() don't have any test
coverage.  That's not an issue directly related to this patch, but
perhaps we should add something for the functions that we are
manipulating after this upgrade path at least?  That's one way to=20
automatically make sure that these changes work the same way as the
original.

The same argument comes up with lo_oid() in 0006.=20

0004 for pg_freespace is fine regarding that for example as we have
calls of pg_freespace(regclass) in its sql/.  I've applied it to begin
with something.

Tomas Vondra has posted a patch for a bug fix with pageinspect, so
this would create some conflicts noise for him if 0003 was applied
today, so let's wait a bit:
https://www.postgresql.org/message-id/3385a58f-5484-49d0-b790-9a198a0bf236@=
vondra.me

0001 and 0002 are much larger than the 4 others, and I'm lacking the
steam to check them in more details today.
--
Michael

--dSKsZCaXRIwF59wO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmczEiYACgkQnvQgOdby
QH11uw//dZWSvhyH5860uTjefPff5STFFSHMaAOl0uWxwv0Ip8hFHkF94ddTJKIi
QNOy9iD9SIMm4VQVSnOeA9BYlj34riNWyy/ZKEcVC4ogqT+xpF79/1y7Ayn5MYzF
TInhtMWko8V6SOIQ2uFEvjp/SDfMmJHvZtlcDCO/+L5HHvr5lLhU74DftytcTgqm
0mUXA9JQH3lqe+ySq2BbkY8+Ik5Vcm4CryboCQuvC0Z7rgS0mlrPm2n3q2E+8ME5
cnDAN4uqG2wsRdXbwFas+UcZ2teFi7ToSJo99m9Z1vFmRCdG91Gb5zfupmtfKNzg
OMqBPZOE5hjKgTMcJhHhAofFY78Axxa9CLHqNavedhRsDT56R2V4GtpcWBeLSLFp
s//48zUAYp0oXaA7ucvonyBW4lbubUXpQcPFyaaxwSTwTRpd1eapqD4hdA20E5Oy
yCN0ZSL7xqg+6ayo4NIo1pTOd+AkYZuwYIfTzu8QG3Tb8lbPs5tYr6K5P8OLAspo
viNKyn7AwWV7xbZtBrAeegCh3utPIeMEmIP9u8NBhrAZCp1Z+DiVP9jMG9wXo5vX
c0nryURFcLf87Eo1BYivsnkycnfmukpsZItZ8bxIsuydlZ66lcg0ulHVtMDzT6qx
HXOpS4/pJQDNpXpY1yg2gZZKuyem/jTkreVUCdOAapkypTDpWrI=
=Rqaj
-----END PGP SIGNATURE-----

--dSKsZCaXRIwF59wO--