Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 14 Nov 2024 13:39:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Rahila Syed <rahilasyed90@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Enhancing Memory Context Statistics Reporting
Message-ID: <ZzV-8qOOBtPdP4Tq@paquier.xyz>
References: <CAH2L28v8mc9HDt8QoSJ8TRmKau_8FM_HKS41NeO9-6ZAkuZKXw@mail.gmail.com>
 <202410261414.y3erpkk5hnyn@alvherre.pgsql>
 <CAH2L28vtosqeTDuyY0v-2WUGcbhcX80fpAqiVwvBzk=+yn5awg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="I1i5tqJsW8qqyct1"
Content-Disposition: inline
In-Reply-To: <CAH2L28vtosqeTDuyY0v-2WUGcbhcX80fpAqiVwvBzk=+yn5awg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/ZzV-8qOOBtPdP4Tq%40paquier.xyz>
Precedence: bulk


--I1i5tqJsW8qqyct1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 13, 2024 at 01:00:52PM +0530, Rahila Syed wrote:
> I used one DSA area per process to share statistics. Currently,
> the size limit for each DSA is 16 MB, which can accommodate
> approximately 6,700 MemoryContextInfo structs. Any additional
> statistics will spill over to a file. I opted for DSAs over DSMs to
> enable memory reuse by freeing segments for subsequent
> statistics copies of the same backend, without needing to
> recreate DSMs for each request.

Already mentioned previously at [1] and echoing with some surrounding
arguments, but I'd suggest to keep it simple and just remove entirely
the part of the patch where the stats information gets spilled into
disk.  With more than 6000-ish context information available with a
hard limit in place, there should be plenty enough to know what's
going on anyway.

[1]: https://postgr.es/m/ZxdKx0DywUTAvkEF@paquier.xyz
--
Michael

--I1i5tqJsW8qqyct1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmc1fvIACgkQnvQgOdby
QH20Cg//dXeqlZne6Ll8B39bGrnDkYqtAjnXqA/4t1gHHVm2TdWxQuNLqDuF4X4E
Cm3q4EUvVKagawxvZyr/SqQxmdGp3Jgqnaosu3cDpe2XCTOM7frp3Xau+GA2jDoc
igy1GjqqpFWuKxWqOX38nfItvsKjzrHbCL3webaoSJIhFwY1ksMwsASnE9vkdTZD
Oa2hWdmcMUAEMpIWI24/KbO3WX4nJX6hauen42x1b21fHV3IIRoDd6Ta3FvggYfK
FcjVFm09z0ELD85r8jWt8xWwzFhW007MyGdsIwdueNYZRq0Upcw1bL7VdaTLeeqj
vuIeUuQ3and9sBRA3XjeMPeyQCtK6xQond3Zd/U+F49NnztE3xQXFkyjURSH7mX1
qrxvcB5a+UQiOxcLFkX3oqXzcGLwinOShgqVwwwk2UKAq3JpY6THhHcuUsUFoabU
AAvWJyNhd9oT93nlOZacpenSmDGFrUzIBg7msYAsXb9QzEd9WEmgxUVap/SaAt2E
Lg567l1H5kBIwMLOFUFtOBSZ5dnnz1N74FxBYToQO1EhZo9EojCbeH6cufRctfeh
JAhnfnthCjDXo5lgPTTDjNwVciBR5KIHTjYPKGt65puQy8G2zed5Q//+nQuW4MuQ
5SgQG+bclhd1VCmHssT/1biEdmRJ2klCfIqHc4Znjt5qEAX7+Bs=
=YadO
-----END PGP SIGNATURE-----

--I1i5tqJsW8qqyct1--