Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 22 Nov 2024 10:36:29 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: per backend I/O statistics
Message-ID: <Zz_gHQ2g8MUe8oJ1@paquier.xyz>
References: <ZyzrrFNvXC2YvcNE@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zy4bmvgHqGjcK1pI@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZzWZV9LdyZ9aFSWs@paquier.xyz>
 <ZzX7Y5i56UrOtlRC@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZzvuScIJW9kwnuyE@paquier.xyz>
 <Zzy8x7fGkWEKB7SF@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz0m1k03k5LA_c8S@paquier.xyz>
 <Zz3wIuQUJysX5O3d@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zz5gMM9w59guO9S_@paquier.xyz>
 <Zz9sno+JJbWqdXhQ@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/jM6+/QoF+/xCPEI"
Content-Disposition: inline
In-Reply-To: <Zz9sno+JJbWqdXhQ@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/Zz_gHQ2g8MUe8oJ1%40paquier.xyz>
Precedence: bulk


--/jM6+/QoF+/xCPEI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 21, 2024 at 05:23:42PM +0000, Bertrand Drouvot wrote:
> So, given that:
>=20
> - the end result would be the same
> - the code changes would be non negligible (unless we have a better idea =
than
> pgstat_get_entry_ref() returning a NULL value).

Hmm.  created_entry only matters for pgstat_init_function_usage().
All the other callers of pgstat_prep_pending_entry() pass a NULL
value.  This makes me wonder if there is an argument for reworking a
bit that.  There's a fat comment about the reason why, still, that
would make the get interface for variable-numbered stats a lot
leaner..  Not sure what to think about that.
--
Michael

--/jM6+/QoF+/xCPEI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmc/4B0ACgkQnvQgOdby
QH3qyQ//boeJ5ZmHtNstB2S5MdorSS1C+Fcfku8UK/VhBiZ+S5nkRShFNiDmZuxv
ONCuTBHnoQ4DSfF4vSJ+6fc7kqQgX0ojxheAg82ARRCr8M0JagHaRA+KBqOKoFqU
JyfIlsMrFtZfE5RWTdar78bVwOYBalyhVmABHfT911HWwCqci/8D61zZkAKl/RkC
Hk3RgVg4xWs239lCPhmHJ8H0NxItOjQSu04gAHJsA+sReTGVE8dW1+pRQCpr/j0p
k707Z0LrLJmXWEnnWxV+UwSRzKoaSvpN/MddcYsfPrmF2aqya5YAQlgVG1Qjj6s5
ONLiif9/IXjFDOvi/QMygzs1klYuKjRx1e7/EilXYP16rigI3ePqhEVPgeDdt0PE
duzi/Jzkkl0saDmOu2V8QRTwJhnUXzCwF7tDVjpvj0wE3b2awhkFhIAHQEbzRYjd
8emhfMkLhNvMyRKE6n2DMnYG9/ZhNk/PDGkVIlf3MrPRn8s4QU3zxk8if2Sq9kv7
suKBKxMFy/FAB451Ph25j4NYHk4UwoRDLZ1XElL5sdcTBtLi+jwM+22qjZC0tqFW
8tDlfZ1VVFsJmZtWw5hDMMju3lrAayJkPqJbrxa6rCMANN0cjW5Ydoju2ZCIQQf9
yNIfbvygEtya8ErXSC++SwJFJhuddBDBFEHXPaKjLSQ+GYK4UeI=
=ziKA
-----END PGP SIGNATURE-----

--/jM6+/QoF+/xCPEI--