Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 15 Nov 2024 13:45:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Kouber Saparev <kouber@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: BF mamba failure
Message-ID: <ZzbR5Eu66lP9rt50@paquier.xyz>
References: <Zm-8Xo93K9yD9fy7@paquier.xyz>
 <172854117093.1162.5418906857588663992.pgcf@coridan.postgresql.org>
 <Zwfnwai6lQMk1xYV@ip-10-97-1-34.eu-west-3.compute.internal>
 <CAN4RuQtMHbVjWX-0sHOmVUxpsbMDX0tMndvfmNk-+ak4QBUWJg@mail.gmail.com>
 <ZwjfckL/y0nMCIEz@ip-10-97-1-34.eu-west-3.compute.internal>
 <Zw8MRH2ks_BgLTa-@paquier.xyz>
 <Zw+RPPRDK+L2W480@ip-10-97-1-34.eu-west-3.compute.internal>
 <ZxCRku2jk8Jz0sTU@paquier.xyz>
 <ZzWs6_pKr8DgEAvs@paquier.xyz>
 <ZzXL7WkzGyhxJljW@ip-10-97-1-34.eu-west-3.compute.internal>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="5NKFXOi65NYznieN"
Content-Disposition: inline
In-Reply-To: <ZzXL7WkzGyhxJljW@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: <https://www.postgresql.org/message-id/ZzbR5Eu66lP9rt50%40paquier.xyz>
Precedence: bulk


--5NKFXOi65NYznieN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 14, 2024 at 10:07:41AM +0000, Bertrand Drouvot wrote:
> =3D=3D=3D 1
>=20
> Maybe use "generation" instead of generation in the comments (where it's =
not done,
> some comments do it already).

I've tweaked things to be more consistency, and applied that down to 15.

> =3D=3D=3D 2
>=20
> We could think about adding a test. That should be doable with replicatio=
n slots
> or custom pgstats kinds and probably injection points. But I'm not sure t=
hat's
> worth it, as the code in the patch looks "simple" enough. Thoughts?

The tricky part is that this path involves a backend shutdown.  We
should be able to do something with a wait before the dshash_find() in
pgstat_release_entry_ref() with a BackgroundPsql object that gets
stopped, but I'm not sure if we can guarantee a lookup of
pg_stat_activity at this stage.  Let me see..
--
Michael

--5NKFXOi65NYznieN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmc20eQACgkQnvQgOdby
QH2V4RAAl42UJqHvugEvyRSDtNcq3ksuODXOMKiED+lzB5lHOChSGwupKaJ+G1Un
Oty25x9IPvGizKcAvVPObjPzfo1Hl4vUz+8EunqqYaZqAhJhq/pKYMrDYb2ngVN6
5tOCSCgLkxdf0thGd32qtciD7rAKqxtRvULzONHRPy+WcvDgIos2eJH6vnxVpxZ2
zL9JyNPz0+IbTcM/Cq2Z4/ppB6nxx8IliQVcSVWhPGpSLHEzC6aGVSBgdUCrygTD
JNoriG3/a36OSV57f112xe3hPW2kBWkQbbxsXC8zzKEKxvUotHPa80Gr4VrgHzUO
WSJYFPSQiScw2xY9jiw5brTATcuJ3v+snPardbVlJf96I945p7uO3s+gvhI8sk+4
6V0S3wPzu6bULGw94a0vQA4b+bppap4Nd0dEcRAO4zuzr1C3gSbTqDqGxf+cUYkk
YxMQXyO/L6xR7KcvRsKOxI9WJOeYwAUfm3rmfPZrTm0dVyxmubLcFO4To1BpnojB
0znIiwtE5X4JHZ5uhvtT4jHxn7pQ2xZFjFzq5OjmC1FUl6NJXErFzZcBNfRVlgqW
bS9ZA6kMx2ngCjDgVJ0Z+hYXVrrvfM7nXLZ0iQ31EvQuw0ml3P3CspPRgld0lWVC
vLhzICF9t0xVI5GCz3mhBcTZvK5WCH5F6QSvA+LIjnAIM9eN6OE=
=Tx6z
-----END PGP SIGNATURE-----

--5NKFXOi65NYznieN--