Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ixZaT-0008Vx-3T for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Jan 2020 16:56:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ixZaR-0005n7-Rr for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Jan 2020 16:56:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ixZaQ-0005n0-Rn for pgsql-hackers@lists.postgresql.org; Fri, 31 Jan 2020 16:56:07 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixZaO-0007i5-0V for pgsql-hackers@postgresql.org; Fri, 31 Jan 2020 16:56:05 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B4F034C1; Fri, 31 Jan 2020 11:56:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 31 Jan 2020 11:56:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=LarIKEjB93T1nDdE3W/dKNe6dZC3DngfcKfr8Llts dw=; b=Ywpidj07g18T1OeomNu09q5k3wfIMMQE9UdqplYcMwAT6AqMJpkPDzMV1 dWyrDm02XYk3FdnSvVvjBlXM7zoRTcPRLR3Qctd5kcbrxxjzou5CDha8A/IpWi60 3LmGLl5FmcV3ryECW8EZyLlaPZ1LhzeqmE11OIhnzH4rl2BhQCHVxL9SUIscs4mQ XCKMaDizLzHdALRLMN3lsIbr5FOwAB/4NC74DEWaLthF9uu2t9zt+AH576NG30i/ 3Y5lovi6gPWicAcBM9y6oxzIWbkvNpHXbIyv1rXwwxDawII+AdpwXTLWohgBjjfa v8kSy8ft81wcTrLgU7d0n/SMQ5dzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgedtgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefuvfhfhfhokffffgggjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsedvnhguqh hurggurhgrnhhtrdgtohhmqeenucffohhmrghinhepvdhnughquhgrughrrghnthdrtgho mhenucfkphepleefrddvgedvrddvheehrdduuddvnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhhtsedv nhguqhhurggurhgrnhhtrdgtohhm X-ME-Proxy: Received: from april.pezone.net (p5df2ff70.dip0.t-ipconnect.de [93.242.255.112]) by mail.messagingengine.com (Postfix) with ESMTPA id 661B83280066; Fri, 31 Jan 2020 11:56:00 -0500 (EST) Subject: Re: Unix-domain socket support on Windows To: Tom Lane References: <54bde68c-d134-4eb8-5bd3-8af33b72a010@2ndquadrant.com> <00d4945e-b437-f3b5-f4af-42e99321c846@2ndquadrant.com> <5974caea-1267-7708-40f2-6009a9d653b0@2ndquadrant.com> <75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com> <3b5fed50-9017-49ca-b556-303a0cc1b660@2ndquadrant.com> <30627.1580409696@sss.pgh.pa.us> Cc: Andrew Dunstan , pgsql-hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Fri, 31 Jan 2020 17:55:58 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <30627.1580409696@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-01-30 19:41, Tom Lane wrote: > The code looks fine (and a big +1 for not having knowledge of > DEFAULT_PGSOCKET_DIR wired into UNIXSOCK_PATH). I wonder though > whether any user-facing documentation needs to be adjusted. There are no user-facing changes in this patch yet. That will come with subsequent patches. This patch has now been committed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services