Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkfwl-0002uc-F9 for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Jan 2019 02:01:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gkfwk-0008Nc-2I for pgsql-hackers@arkaria.postgresql.org; Sat, 19 Jan 2019 02:01:18 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkfwj-0008I5-Jf for pgsql-hackers@lists.postgresql.org; Sat, 19 Jan 2019 02:01:17 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gkfwg-0005sp-7F for pgsql-hackers@postgresql.org; Sat, 19 Jan 2019 02:01:16 +0000 Received: by mail-wr1-x42c.google.com with SMTP id z5so17198555wrt.11 for ; Fri, 18 Jan 2019 18:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to; bh=fLOwz71zMi5abDSIqwfNbqRju1AiKcOUq1jka4X67cw=; b=AXhbvXltCYdYizuVgh0WZq2YaWYJj47uyzazpjdKxioN/vNDYZ+W8TGlDjQav+b83k AIwhvGBIQ885e8YdU75M7lpHEWgIckJ83MFPbEqe2KqUc+5VIcFhvTnNpZhvdH0BYUjG ldcLlPI+CU5MHcsZbmQqu34TYW5wkAH8PM7hr1HEaMBT+TUTYWubfs+iD6NcRml9gKky oCWgrAcFta8i93c0zny22kLOTZRiC6J95sepRruAZQ5MS4Duy3p6WeZXibvfXZFb0lXs +mzLVLlXhdBb6pQTTBGd/RSRiYvSYADfHOB/NZ7h1TJ1qI+r12U10nNATnNL4X7Sh7Fw V6LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to; bh=fLOwz71zMi5abDSIqwfNbqRju1AiKcOUq1jka4X67cw=; b=S8n2quRHuuTb4h8gs9dW0A3L4Bl+MU9CpqzwcDw7LrQDcJQdTFJbWwzUZ/l3LYRlCq rJNADwNqiIDG0nuDqMqLSaI+IzTPqzTLGyTbchxirL95yY72T2TntqfAdYsYHV0gDofC vbVwWNJGXEzhN2P3K5+dUOjci2E4y6A8l5bihu9JHMIN8kl7vuJtJwR9V19SeO2B5jUS z7tl8/tP/nwJv9TDfvobSl96Iu3WyNlfWl/T+7aQo0hIY0WbNmMDs8Q8MR1K9NMnL4YX NTeSLugi6YPlK0oYQkoYRDtxpmOtz4OmJceKzu0RRs+jni8ebTjAoVc9uVkDWwgq53oN y/cA== X-Gm-Message-State: AJcUukeXw1jYjxIBzmyUU2w1+9k4iv7+u/hzl0qPCe8pBsHFgEem74+F LhrKjTNjX93YC422n52FLaXnIg== X-Google-Smtp-Source: ALg8bN5tZjp0Xlq3huSy3KjwCNpbOPhkLmbLyehMa13Kw73fRS0yyqlxwpqvh1FhgG9VQkmy6HaahQ== X-Received: by 2002:a5d:4046:: with SMTP id w6mr19574166wrp.92.1547863271007; Fri, 18 Jan 2019 18:01:11 -0800 (PST) Received: from [192.168.0.3] (ath91-3-88-167-161-184.fbx.proxad.net. [88.167.161.184]) by smtp.gmail.com with ESMTPSA id c21sm40273751wre.71.2019.01.18.18.01.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Jan 2019 18:01:10 -0800 (PST) Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0 To: Michael Paquier Cc: Alvaro Herrera , Sergei Kornilov , Peter Eisentraut , Michael Paquier , Andreas Karlsson , PostgreSQL mailing lists , Stephen Frost , Craig Ringer References: <201901161759.voovsk55ofe7@alvherre.pgsql> <57479e55-ce26-5c00-2525-09e267c7224a@2ndquadrant.com> <20190119013312.GC3306@paquier.xyz> From: Vik Fearing Openpgp: preference=signencrypt Autocrypt: addr=vik.fearing@2ndquadrant.com; prefer-encrypt=mutual; keydata= mQINBFg9q8kBEADfBQMKbYmvL7k4D4ghRYon0lMRf9c+dADesMGsBh5SYTK1/t4S4iCfbc8d QUCyJWSiJYkT1MZNSywbr3hNahZ7qAN0y4kvGNUIxXJGcza5qH5gHQYFrpB/IDoZcZ5/l260 Y5roqQos7kimpALNrl2cXWkR98Z9FWZOocImzdBnKV+qHzD9ZCPISPqR92N67gPqLD4YNx5Y T4NkT2N2nYZlyvv6X3t5/haLWpSLTJ/7ESD6jwTs7Ok4meLidSqr8U25p/L4mb+pscR6l5Hq aJXagW9oQ0uI50Wlri1GeE/JTqaURxfOCWBE3RzrRdhH0HYMOz49gLqba0s4eBlMw18R0OWt TD4mRnpD41X4aaSrMEqm2xXZAa8T+UFlQXWliMvFJ4rQhAogPLN9yI93FDy5pqJdtu3T/mJu HycJfiJHtgGVP8bsMQdg5X4kNWO2LnerJQiO+cYambgb5RWBS3byjO8f05sIXQxIR1nLdGEY 7Cy5/eIN6+qRA3kpRjfQ2QOlEKxVWNLu9t+xGphRi6TidZWnhHRwfCkeelR9R4niubLQPirl /XvToUtm0opXBHbVxTVblM0i7z+x9tnQUCa1f710pnJ/LRqE2Se/JPbEeg5JH4MLLGdr8uxf fv9E8dJVvmTRIWOJFNFnd9e3b9K6I/ek+ysVFsNrKnP9dS4R0QARAQABtCBWaWsgRmVhcmlu ZyA8dmlrQDJuZHF1YWRyYW50LmZyPokCPQQTAQgAJwUCWD2ryQIbIwUJCWYBgAULCQgHAgYV CAkKCwIEFgIDAQIeAQIXgAAKCRBzOWT4unEhz0W+D/0ZqG/7SmWxSPSm3IcwQaGvxKIE/XFv jZ5USS6W1U/Ttq8qXnJbWOTzEKl6NVQcAuAIAYdvOjwrDDR9SMSMPvHmd7LniOZ4/+V2rdLj fOXzExI+1yJ1TYv1pGTgt5ZmjARIvge942iEYHQey5pavoNI1/C9V0RLuh2yS6dLax21295V OFOhQD11mDJLJ8c/ILVpadqt90V9bQzBWycPOjnwjhxD4kVXMjihnl54EuMp08UW6OTCP4ux /SxJFfTM1WDr+GDk7RgsG3bJfwftdUP2Qc8drwu0LAT41edmaigFGM1RMKeBWeo5Tdcm/Wmo uDeLJwL+CGvEZEjNrLxoXBhuRcv+9m5eYOafqewKgZXTmeZImbk75Jp502LCQHXhdatr9O8a KKjmkKqz+uPOV+4qsvqXdMCCFWb15/Pd/a8ffPMRwq6ebDOPYXJUkGqc65tSlf0gRxfIKof3 gO3TevZ0U1nc7kBa/QNe2QN6RC24+GbyJNEvQ6g2ZbBddffiuYZElsGM3+yiM6jz2RWG4uLQ /Qjw6ZwhNUCOepVa3SsLkSE0HN2M2emN8exQIdJw37IiKIsZPPFa+J3netLfXB4F+/BnwVqK GW8eaLYQWQYRBPTMKgLCqGDCgNIB8cVG7zmx7zYDPXNEwKPfcGSkixfQJxgq1InWDyVg2qwU TP0iVLkCDQRYPavJARAAsdzHCSxLnqy1UW0qNhJoZaIkSbQQ6Bjqgfo4KZKvt2eBe363ubgw 5j6VCfpBpOSJYQrOadY7GOKw0m8iwtr1bvrNg/7SoqfwoKLBTvuxo5WsUD9e8f/Hy1CoMz/3 o1qAvBiQK+MnZvmgtwvwqWpx/g+H2uH8aPttNC1x9lO866o4JtoVWumi01si6KKjO+ZNazPi n9a0JW4OVeLxhIy0OnrE4KMOrnHZlJPIdGP36dtFMK9tyqQ3z3zOp/HN+3mrQZAphH/2idLK wRZURPpisvy3HES9yN/JAWtPEYB0OAhKGJhgLDue08zM8FRNa5ldc/oJCqMEC8D5bh6g3LCz uIM11hOMD8OJNX1lGnzdicBLMghUfhtAJ+KfBGqIG3hLxzYp8RiIfG/HJyA6dhqpxG3y6yjO 0r24THuXceW7ygqQUB+J2KK8B1iWTwiMBvvIav9tOQTcYkU+EFtN7zwkC3aN2HV8I7QLDUWw OyWZ1+J1ff3xyCjMhZ0SaBV8kUy981RE8lnmy/T6lE9iFfj2roSkCLcUkODb9mz1BSeg7l1J yRGqQ2ypxS3l77h+JC1SMRrDUz1vFIIAuvQEjJgnV5JUjmNi/0s+/HQU8YRlQWERSH9pHwFL ZgSwH5hqCLFjiGLxxHqJ4JZLoP7J1I5tpuUkbVPhreRNNZ9ro0Wtd9cAEQEAAYkCJQQYAQgA DwUCWD2ryQIbDAUJCWYBgAAKCRBzOWT4unEhz2qgD/95NfvOedTfZ2P0hXTHlE0oGL9pIP21 dOng/fJT1yc4nA4MfNV3Hf72Gpw/XLpnMgovanqj+15ZyFPirCaB9lCjEiorzSsLN9k0I1OC +gIbouFHgYo3nzeRJf/hMlAzef7sqjuD5WyI7miMeaKXkjTGyjC39xX2nq5EHCI8V/uBtT94 3cyZmCrEl64AKjlnFfkNKhlYWpfDWSVSxz79QAIw0wW4ILNFfAp3z4DPjqGut98XBlmtQlDj RMlqeUHDIGLQjKNmxH95vbTS9eAFom6jA99Bl4nWCWUYHoGA/y7Ov6z9vQwqkJ4WqPMg+mas 7nZNQiexBj3tG5pRU2M7NURnaLiINFXid+kjKmNEUgNyd0haIqiIRtkRWZ2zvAwfudS7HDq1 RB6GWGHtJrVFRIkgs3gBoyPz3kSwlYieid6Ywquxd3dQqkN6cdlnvt2uossgRnqXx5HugP81 Faadir4t4t6HqoLHynzvvT9fMijT//O6Fb0MFqZP2rf3i7zh7/rwtpdxI2m/SbTJgvMqlvGn riBgDbjEz8XNMGqMk/WPNcKkk8prCPta9ltMl7yd3LqzCG6KRz7TtQae25BcBF1IKobZYbgf qc5fRxkCHCy6IDu70pve2tt1hzvZquE2Z5uTMFp2k213HJQKklY/jAOmVhM2O2T2oSaKAr1u MUmXcw== Organization: 2ndQuadrant France Message-ID: Date: Sat, 19 Jan 2019 03:01:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190119013312.GC3306@paquier.xyz> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y7ENqTFOevkkXgmxdLdVnweWNls4lOxwZ" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --y7ENqTFOevkkXgmxdLdVnweWNls4lOxwZ Content-Type: multipart/mixed; boundary="4hRRsQroB2f9r7DDWw8v1uAppQGxdQFB3"; protected-headers="v1" From: Vik Fearing To: Michael Paquier Cc: Alvaro Herrera , Sergei Kornilov , Peter Eisentraut , Michael Paquier , Andreas Karlsson , PostgreSQL mailing lists , Stephen Frost , Craig Ringer Message-ID: Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0 References: <201901161759.voovsk55ofe7@alvherre.pgsql> <57479e55-ce26-5c00-2525-09e267c7224a@2ndquadrant.com> <20190119013312.GC3306@paquier.xyz> In-Reply-To: <20190119013312.GC3306@paquier.xyz> --4hRRsQroB2f9r7DDWw8v1uAppQGxdQFB3 Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 19/01/2019 02:33, Michael Paquier wrote: > On Fri, Jan 18, 2019 at 07:58:06PM +0100, Vik Fearing wrote: >> My vote is to have homogeneous syntax for all of this, and so put it i= n >> parentheses, but we should also allow CREATE INDEX and DROP INDEX to u= se >> parentheses for it, too. >=20 > That would be a new thing as these variants don't exist yet, and WITH > is for storage parameters. In my opinion, the long-term take on doing > such things is that we are then able to reduce the number of reserved > keywords in the grammar. Even if for the case of CONCURRENTLY we may > see humans on Mars before this actually happens, this does not mean > that we should not do it moving forward for other keywords in the > grammar. I'm not sure I understand your point. I don't want a situation like this: CREATE INDEX CONCURRENTLY ... DROP INDEX CONCURRENTLY ... REINDEX INDEX (CONCURRENTLY) ... All three should be the same, and my suggestion is to add the parenthesized version to CREATE and DROP and not add the unparenthesized version to REINDEX. I never said anything about WITH. --=20 Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support --4hRRsQroB2f9r7DDWw8v1uAppQGxdQFB3-- --y7ENqTFOevkkXgmxdLdVnweWNls4lOxwZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE9ypqta5ViFTDtSDUczlk+LpxIc8FAlxChOQACgkQczlk+Lpx Ic8lnhAArvNtWjA+pzPYuPRGQhL1CBE8e81dzL1uda/k3btq9SS26LIsg2JyqpDX gNOprK232Ek37x+8tLhA99ycNrStbrbvkLqSrTi6upqtkJyxf5Uf/AreM9vusgki /rS0xREJxYRsBTZWeOF413tnb1HYC8fnTWxwkTZ7cZnCajjhJofBKnxYpFalhnif pN64LLTEE18KLAMYOOI9eQ4qPjsccygP7wHTKjSvW/j77gdXUMW8WqAG72SGPtUx Wtl/O+oTrXq2jK6NPp+LEvOVluM1nEKX3S/SItO4Lv+aFy6QuMB2P8QMCk29zSuV bYyIumk4It0s/NEst3YEkxmXVNWqsxXnDN+l6khr5oH7XR4HvmFs3MplkNUnrctO x07VxGnRyT6PsBIKsHB76EXRAVugcWmEkA3FdOIPY+AH240FLkD0PCwzjyp/96OT rExLXEkCAW+k3Fv+ZAWEylnUY4+OrA/KLY2KIyyCyftVz6O5ZxBOC3ADJ+qXFoqf ePDFH+V7VbGZ5havenmK/uFxbjSr458HUmeaWYWqmEIHrHym5AOyEHSeCCl4ek02 z01ldGZ1QR8F8LuZN+bdHr1uwOxKChaQXBG0sicsXy+H1c1G5VlWkIP7Dc81uCVs q/SrPbVrfvZMlmbfU1Ty7oE3TYZEplqXZCmlCkkhivUxWYHpU94= =DVvX -----END PGP SIGNATURE----- --y7ENqTFOevkkXgmxdLdVnweWNls4lOxwZ--