Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qm9m4-005r5E-LN for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Sep 2023 09:27:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qm9m3-003Kme-3V for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Sep 2023 09:27:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qm9m2-003KmO-Ok for pgsql-hackers@lists.postgresql.org; Fri, 29 Sep 2023 09:27:02 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qm9m0-008FeI-Ct for pgsql-hackers@lists.postgresql.org; Fri, 29 Sep 2023 09:27:02 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 17AE532007CF; Fri, 29 Sep 2023 05:26:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 29 Sep 2023 05:26:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1695979617; x=1696066017; bh=J2y0AXeXVTN/hQwkxytRRJjNo3h5EhMLt/b yZdAMc+Y=; b=kVB6MIUp2lNPdViusmwWtvdfZ79pSemcjV7sAXzwKqxiXL3VUPT hDa6FbMnW8fGVP57t2i7xo1dZKjT9UHNk06cFO5203ERFXpSCUbiU0iU83pTn4wp B4jiEOy2Hqn6DLVDP+RllFqnNzRWFcMgSC3FSnEaQlyC7kt4bJW8t4+9PyefCA/g Exuna4mekkHNhpY2+x2tlpHoi2ZMLtnCQ04/zZ6ZdnoxCQ5DFkUXwlEotwskci3u MUDxYTahsGhX+lr75EDwEkecJyms8XYHRl5kCuJfKVD6S2wzrCatl+BHjE2Dprka i4Bwer9P1i/QKWYkmYQZnjVxEwX3brYkIhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1695979617; x= 1696066017; bh=J2y0AXeXVTN/hQwkxytRRJjNo3h5EhMLt/byZdAMc+Y=; b=X sDoowBq7MHS7YtHiyDQFcsnrt/jf07i/S1+LewO3fpqLsGn+YI4ZFUHtmYlJA8Ll qf+jBFmsmZJrww1nXgTqmNQlsmDUpkVQZJ7Akd6/6RyUp3sULbnRhLJ4W8Ev7x7U iD9I2yi1ugRnXwJYpsB5/JS+hkMdfJZ2FU6FoookRs3qbdYj4sj4T8Q7sjHw0ZlS TbyJjezgMp0R78e67uMgQKXiV4GOR589wMMW2N+Fs9ZppaAQHH5i7pcOHWc6fAgv 9i4pE/E+LioEwYYMXoBBVGfQgKxNkRXa2N+WhDFH0dDgna0pZ4jEN2uMsm3BpEIy YJZU3sRzRfeQ8lzUqML3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrtddvgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepudfgudduhefhjeeiueduhfeiffevgefhgffghffgfffgudev hfeljeeijefhudelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Sep 2023 05:26:56 -0400 (EDT) Message-ID: Date: Fri, 29 Sep 2023 11:26:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: Remove MSVC scripts from the tree Content-Language: en-US To: Michael Paquier , Postgres hackers References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 22.09.23 03:12, Michael Paquier wrote: > It has been mentioned a few times now that, as Meson has been > integrated in the tree, the next step would be to get rid of the > custom scripts in src/tools/msvc/ and moving forward only support > Meson when building with VS compilers. As far as I understand, nobody > has sent a patch to do that yet, so here is one. > > Please find attached a patch to move the needle in this sense. Your patch still leaves various mentions of Mkvcbuild.pm and Project.pm in other files, including in config/perl.m4 meson.build src/bin/pg_basebackup/Makefile src/bin/pgevent/meson.build src/common/Makefile src/common/meson.build src/interfaces/libpq/Makefile src/port/Makefile A few of these comments are like "see $otherfile for the reason", which means that if we delete $otherfile, we should move that information to a new site somehow.