Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v2ngL-007YX3-NN for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Sep 2025 09:27:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v2ngI-00Dy4A-Tb for pgsql-hackers@arkaria.postgresql.org; Sun, 28 Sep 2025 09:26:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v2ndw-00Dtu4-DR for pgsql-hackers@lists.postgresql.org; Sun, 28 Sep 2025 09:24:33 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v2ndt-000WW3-2o for pgsql-hackers@postgresql.org; Sun, 28 Sep 2025 09:24:32 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 545C71400067; Sun, 28 Sep 2025 05:24:26 -0400 (EDT) Received: from phl-imap-17 ([10.202.2.105]) by phl-compute-04.internal (MEProxy); Sun, 28 Sep 2025 05:24:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1759051466; x=1759137866; bh=ECPlZVCLUy 2iTks1XTuXLFgND7lL5X768j/RZ22fELk=; b=qHrGIPHHeMSA0PKaUeY1VYauSi xRwtx/UDXxLWWjTWVPf+MurDATXbamXL0bS0nbLfo0euGkhc/+5+yYpIWtgPWTT2 RyFeW4rctjJa6FwtOReQaUW6okGHVR9Bthsnmzr//hB6MlYZ+bCITuJnt28UROvk yaazrG5+O0R5An7X4K11oZpmj6isGrIhRjE7hNzjpybJaSXHpH80xPNS6yZ5qW65 aa5WuUO5nWDV2TzQmOwISV1VohH7gVSSPtWiI0y+JF8kAkP50nIfD7DQSRXBrSCS 6TOJjnFfPFORheeyP4mMhQeIaO42W25iXfAI6OYe3T8uhw1d677c+Bnvlv0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759051466; x=1759137866; bh=ECPlZVCLUy2iTks1XTuXLFgND7lL5X768j/ RZ22fELk=; b=rHR47z1CKMVtji91+2CS3l6H7LHtt5HKez9/xUFdNEDhVpsIhzb cJFBYVM8T8BwHqSdRicpuIm9IjdZBnb5pFXzTnWD27BcgTMQzrAkT/G71Ra6EPif dWRfJj/++gRlTW1GfBPpxdv8SPvWxNqacAQ/uFS7JMU81IqOAaewC5sCDPq1wAsB UPxFKBZ57mbNzIjDW+XDHNAAd3dArsVCMQ2DcKan2BJg7kgmpqFth9wE3kqLWIQC IAecYNOX3gygpKGVQuu2QywAhLz4nN1ZTRvaf7ah/V9sBceq1bZ3cQfq0hbrMVch eeKnD+r+R8DumGlkpYlt4sXicn3PRTtYPNA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdejgeejiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefoggffhffvkfgjfhfutgesmhdtreerredtjeenucfhrhhomheplmhlvhgrrhhoucfj vghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtffrrg htthgvrhhnpeetgeeutedthfdvleeileelueffkedtveegffffleeggeehgfefteduvedv ueeikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepphgvthgvrhesvghishgvnhhtrhgruhhtrd horhhgpdhrtghpthhtohepphhgshhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqhhl rdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id F1B07C40077; Sun, 28 Sep 2025 05:24:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 X-ThreadId: Ay-uI6GIQHpg Date: Sun, 28 Sep 2025 11:23:51 +0200 From: =?UTF-8?Q?=C3=81lvaro_Herrera?= To: "Peter Eisentraut" , pgsql-hackers Message-Id: In-Reply-To: <10d32190-f31b-40a5-b177-11db55597355@eisentraut.org> References: <10d32190-f31b-40a5-b177-11db55597355@eisentraut.org> Subject: Re: allow benign typedef redefinitions (C11) Content-Type: multipart/mixed; boundary=bd12487871c74690b1b9fb3b7790cce1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --bd12487871c74690b1b9fb3b7790cce1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Here's another simple piece that I noticed while fooling around with the= doxygen report -- genam.h was including tidbitmap.h and relcache.h for = the sake of one typedefs each, and this was bleeding in other places in = a rather random fashion, particularly through amapi.h. I propose the fo= llowing to fix it. The changes to inet.h and varbit.h are surprising, b= ut required. (It's possible that we should be including varatt.h in mor= e datatype headers than just those two, but at least these are the ones = that complained. So another option would be to include varatt.h in the = files that include those headers. However, that seems to me to be the wr= ong direction). --=20 =C3=81lvaro Herrera --bd12487871c74690b1b9fb3b7790cce1 Content-Disposition: attachment; filename*0="0001-Remove-genam.h-s-dependency-on-relcache.h-and-tidbit.pat"; filename*1="ch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-Remove-genam.h-s-dependency-on-relcache.h-and-tidbit.patc?= =?UTF-8?Q?h?=" Content-Transfer-Encoding: base64 RnJvbSAzMmFkNzIyOGIzMDczZTI5NmY4NzY3MGQ2ZTRkOGEwZGJmZGQxMDBhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUMzPTgxbHZhcm89MjBIZXJyZXJh Pz0gPGFsdmhlcnJlQGt1cmlsZW11LmRlPgpEYXRlOiBTdW4sIDI4IFNlcCAyMDI1IDExOjE1 OjUxICswMjAwClN1YmplY3Q6IFtQQVRDSF0gUmVtb3ZlIGdlbmFtLmgncyBkZXBlbmRlbmN5 IG9uIHJlbGNhY2hlLmggYW5kIHRpZGJpdG1hcC5oCgotLS0KIHNyYy9pbmNsdWRlL2FjY2Vz cy9hbWFwaS5oICB8IDIgKysKIHNyYy9pbmNsdWRlL2FjY2Vzcy9nZW5hbS5oICB8IDYgKysr Ky0tCiBzcmMvaW5jbHVkZS9hY2Nlc3MvbmJ0cmVlLmggfCAxICsKIHNyYy9pbmNsdWRlL3V0 aWxzL2luZXQuaCAgICB8IDEgKwogc3JjL2luY2x1ZGUvdXRpbHMvdmFyYml0LmggIHwgMSAr CiA1IGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9zcmMvaW5jbHVkZS9hY2Nlc3MvYW1hcGkuaCBiL3NyYy9pbmNsdWRlL2Fj Y2Vzcy9hbWFwaS5oCmluZGV4IDJiNDQ4MmRjMWU2Li42M2RkNDFjMWYyMSAxMDA2NDQKLS0t IGEvc3JjL2luY2x1ZGUvYWNjZXNzL2FtYXBpLmgKKysrIGIvc3JjL2luY2x1ZGUvYWNjZXNz L2FtYXBpLmgKQEAgLTE1LDYgKzE1LDggQEAKICNpbmNsdWRlICJhY2Nlc3MvY21wdHlwZS5o IgogI2luY2x1ZGUgImFjY2Vzcy9nZW5hbS5oIgogI2luY2x1ZGUgImFjY2Vzcy9zdHJhdG51 bS5oIgorI2luY2x1ZGUgIm5vZGVzL25vZGVzLmgiCisjaW5jbHVkZSAibm9kZXMvcGdfbGlz dC5oIgogCiAvKgogICogV2UgZG9uJ3Qgd2lzaCB0byBpbmNsdWRlIHBsYW5uZXIgaGVhZGVy IGZpbGVzIGhlcmUsIHNpbmNlIG1vc3Qgb2YgYW4gaW5kZXgKZGlmZiAtLWdpdCBhL3NyYy9p bmNsdWRlL2FjY2Vzcy9nZW5hbS5oIGIvc3JjL2luY2x1ZGUvYWNjZXNzL2dlbmFtLmgKaW5k ZXggYWM2MmY2YTZhYmQuLmUyM2ViMDQ2NTBiIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9h Y2Nlc3MvZ2VuYW0uaAorKysgYi9zcmMvaW5jbHVkZS9hY2Nlc3MvZ2VuYW0uaApAQCAtMTcs MTUgKzE3LDE3IEBACiAjaW5jbHVkZSAiYWNjZXNzL2h0dXAuaCIKICNpbmNsdWRlICJhY2Nl c3Mvc2Rpci5oIgogI2luY2x1ZGUgImFjY2Vzcy9za2V5LmgiCi0jaW5jbHVkZSAibm9kZXMv dGlkYml0bWFwLmgiCiAjaW5jbHVkZSAic3RvcmFnZS9idWYuaCIKICNpbmNsdWRlICJzdG9y YWdlL2xvY2tkZWZzLmgiCi0jaW5jbHVkZSAidXRpbHMvcmVsY2FjaGUuaCIKICNpbmNsdWRl ICJ1dGlscy9zbmFwc2hvdC5oIgogCiAvKiBXZSBkb24ndCB3YW50IHRoaXMgZmlsZSB0byBk ZXBlbmQgb24gZXhlY25vZGVzLmguICovCiB0eXBlZGVmIHN0cnVjdCBJbmRleEluZm8gSW5k ZXhJbmZvOwogdHlwZWRlZiBzdHJ1Y3QgVHVwbGVUYWJsZVNsb3QgVHVwbGVUYWJsZVNsb3Q7 CisvKiBvciB0aWRiaXRtYXAuaCAqLwordHlwZWRlZiBzdHJ1Y3QgVElEQml0bWFwIFRJREJp dG1hcDsKKy8qIG9yIHJlbGNhY2hlLmggKi8KK3R5cGVkZWYgc3RydWN0IFJlbGF0aW9uRGF0 YSAqUmVsYXRpb247CiAKIAogLyoKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL2FjY2Vzcy9u YnRyZWUuaCBiL3NyYy9pbmNsdWRlL2FjY2Vzcy9uYnRyZWUuaAppbmRleCA5YWI0NjdjYjhm ZC4uZGIxMzQ1ZjU0YzggMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL2FjY2Vzcy9uYnRyZWUu aAorKysgYi9zcmMvaW5jbHVkZS9hY2Nlc3MvbmJ0cmVlLmgKQEAgLTIyLDYgKzIyLDcgQEAK ICNpbmNsdWRlICJjYXRhbG9nL3BnX2luZGV4LmgiCiAjaW5jbHVkZSAibGliL3N0cmluZ2lu Zm8uaCIKICNpbmNsdWRlICJzdG9yYWdlL2J1Zm1nci5oIgorI2luY2x1ZGUgInN0b3JhZ2Uv ZHNtLmgiCiAjaW5jbHVkZSAic3RvcmFnZS9zaG1fdG9jLmgiCiAjaW5jbHVkZSAidXRpbHMv c2tpcHN1cHBvcnQuaCIKIApkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvdXRpbHMvaW5ldC5o IGIvc3JjL2luY2x1ZGUvdXRpbHMvaW5ldC5oCmluZGV4IGFjZTg5NTdmMjIwLi5mMDhjZjJh YmM5NSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvdXRpbHMvaW5ldC5oCisrKyBiL3NyYy9p bmNsdWRlL3V0aWxzL2luZXQuaApAQCAtMTUsNiArMTUsNyBAQAogI2RlZmluZSBJTkVUX0gK IAogI2luY2x1ZGUgImZtZ3IuaCIKKyNpbmNsdWRlICJ2YXJhdHQuaCIKIAogLyoKICAqCVRo aXMgaXMgdGhlIGludGVybmFsIHN0b3JhZ2UgZm9ybWF0IGZvciBJUCBhZGRyZXNzZXMKZGlm ZiAtLWdpdCBhL3NyYy9pbmNsdWRlL3V0aWxzL3ZhcmJpdC5oIGIvc3JjL2luY2x1ZGUvdXRp bHMvdmFyYml0LmgKaW5kZXggN2I4MWU4ZTZiYmMuLmY2MzNlMjMyNTAyIDEwMDY0NAotLS0g YS9zcmMvaW5jbHVkZS91dGlscy92YXJiaXQuaAorKysgYi9zcmMvaW5jbHVkZS91dGlscy92 YXJiaXQuaApAQCAtMTgsNiArMTgsNyBAQAogI2luY2x1ZGUgPGxpbWl0cy5oPgogCiAjaW5j bHVkZSAiZm1nci5oIgorI2luY2x1ZGUgInZhcmF0dC5oIgogCiAvKgogICogTW9kZWxlZCBv biBzdHJ1Y3QgdmFybGVuYSBmcm9tIGMuaCwgYnV0IGRhdGEgdHlwZSBpcyBiaXRzOC4KLS0g CjIuNDcuMwoK --bd12487871c74690b1b9fb3b7790cce1--