Message-ID: <a09986e3-958c-4151-8244-f43c28701ddf@oss.nttdata.com>
Date: Wed, 9 Jul 2025 20:42:42 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Extend ALTER DEFAULT PRIVILEGES for large objects
To: Yugo Nagata <nagata@sraoss.co.jp>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>,
 Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
References: <20240424115242.236b499b2bed5b7a27f7a418@sraoss.co.jp>
 <3602391.1713930458@sss.pgh.pa.us> <20240424210839.GA863220@nathanxps13>
 <20240426175406.13e47ea3904de814afbfe496@sraoss.co.jp>
 <20240913161801.b1e60534d77fa9df447b775f@sraoss.co.jp>
 <9c0c4d7881d2450baf70edb0ae95415a81ac8cb1.camel@cybertec.at>
 <20250123192220.9bad2b9aec110bf335521276@sraoss.co.jp>
 <fb552452-d61f-403b-85c1-187ea7f030af@oss.nttdata.com>
 <20250403230418.f41b23d155f6c6cb3cebcd92@sraoss.co.jp>
 <dfa9a1fc-1570-45a0-8735-57c414629cec@oss.nttdata.com>
 <ade0ab29-777f-47f6-9d0d-1af67728a86e@oss.nttdata.com>
 <20250408122857.b2b06dde4e6a08290af02336@sraoss.co.jp>
 <20250611114937.b067c542192f8e5e740a2a4a@sraoss.co.jp>
 <b448cc01-ce8d-45f3-a922-c63490bbdec4@oss.nttdata.com>
 <20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
Content-Language: en-US
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <20250611135737.bb7d3135141248819704ebca@sraoss.co.jp>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/a09986e3-958c-4151-8244-f43c28701ddf%40oss.nttdata.com>
Precedence: bulk


On 2025/06/11 13:57, Yugo Nagata wrote:
> On Wed, 11 Jun 2025 13:33:07 +0900
> Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
>>
>>
>> On 2025/06/11 11:49, Yugo Nagata wrote:
>>> While looking at the thread [1], I've remembered this thread.
>>> The patches in this thread are partially v18-related, but include
>>> enhancement or fixes for existing feature, so should they be postponed
>>> to v19, or should be separated properly to v18 part and other?
>>>
>>> [1] https://www.postgresql.org/message-id/70372bdd-4399-4d5b-ab4f-6d4487a4911a%40oss.nttdata.com
>>
>> I see these patches more as enhancements to psql tab-completion,
>> rather than fixes for clear oversights in the original commit.
>>
>> For example, if tab-completion for ALTER DEFAULT PRIVILEGES had
>> completely missed LARGE OBJECTS, that would be an obvious oversight.
>> But these patches go beyond that kind of issue.
>>
>> That said, if others think it's appropriate to include them in v18
>> for consistency or completeness, I'm fine with that.
>>
>> Regarding the 0002 patch:
>>
>> -	else if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
>> -		COMPLETE_WITH("TO");
>> -	else if (Matches("REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
>> -		COMPLETE_WITH("FROM");
>> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
>> +	{
>> +		if (TailMatches("FOREIGN", "SERVER"))
>> +			COMPLETE_WITH_QUERY(Query_for_list_of_servers);
>> +		else if (!TailMatches("LARGE", "OBJECT"))
>> +		{
>> +			if (Matches("GRANT", MatchAnyN, "ON", MatchAny, MatchAny))
>> +				COMPLETE_WITH("TO");
>> +			else
>> +				COMPLETE_WITH("FROM");
>> +		}
>> +	}
>>
>> Wouldn't this change break the case where "GRANT ... ON TABLE ... <TAB>"
>> is supposed to complete with "TO"?
> 
> Sorry, I made a stupid mistake.
> 
>> +	else if (Matches("GRANT/REVOKE", MatchAnyN, "ON", MatchAny, MatchAny))
> 
> This should be "GRANT|REVOKE".
> 
> I've attached update patches. (There is no change on 0001.)

Thanks for updating the patch! At first I've pushed the 0001 patch.

As for the 0002 patch:

+		if (TailMatches("FOREIGN", "SERVER"))
+			COMPLETE_WITH_QUERY(Query_for_list_of_servers);

This part seems not needed, since we already have the following tab-completion code:

/* FOREIGN SERVER */
	else if (TailMatches("FOREIGN", "SERVER"))
		COMPLETE_WITH_QUERY(Query_for_list_of_servers);

Thought?

Regards,

-- 
Fujii Masao
NTT DATA Japan Corporation