Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFm9P-0001G0-Rl for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Feb 2022 00:08:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nFm9O-0007kr-GP for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Feb 2022 00:08:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFm9O-0007ki-7M for pgsql-hackers@lists.postgresql.org; Fri, 04 Feb 2022 00:08:30 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nFm9L-0002EV-Lw for pgsql-hackers@postgresql.org; Fri, 04 Feb 2022 00:08:29 +0000 Received: from [192.168.11.9] (p2019072-ipbf2307funabasi.chiba.ocn.ne.jp [122.30.130.72]) by oss.nttdata.com (Postfix) with ESMTPSA id D38896060A; Fri, 4 Feb 2022 09:08:22 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.5 at oss.nttdata.com Message-ID: Date: Fri, 4 Feb 2022 09:08:22 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: Fix CheckIndexCompatible comment Content-Language: en-US To: Yugo NAGATA , pgsql-hackers@postgresql.org References: <20220204014634.b39314f278ff4ae3de96e201@sraoss.co.jp> From: Fujii Masao In-Reply-To: <20220204014634.b39314f278ff4ae3de96e201@sraoss.co.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022/02/04 1:46, Yugo NAGATA wrote: > Hello, > > I found a old parameter name 'heapRelation' in the comment > of CheckIndexCompatible. This parameter was removed by 5f173040. > > Attached is a patch to remove it from the comment. Thanks for the report! I agree to remove the mention of parameter already dropped, from the comment. OTOH, I found CheckIndexCompatible() now has "oldId" parameter but there is no comment about it though there are comments about other parameters. Isn't it better to add the comment about "oldId"? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION