Content-Type: multipart/mixed; boundary="------------sJgux6tB0M0HDhUkgc5LMhGH"
Message-ID: <a0d57cf7-1f41-456a-8b9e-eeb28d927a70@postgrespro.ru>
Date: Mon, 30 Mar 2026 10:56:02 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Fix race with LLVM and bison.
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
References: <f070a61e-1dd3-4fd9-bbc9-18d100b6722a@postgrespro.ru>
 <v67jke2iv6kaywjnvwhxc3u5x3ttvrz555k5ngcxu2qwu435rl@5wpsxnrsz23k>
Content-Language: en-US
From: "Maksim.Melnikov" <m.melnikov@postgrespro.ru>
In-Reply-To: <v67jke2iv6kaywjnvwhxc3u5x3ttvrz555k5ngcxu2qwu435rl@5wpsxnrsz23k>
Archived-At: 
 <https://www.postgresql.org/message-id/a0d57cf7-1f41-456a-8b9e-eeb28d927a70%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------sJgux6tB0M0HDhUkgc5LMhGH
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi

On 3/27/26 21:56, Andres Freund wrote:
> Hi,
>
> On 2026-03-27 14:31:52 +0300, Maksim.Melnikov wrote:
>> I've found build error in configuration --with-llvm
>>
>> CPPFLAGS="-O2" ./configure --enable-debug --enable-cassert
>> --enable-tap-tests --with-openssl --with-icu  --with-llvm
>>
>> ....
>>
>> make world-bin -j3
>>
>> ....
>>
>> cubescan.c:9:10: fatal error: 'cubeparse.h' file not found
>>      9 | #include "cubeparse.h"  /* must be after cubedata.h for YYSTYPE and
>> NDBOX */
>>
>> ....
>> segscan.c:9:10: fatal error: 'segparse.h' file not found
>>      9 | #include "segparse.h"   /* must be after segdata.h for SEG */
>>
>>
>> The reason is race, that exist between LLVM compilation and bison source
>> code generation and compilation can occur first.
>>
>> Ideally LLVM compilation target should depend on header files targets.
>>
>> The error is difficult to reproduce and I've done simple patch to have
>> stable reproducing. Fix patch is also attached.
> You don't need a sleep to show there's a problem, you can just do
>     make -C contrib/cube cubescan.bc
>
> We don't have the same issue in the backend, as for backend code each .bc file
> depends on the .o file:
>
> src/backend/common.mk:
>
> ifeq ($(with_llvm), yes)
> objfiles.txt: $(patsubst %.o,%.bc, $(OBJS))
> $(patsubst %.o,%.bc, $(OBJS)): $(OBJS)
> endif
>
> But for some reason I didn't add the same logic to pgxs.mk.
>
> I think we need something like the attached to make the dependencies work.
>
>
> I'm a bit worried about breaking some extensions if were to backpatch this. So
> I'm somewhat inclined to just fix this in master.
>
> Greetings,
>
> Andres Freund

Thanks for attentions, I see your patch is better. Few additional thoughts

1. Now I see that we have two different places to configure backend and 
extensions, maybe we should

apply your patch to some common place, for example 
src/Makefile.global.in, because it seems common

build logic. How do you think?

2. If you have some doubts about backpatch, I suggest to apply 
fix-llvm-contrib-pgxs-deps.diff on master

and patch 
v2-0001-Fix-race-with-LLVM-compilation-and-bison-code-gen.patch as 
backpatch, because this one

correct it only for problematic contribs. How do you think?

Greetings,

Maksim Melnikov

--------------sJgux6tB0M0HDhUkgc5LMhGH
Content-Type: text/x-patch; charset=UTF-8;
 name="v2-0001-Fix-race-with-LLVM-compilation-and-bison-code-gen.patch"
Content-Disposition: attachment;
 filename*0="v2-0001-Fix-race-with-LLVM-compilation-and-bison-code-gen.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSAwZjcyMjM5Njg0NjI3NzM4N2M4ODYwNmFkZGJhYTgxNjBmM2VlZTllIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYWtzaW0gTWVsbmlrb3YgPG0ubWVsbmlrb3ZAcG9z
dGdyZXNwcm8ucnU+CkRhdGU6IEZyaSwgMjcgTWFyIDIwMjYgMTM6MzM6MDkgKzAzMDAKU3Vi
amVjdDogW1BBVENIIHYyXSBGaXggcmFjZSB3aXRoIExMVk0gY29tcGlsYXRpb24gYW5kIGJp
c29uIGNvZGUgZ2VuZXJhdGlvbi4KCkluIGNhc2Ugd2hlbiBzb3VyY2UgZmlsZSBpcyBjb21w
aWxlZCB3aXRoIExMVk0gYW5kIGluY2x1ZGUgaGVhZGVyIGZpbGUKdGhhdCBzaG91bGQgYmUg
Z2VuZXJhdGVkIGJ5IGJpc29uLCBjb21waWxlIGVycm9yIGNhbiBvY2N1ciwgZXhhbXBsZToK
CmN1YmVzY2FuLmM6OToxMDogZmF0YWwgZXJyb3I6ICdjdWJlcGFyc2UuaCcgZmlsZSBub3Qg
Zm91bmQKICAgIDkgfCAjaW5jbHVkZSAiY3ViZXBhcnNlLmgiCgpUaGUgcmVhc29uIGlzIHJh
Y2UsIHRoYXQgZXhpc3QgYmV0d2VlbiBMTFZNIGNvbXBpbGF0aW9uIGFuZCBiaXNvbiBjb2Rl
CmdlbmVyYXRpb24gYW5kIGNvbXBpbGF0aW9uIGNhbiBvY2N1ciBmaXJzdC4gSWRlYWxseSBM
TFZNIGNvbXBpbGF0aW9uCnRhcmdldCBzaG91bGQgZGVwZW5kIG9uIC5vIGZpbGVzIHRhcmdl
dHMuCi0tLQogY29udHJpYi9jdWJlL01ha2VmaWxlIHwgNCArKysrCiBjb250cmliL3NlZy9N
YWtlZmlsZSAgfCA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCgpk
aWZmIC0tZ2l0IGEvY29udHJpYi9jdWJlL01ha2VmaWxlIGIvY29udHJpYi9jdWJlL01ha2Vm
aWxlCmluZGV4IGRmYjBkODA2ZTRiLi5kODRhZDNmYzNlOSAxMDA2NDQKLS0tIGEvY29udHJp
Yi9jdWJlL01ha2VmaWxlCisrKyBiL2NvbnRyaWIvY3ViZS9NYWtlZmlsZQpAQCAtMzUsNiAr
MzUsMTAgQEAgZW5kaWYKIGN1YmVwYXJzZS5oOiBjdWJlcGFyc2UuYwogCXRvdWNoICRACiAK
K2lmZXEgKCQod2l0aF9sbHZtKSwgeWVzKQorY3ViZXNjYW4uYmM6IGN1YmVzY2FuLm8KK2Vu
ZGlmCisKIGN1YmVwYXJzZS5jOiBCSVNPTkZMQUdTICs9IC1kCiAKICMgRm9yY2UgdGhlc2Ug
ZGVwZW5kZW5jaWVzIHRvIGJlIGtub3duIGV2ZW4gd2l0aG91dCBkZXBlbmRlbmN5IGluZm8g
YnVpbHQ6CmRpZmYgLS1naXQgYS9jb250cmliL3NlZy9NYWtlZmlsZSBiL2NvbnRyaWIvc2Vn
L01ha2VmaWxlCmluZGV4IGI0MDhmNDA0OWNiLi5kZGU5OTZjYTVjNSAxMDA2NDQKLS0tIGEv
Y29udHJpYi9zZWcvTWFrZWZpbGUKKysrIGIvY29udHJpYi9zZWcvTWFrZWZpbGUKQEAgLTM0
LDYgKzM0LDEwIEBAIGVuZGlmCiBzZWdwYXJzZS5oOiBzZWdwYXJzZS5jCiAJdG91Y2ggJEAK
IAoraWZlcSAoJCh3aXRoX2xsdm0pLCB5ZXMpCitzZWdzY2FuLmJjOiBzZWdzY2FuLm8KK2Vu
ZGlmCisKIHNlZ3BhcnNlLmM6IEJJU09ORkxBR1MgKz0gLWQKIAogIyBGb3JjZSB0aGVzZSBk
ZXBlbmRlbmNpZXMgdG8gYmUga25vd24gZXZlbiB3aXRob3V0IGRlcGVuZGVuY3kgaW5mbyBi
dWlsdDoKLS0gCjIuNDMuMAoK

--------------sJgux6tB0M0HDhUkgc5LMhGH--