public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mircea Cadariu <[email protected]>
To: Anthonin Bonnefoy <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Japin Li <[email protected]>
Subject: Re: Propagate XLogFindNextRecord error to callers
Date: Mon, 9 Feb 2026 14:15:34 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAO6_Xqqv5F2cdgs5zCVzLJMOuO6zStsC97gcm41dFNSWOh6B8A@mail.gmail.com>
References: <CAO6_XqoxJXddcT4wkd9Xd+cD6Sz-fyspRGuV4Bq-wbXG4pVNzA@mail.gmail.com>
<[email protected]>
<CAO6_Xqqd316HhigkBsE-rC8oVsAprc_mVh5Z312D+aUOzW-5Jg@mail.gmail.com>
<MEAPR01MB3031690E672656BB573711B3B665A@MEAPR01MB3031.ausprd01.prod.outlook.com>
<CAO6_Xqqv5F2cdgs5zCVzLJMOuO6zStsC97gcm41dFNSWOh6B8A@mail.gmail.com>
Hi Anthonin,
Thanks for the updated patch.
I have noticed this code added in XLogFindNextRecord in the patch,
appears also in XLogNextRecord (line 334).
> + if (state->errormsg_deferred)
> + {
> + if (state->errormsg_buf[0] != '\0')
> + *errormsg = state->errormsg_buf;
> + state->errormsg_deferred = false;
> + }
> +
In XLogNextRecord, right before the above code, we do *errormsg = NULL.
Should this be done also in XLogFindNextRecord in the patch?
If so, what about even extracting a helper method which will be called
from both places?
A nit for the commit message: Propage -> Propagate
--
Thanks,
Mircea Cadariu
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Propagate XLogFindNextRecord error to callers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox