public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v6 05/10] doc: s/evade/avoid/ 2+ messages / 2 participants [nested] [flat]
* [PATCH v6 05/10] doc: s/evade/avoid/ @ 2020-04-06 22:16 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2020-04-06 22:16 UTC (permalink / raw) --- src/backend/access/gin/README | 2 +- src/backend/utils/adt/jsonpath_exec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/access/gin/README b/src/backend/access/gin/README index 125a82219b..41d4e1e8a0 100644 --- a/src/backend/access/gin/README +++ b/src/backend/access/gin/README @@ -413,7 +413,7 @@ leftmost leaf of the tree. Deletion algorithm keeps exclusive locks on left siblings of pages comprising currently investigated path. Thus, if current page is to be removed, all required pages to remove both downlink and rightlink are already locked. That -evades potential right to left page locking order, which could deadlock with +avoids potential right to left page locking order, which could deadlock with concurrent stepping right. A search concurrent to page deletion might already have read a pointer to the diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c index f146767bfc..2d2eb7d7a3 100644 --- a/src/backend/utils/adt/jsonpath_exec.c +++ b/src/backend/utils/adt/jsonpath_exec.c @@ -35,7 +35,7 @@ * executeItemOptUnwrapTarget() function have 'unwrap' argument, which indicates * whether unwrapping of array is needed. When unwrap == true, each of array * members is passed to executeItemOptUnwrapTarget() again but with unwrap == false - * in order to evade subsequent array unwrapping. + * in order to avoid subsequent array unwrapping. * * All boolean expressions (predicates) are evaluated by executeBoolItem() * function, which returns tri-state JsonPathBool. When error is occurred -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0006-doc-Add-logical-replication-support-to-replicate-.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: shared-memory based stats collector - v70 @ 2024-12-03 10:37 Anton A. Melnikov <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Anton A. Melnikov @ 2024-12-03 10:37 UTC (permalink / raw) To: Drouvot, Bertrand <[email protected]>; Andres Freund <[email protected]>; Greg Stark <[email protected]>; +Cc: Tom Lane <[email protected]>; Melanie Plageman <[email protected]>; Kyotaro Horiguchi <[email protected]>; Justin Pryzby <[email protected]>; Thomas Munro <[email protected]>; David G. Johnston <[email protected]>; PostgreSQL Hackers <[email protected]> Hi! Found a place in the code of this patch that is unclear to me: https://github.com/postgres/postgres/blob/1acf10549e64c6a52ced570d712fcba1a2f5d1ec/src/backend/utils... Owing assert() the next if() should never be performed, but the comment above says the opposite. Is this assert really needed here? And if so, for what? Would be glad for clarification. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-12-03 10:37 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-04-06 22:16 [PATCH v6 05/10] doc: s/evade/avoid/ Justin Pryzby <[email protected]> 2024-12-03 10:37 Re: shared-memory based stats collector - v70 Anton A. Melnikov <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox