Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBw7S-0007NL-J0 for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 11:35:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qBw7Q-0008Td-1T for pgsql-hackers@arkaria.postgresql.org; Wed, 21 Jun 2023 11:35:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBw7P-0008Qs-Ni for pgsql-hackers@lists.postgresql.org; Wed, 21 Jun 2023 11:35:23 +0000 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qBw7M-003oEx-CC for pgsql-hackers@postgresql.org; Wed, 21 Jun 2023 11:35:22 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3C5A4C0006; Wed, 21 Jun 2023 11:35:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------IyERfZk06YMuaQxPBM2m71M4" Message-ID: Date: Wed, 21 Jun 2023 07:35:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: pgindent vs. pgperltidy command-line arguments Content-Language: en-US To: Peter Eisentraut , Tom Lane Cc: pgsql-hackers References: <45aacd8a-5265-d9da-8df2-b8e2c0cf6a07@eisentraut.org> <1471230.1685020832@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------IyERfZk06YMuaQxPBM2m71M4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2023-06-21 We 05:09, Peter Eisentraut wrote: > On 20.06.23 17:38, Andrew Dunstan wrote: >>>> +1, although I wonder if we shouldn't follow pgindent's new lead >>>> and require some argument(s). >>> >>> That makes sense to me.  Here is a small update with this behavior >>> change and associated documentation update. >> >> I'm intending to add some of the new pgindent features to pgperltidy. >> Preparatory to that here's a rewrite of pgperltidy in perl - no new >> features yet but it does remove the hardcoded path, and requires you >> to pass in one or more files / directories as arguments. > > Are you planning to touch pgperlcritic and pgperlsyncheck as well? Yeah, it would make sense to. > If not, part of my patch would still be useful.  Maybe I should commit > my posted patch for PG16, to keep consistency with pgindent, and then > your work would presumably be considered for PG17. That sounds like a good plan. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------IyERfZk06YMuaQxPBM2m71M4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 2023-06-21 We 05:09, Peter Eisentraut wrote:
On 20.06.23 17:38, Andrew Dunstan wrote:
+1, although I wonder if we shouldn't follow pgindent's new lead
and require some argument(s).

That makes sense to me.  Here is a small update with this behavior change and associated documentation update.

I'm intending to add some of the new pgindent features to pgperltidy. Preparatory to that here's a rewrite of pgperltidy in perl - no new features yet but it does remove the hardcoded path, and requires you to pass in one or more files / directories as arguments.

Are you planning to touch pgperlcritic and pgperlsyncheck as well? 


Yeah, it would make sense to.


If not, part of my patch would still be useful.  Maybe I should commit my posted patch for PG16, to keep consistency with pgindent, and then your work would presumably be considered for PG17.


That sounds like a good plan.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------IyERfZk06YMuaQxPBM2m71M4--