Message-ID: <a15b72bb-681a-4d17-a0dc-98acc16d3db8@proxel.se>
Date: Sat, 3 Jan 2026 19:44:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: not fully correct error message
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Marcos Pegoraro <marcos@f10.com.br>,
 Pavel Stehule <pavel.stehule@gmail.com>,
 jian he <jian.universality@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAFj8pRCveWPR06bbad9GnMb0Kcr6jnXPttv9XOaOB+oFCD1Tsg@mail.gmail.com>
 <CACJufxEOQ+2=L3aLBzW6A4vu75gN7vKw07+QgU_398Avqb5KTg@mail.gmail.com>
 <CAFj8pRBoybDsAZdQJ3nz=E1uCSu3Buoa+VXM8wnwy6ixKqzYxA@mail.gmail.com>
 <CAB-JLwZGsWHcK3tnD-uUZf=QTRC0NJQ7qxdQrDYk2b_uFPTaww@mail.gmail.com>
 <8fa16ea7-09a1-4ec2-b668-1e36d4c8ace4@proxel.se>
 <409108.1767463422@sss.pgh.pa.us>
From: Andreas Karlsson <andreas@proxel.se>
Content-Language: en-US
In-Reply-To: <409108.1767463422@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a15b72bb-681a-4d17-a0dc-98acc16d3db8%40proxel.se>
Precedence: bulk

On 1/3/26 7:03 PM, Tom Lane wrote:
> Andreas Karlsson <andreas@proxel.se> writes:
>> A potential third option would be to take your solution but to add a
>> HINT about that it needs to run as a top-level statement outside any
>> transactions, but I kinda liked how simple the original patch was.
> 
> Yeah, I like just adding "or procedure" and calling it good.
> I do not think we need a regression test, either ...

Yeah, let's keep it simple.

> Poking around, I also found this:
> 
> src/backend/commands/wait.c:                              errdetail("WAIT FOR cannot be executed from a function or a procedure or within a transaction with an isolation level higher than READ COMMITTED."));
> 
> which is also not great grammar.  What do you think of "WAIT FOR
> cannot be executed from a function or procedure, nor within a
> transaction with an isolation level higher than READ COMMITTED." ?

Much better!

Andreas