Feedback-ID: ie0a040ee:Fastmail
Message-ID: <a16ca682-c10f-4e2c-9734-c742c9319cda@eisentraut.org>
Date: Mon, 6 Jan 2025 15:41:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: initdb -c "track_commit_timestamp=on" crashes in case of debug
 build
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 "'pgsql-hackers@lists.postgresql.org'" <pgsql-hackers@lists.postgresql.org>
References: <OSCPR01MB14966FF9E4C4145F37B937E52F5102@OSCPR01MB14966.jpnprd01.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <OSCPR01MB14966FF9E4C4145F37B937E52F5102@OSCPR01MB14966.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/a16ca682-c10f-4e2c-9734-c742c9319cda%40eisentraut.org>
Precedence: bulk

On 06.01.25 14:14, Hayato Kuroda (Fujitsu) wrote:
> While working on another thread I found $subject. I've tested only on master,
> but I doubt this could happen even on PG16 and 17. You can reproduce by:
> ```
> $ initdb -D data -c "track_commit_timestamp=on"
> ...
> child process was terminated by signal 6: Aborted
> initdb: removing data directory "data"
> ```
> 
> Back-trace I got is shown in [1].
> 
> IIUC the crash was caused at TransactionIdSetCommitTs(), and the primal reason was that
> commit_ts module tried to store the bootstrap transaction.
> 
> In the first place I'm not sure we want to fix this because this happens only for
> the debug mode... but if needed, the easiest way is not to activate the commit_ts
> in the bootstrap mode. I think this fix is enough because pg_last_committed_xact()
> and TransactionIdGetCommitTsData() won't seek the un-normal xid.
> Attached patch was created based on the idea.

Yes, this was previously reported [0] but nothing was done about it.  We 
just need to find some place to "do nothing" in bootstrap mode to avoid 
the crash.  Your patch seems ok to me for that.


[0]: 
https://www.postgresql.org/message-id/8a8fda29-5a68-ba68-a2ff-8d17602b3762@enterprisedb.com