Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tbJri-009lJl-19 for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2025 13:36:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tbJrh-00EN6Z-4Z for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Jan 2025 13:36:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tbJrg-00EN6M-MI for pgsql-hackers@lists.postgresql.org; Fri, 24 Jan 2025 13:36:52 +0000 Received: from cornsilk.maple.relay.mailchannels.net ([23.83.214.40]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tbJre-001H2c-09 for pgsql-hackers@postgresql.org; Fri, 24 Jan 2025 13:36:51 +0000 X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8C1878A4F24; Fri, 24 Jan 2025 13:36:48 +0000 (UTC) Received: from fr-int-smtpout1.hostinger.io (trex-9.trex.outbound.svc.cluster.local [100.118.62.99]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id A83678A4C76; Fri, 24 Jan 2025 13:36:47 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1737725808; a=rsa-sha256; cv=none; b=KedZq8ZprkmIaLZsD515+eV70kZ3nO+wAmmF4yTyg0/aNyYTWJ356l67V+db3Q5G9jyLMu E1s6eudAjxoZ04Pcc3872yM0tuBt9fpbzuxYqSI1W3KJ8UOSUqJVo5qt+9GFENa8O+S2K+ lfqWoRZw9XaInCdV0D4XfGX+9qEqWA5wbJWm2sFCfOZ9BTTbZHOOys/qMCNZ6hcNjGFcRi bzLmqt5t5ffoZLOCy/rBUjzhp10MqKD1rtcnGNfa3GhmpkfTWq6w02xJbsjzfcIta4pO8a bvhM+f0llh93Tl+5qgZmd19XwOUYwqrQpFrDDI4HOq92NlygxbzqUz9lwRhH9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1737725808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cvoV+mZ9fWZ8khhuDZaNb64eClnHdrR1FNPDuI5peQY=; b=cM2M0axjBRzzqCt7Nj4c0rF86a2tiiErBGYmmEmmyX9s8ezQReYaEFw46dwlMs+DfaqnmP /p8r3xrYOhoY596Fm8Rp/lA1WOdthhwQQK54xuizpPbI3fu889XX9cXvYnFhvYf+l8WmwJ blYGGw9u0EdZUgm6iC5aNnTB79saZPRaU7ZpWSBsMAG07qf9eplX2oOTVZbDEJGnKDswLx g1EMMBytwLcB6QA9/islEAWxKRRutUXq8IeFsI99Gqp1/qIu+q89buJjUW25QwyiDRBDe9 qJALfnJFRxI0DTcJU3lj6L2rXX1lhWFH5e6LyWD9vrtKEQJ+8fmMa7CKpu7EIw== ARC-Authentication-Results: i=1; rspamd-7d9c9fccdc-tznr2; auth=pass smtp.auth=hostingeremail smtp.mailfrom=david@pgbackrest.org X-Sender-Id: hostingeremail|x-authuser|david@pgbackrest.org X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|david@pgbackrest.org X-MailChannels-Auth-Id: hostingeremail X-Industry-Keen: 253bb9ad005d71c0_1737725808327_2250124710 X-MC-Loop-Signature: 1737725808326:95156596 X-MC-Ingress-Time: 1737725808326 Received: from fr-int-smtpout1.hostinger.io (fr-int-smtpout1.hostinger.io [89.116.146.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.118.62.99 (trex/7.0.2); Fri, 24 Jan 2025 13:36:48 +0000 Content-Type: multipart/mixed; boundary="------------YX4n2faYVWQkzsGthgDO6xJv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgbackrest.org; s=hostingermail1; t=1737725805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cvoV+mZ9fWZ8khhuDZaNb64eClnHdrR1FNPDuI5peQY=; b=W6wYApzmxnUGtRJpqgY7ghSNF1SqVmih7lYgmP7lBdva/BjBOlp4FH6i3lHPc/st9tOFLA 7x2cbAOupNSgpWTf3jYScPReQU44+gBoOWvtduZctu7KgB09ZmICf3U+bUnKXuVDqMX7o/ /GRPNklhCQpz8uBog2SMw7KVauz8UwmdT4QPMlgIjDrNbU308fRoR6EMRYClpJQcK9NdEn he7AMY4c3BFRoEVQkVC7uiDar4nKXVo8a7+D1GcQjLibD3SqK9CpjNTtrysQ9k1RmvX1If bk5cuwsgD3jDO6pZX2ke1qAiDBy54vK9Akkvz73jDzu4bAXsLDOq/gVcvx7TPA== Message-ID: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Improve verification of recovery_target_timeline GUC. To: Michael Paquier Cc: Pg Hackers References: Content-Language: en-US From: David Steele In-Reply-To: Date: Fri, 24 Jan 2025 13:36:45 +0000 (UTC) X-CM-Analysis: v=2.4 cv=BvTPwpX5 c=1 sm=1 tr=0 ts=6793976d a=1UThGdY7977P8ty/Wg4WSA==:117 a=1UThGdY7977P8ty/Wg4WSA==:17 a=sWKEhP36mHoA:10 a=r77TgQKjGQsHNAKrUKIA:9 a=kbevix0LgmpR4Uux6eAA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=1wDIiH70AAAA:8 a=PC1sASWoG-sBVo6KlmsA:9 a=B2y7HmGcmWMA:10 a=uCsh6WI2SJRHIg0NT2Eg:22 X-CM-Envelope: MS4xfN4toABMdeXD+p7Pih9MgQXBrcwx73qjvrGqqt9OcHTurnAtrYErr52l/InsX/wjCo1z9NJAFzVOJKeJIGJyX0FONxVZMnhFOqlkfHAAdgVJ//nH3XX6 oqAfJdJdJhdhOAKi1zv8+iUxI3Ok54vVd5gxBzxu9KP+ZmizjQmobrS8iSu5VmgfpI9rVYXB7EtI9qw41eFOlwRpS+OQSB02Gi6DmL0t/303gqQ3/2bLLBDh X-AuthUser: david@pgbackrest.org List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------YX4n2faYVWQkzsGthgDO6xJv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/24/25 01:44, Michael Paquier wrote: > On Thu, Jan 23, 2025 at 02:53:39PM +0000, David Steele wrote: > >> I discovered this while testing on Postgres versions < 12 where >> The tests are probably excessive but I needed something to show that the >> verification works as expected. > > Even with your patch, specifying an incorrect name results in a > complaint about a timeline of 0. Wouldn't it be better to strengthen > the parsing in check_recovery_target_timeline() and/or the error > message reported? I attached the wrong patch. Oops! Regards, -David --------------YX4n2faYVWQkzsGthgDO6xJv Content-Type: text/plain; charset=UTF-8; name="timeline-check-v1.patch" Content-Disposition: attachment; filename="timeline-check-v1.patch" Content-Transfer-Encoding: base64 RnJvbSA0NTNjODkzNzg2OGUwYzcwZTRiZmVjZjBhMzliZjgwNTJlMzc5ZWZlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBTdGVlbGUgPGRhdmlkQHBnbWFzdGVycy5u ZXQ+CkRhdGU6IFRodSwgMjMgSmFuIDIwMjUgMTQ6NDA6NDMgKzAwMDAKU3ViamVjdDogSW1w cm92ZSB2ZXJpZmljYXRpb24gb2YgcmVjb3ZlcnlfdGFyZ2V0X3RpbWVsaW5lIEdVQy4KCkN1 cnJlbnRseSBjaGVja19yZWNvdmVyeV90YXJnZXRfdGltZWxpbmUoKSBjb252ZXJ0cyBhbnkg dmFsdWUgdGhhdCBpcyBub3QKY3VycmVudCwgbGF0ZXN0LCBvciBhIHZhbGlkIGludGVnZXIg dG8gMC4gU28gZm9yIGV4YW1wbGU6CgpyZWNvdmVyeV90YXJnZXRfdGltZWxpbmUgPSAnY3Vy cnJlbnQnCgpyZXN1bHRzIGluIHRoZSBmb2xsb3dpbmcgZXJyb3I6CgpGQVRBTDogIDIyMDIz OiByZWNvdmVyeSB0YXJnZXQgdGltZWxpbmUgMCBkb2VzIG5vdCBleGlzdAoKU2luY2UgdGhl cmUgaXMgbm8gcmFuZ2UgY2hlY2tpbmcgZm9yIHVpbnQzMiAoYnV0IHRoZXJlIGlzIGEgY2Fz dCBmcm9tIHVuc2lnbmVkIGxvbmcpIHRoaXMgc2V0dGluZzoKCnJlY292ZXJ5X3RhcmdldF90 aW1lbGluZSA9ICc5OTk5OTk5OTk5JwoKcmVzdWx0cyBpbiB0aGUgZm9sbG93aW5nIGVycm9y OgoKRkFUQUw6ICAyMjAyMzogcmVjb3ZlcnkgdGFyZ2V0IHRpbWVsaW5lIDE0MTAwNjU0MDcg ZG9lcyBub3QgZXhpc3QKCkltcHJvdmUgYnkgYWRkaW5nIGVuZHB0ciBjaGVja2luZyB0byBj YXRjaCBjb252ZXJzaW9uIGVycm9ycyBhbmQgYWRkIHJhbmdlIGNoZWNraW5nIHRvCmV4Y2x1 ZGUgdmFsdWVzIDwgMiBhbmQgZ3JlYXRlciB0aGFuIFVJTlRfTUFYLgotLS0KIHNyYy9iYWNr ZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dyZWNvdmVyeS5jICAgfCAxNCArKysrLQogc3JjL3Rl c3QvcmVjb3ZlcnkvdC8wMDNfcmVjb3ZlcnlfdGFyZ2V0cy5wbCB8IDYwICsrKysrKysrKysr KysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA3MiBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dy ZWNvdmVyeS5jIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMK aW5kZXggY2YyYjAwNzgwNmYuLjE5NDFlMzA2MWY0IDEwMDY0NAotLS0gYS9zcmMvYmFja2Vu ZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYworKysgYi9zcmMvYmFja2VuZC9hY2Nl c3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYwpAQCAtNDk3MywxNSArNDk3MywyNSBAQCBjaGVj a19yZWNvdmVyeV90YXJnZXRfdGltZWxpbmUoY2hhciAqKm5ld3ZhbCwgdm9pZCAqKmV4dHJh LCBHdWNTb3VyY2Ugc291cmNlKQogCQlydHRnID0gUkVDT1ZFUllfVEFSR0VUX1RJTUVMSU5F X0xBVEVTVDsKIAllbHNlCiAJeworCQljaGFyCQkgKmVuZHA7CisJCXVuc2lnbmVkIGxvbmcg bG9uZyB0aW1lbGluZTsKIAkJcnR0ZyA9IFJFQ09WRVJZX1RBUkdFVF9USU1FTElORV9OVU1F UklDOwogCiAJCWVycm5vID0gMDsKLQkJc3RydG91bCgqbmV3dmFsLCBOVUxMLCAwKTsKLQkJ aWYgKGVycm5vID09IEVJTlZBTCB8fCBlcnJubyA9PSBFUkFOR0UpCisJCXRpbWVsaW5lID0g c3RydG91bGwoKm5ld3ZhbCwgJmVuZHAsIDApOworCisJCWlmICgqZW5kcCAhPSAnXDAnIHx8 IGVycm5vID09IEVJTlZBTCB8fCBlcnJubyA9PSBFUkFOR0UpCiAJCXsKIAkJCUdVQ19jaGVj a19lcnJkZXRhaWwoIlwicmVjb3ZlcnlfdGFyZ2V0X3RpbWVsaW5lXCIgaXMgbm90IGEgdmFs aWQgbnVtYmVyLiIpOwogCQkJcmV0dXJuIGZhbHNlOwogCQl9CisKKwkJaWYgKHRpbWVsaW5l IDwgMiB8fCB0aW1lbGluZSA+IFVJTlRfTUFYKQorCQl7CisJCQlHVUNfY2hlY2tfZXJyZGV0 YWlsKAorCQkJCSJcInJlY292ZXJ5X3RhcmdldF90aW1lbGluZVwiIG11c3QgYmUgYmV0d2Vl biAyIGFuZCA0LDI5NCw5NjcsMjk1LiIpOworCQkJcmV0dXJuIGZhbHNlOworCQl9CiAJfQog CiAJbXlleHRyYSA9IChSZWNvdmVyeVRhcmdldFRpbWVMaW5lR29hbCAqKSBndWNfbWFsbG9j KEVSUk9SLCBzaXplb2YoUmVjb3ZlcnlUYXJnZXRUaW1lTGluZUdvYWwpKTsKZGlmZiAtLWdp dCBhL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3RhcmdldHMucGwgYi9zcmMv dGVzdC9yZWNvdmVyeS90LzAwM19yZWNvdmVyeV90YXJnZXRzLnBsCmluZGV4IDBhZTJlOTgy NzI3Li4wNDI0ZmY0YWQyMiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVjb3ZlcnkvdC8wMDNf cmVjb3ZlcnlfdGFyZ2V0cy5wbAorKysgYi9zcmMvdGVzdC9yZWNvdmVyeS90LzAwM19yZWNv dmVyeV90YXJnZXRzLnBsCkBAIC0xODcsNCArMTg3LDY0IEBAIG9rKCAkbG9nZmlsZSA9fgog CSAgcXIvRkFUQUw6IC4qIHJlY292ZXJ5IGVuZGVkIGJlZm9yZSBjb25maWd1cmVkIHJlY292 ZXJ5IHRhcmdldCB3YXMgcmVhY2hlZC8sCiAJJ3JlY292ZXJ5IGVuZCBiZWZvcmUgdGFyZ2V0 IHJlYWNoZWQgaXMgYSBmYXRhbCBlcnJvcicpOwogCisjIEludmFsaWQgdGltZWxpbmUgdGFy Z2V0Ciskbm9kZV9zdGFuZGJ5ID0gUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlci0+bmV3KCdz dGFuZGJ5XzknKTsKKyRub2RlX3N0YW5kYnktPmluaXRfZnJvbV9iYWNrdXAoJG5vZGVfcHJp bWFyeSwgJ215X2JhY2t1cCcsCisJaGFzX3Jlc3RvcmluZyA9PiAxKTsKKyRub2RlX3N0YW5k YnktPmFwcGVuZF9jb25mKAorCSdwb3N0Z3Jlc3FsLmNvbmYnLCAicmVjb3ZlcnlfdGFyZ2V0 X3RpbWVsaW5lID0gJ2JvZ3VzJyIpOworCiskcmVzID0gcnVuX2xvZygKKwlbCisJCSdwZ19j dGwnLAorCQknLS1wZ2RhdGEnID0+ICRub2RlX3N0YW5kYnktPmRhdGFfZGlyLAorCQknLS1s b2cnID0+ICRub2RlX3N0YW5kYnktPmxvZ2ZpbGUsCisJCSdzdGFydCcsCisJXSk7Citvaygh JHJlcywgJ2ludmFsaWQgcmVjb3Zlcnkgc3RhcnR1cCBmYWlscycpOworCiskbG9nZmlsZSA9 IHNsdXJwX2ZpbGUoJG5vZGVfc3RhbmRieS0+bG9nZmlsZSgpKTsKK29rKCRsb2dmaWxlID1+ IHFyL2lzIG5vdCBhIHZhbGlkIG51bWJlci8sCisJJ2ludmFsaWQgdGFyZ2V0IHRpbWVsaW1l Jyk7CisKKyMgVGltZWxpbmUgdGFyZ2V0IG91dCBvZiBtaW4gcmFuZ2UKKyRub2RlX3N0YW5k YnkgPSBQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyLT5uZXcoJ3N0YW5kYnlfMTAnKTsKKyRu b2RlX3N0YW5kYnktPmluaXRfZnJvbV9iYWNrdXAoJG5vZGVfcHJpbWFyeSwgJ215X2JhY2t1 cCcsCisJaGFzX3Jlc3RvcmluZyA9PiAxKTsKKyRub2RlX3N0YW5kYnktPmFwcGVuZF9jb25m KAorCSdwb3N0Z3Jlc3FsLmNvbmYnLCAicmVjb3ZlcnlfdGFyZ2V0X3RpbWVsaW5lID0gJzEn Iik7CisKKyRyZXMgPSBydW5fbG9nKAorCVsKKwkJJ3BnX2N0bCcsCisJCSctLXBnZGF0YScg PT4gJG5vZGVfc3RhbmRieS0+ZGF0YV9kaXIsCisJCSctLWxvZycgPT4gJG5vZGVfc3RhbmRi eS0+bG9nZmlsZSwKKwkJJ3N0YXJ0JywKKwldKTsKK29rKCEkcmVzLCAnaW52YWxpZCByZWNv dmVyeSBzdGFydHVwIGZhaWxzJyk7CisKKyRsb2dmaWxlID0gc2x1cnBfZmlsZSgkbm9kZV9z dGFuZGJ5LT5sb2dmaWxlKCkpOworb2soJGxvZ2ZpbGUgPX4gcXIvbXVzdCBiZSBiZXR3ZWVu IDIgYW5kIDQsMjk0LDk2NywyOTUvLAorCSd0YXJnZXQgdGltZWxpbWUgb3V0IG9mIG1pbiBy YW5nZScpOworCisjIFRpbWVsaW5lIHRhcmdldCBvdXQgb2YgbWF4IHJhbmdlCiskbm9kZV9z dGFuZGJ5ID0gUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlci0+bmV3KCdzdGFuZGJ5XzExJyk7 Ciskbm9kZV9zdGFuZGJ5LT5pbml0X2Zyb21fYmFja3VwKCRub2RlX3ByaW1hcnksICdteV9i YWNrdXAnLAorCWhhc19yZXN0b3JpbmcgPT4gMSk7Ciskbm9kZV9zdGFuZGJ5LT5hcHBlbmRf Y29uZigKKwkncG9zdGdyZXNxbC5jb25mJywgInJlY292ZXJ5X3RhcmdldF90aW1lbGluZSA9 ICc0Mjk0OTY3Mjk2JyIpOworCiskcmVzID0gcnVuX2xvZygKKwlbCisJCSdwZ19jdGwnLAor CQknLS1wZ2RhdGEnID0+ICRub2RlX3N0YW5kYnktPmRhdGFfZGlyLAorCQknLS1sb2cnID0+ ICRub2RlX3N0YW5kYnktPmxvZ2ZpbGUsCisJCSdzdGFydCcsCisJXSk7CitvayghJHJlcywg J2ludmFsaWQgcmVjb3Zlcnkgc3RhcnR1cCBmYWlscycpOworCiskbG9nZmlsZSA9IHNsdXJw X2ZpbGUoJG5vZGVfc3RhbmRieS0+bG9nZmlsZSgpKTsKK29rKCRsb2dmaWxlID1+IHFyL211 c3QgYmUgYmV0d2VlbiAyIGFuZCA0LDI5NCw5NjcsMjk1LywKKwkndGFyZ2V0IHRpbWVsaW1l IG91dCBvZiBtYXggcmFuZ2UnKTsKKwogZG9uZV90ZXN0aW5nKCk7Ci0tIAoyLjM0LjEKCg== --------------YX4n2faYVWQkzsGthgDO6xJv--